Commit Graph

770 Commits

Author SHA1 Message Date
97a5ba4a71 remove comments why a file gets included
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
329332ba52 chart2: sal_Bool->bool
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
692714b7da chart2: loplugin:saloverride
Change-Id: I795c8337f3d5fcf3e39849204867f0d57f40c843
2014-03-29 18:10:09 +01:00
ffaf640b73 Add API wrapper to handle properties of new GL3D chart type.
Now the new proprety gets properly imported and exported to and from ODF.

Also, more on replacing string literals with define macro constants.

Change-Id: I4b773d68610a8aeaeb239901dac166e4dc2dd80d
2014-03-29 00:47:21 -04:00
0be6a5ef37 Transfer back properties from the chart type object to template object.
Change-Id: I3484a2ae0141087835e34e4e174bdc24b3357854
2014-03-29 00:47:20 -04:00
ef15c94699 Trying to move this RoundedEdge property from Diagram to GL3DBarChartType.
Then things stop working. Go figure.

Change-Id: I38893b20104537a64d279063c7b7dd708efb0d2f
2014-03-29 00:47:20 -04:00
68e20faf3f Start using common symbols for textural UNO property names.
This will make it easier to track all uses of a UNO property name using
symbol database lookup, which is much faster and more accurate than grepping.

Change-Id: I8c2857504c29bcce01eb8c1f406dcbfb24331510
2014-03-29 00:47:19 -04:00
c260edff34 ChartTypeTemplate and its derivatives are not UNO service implementations
Change-Id: Ic4a4c0fe411c359f5305f01c8ff79ca48384b484
2014-03-28 14:14:42 +01:00
1d8f8c55f8 Missing XServiceInfo base class
Change-Id: Ib629a60d626c10ac9628d172896790e90d2daf51
2014-03-28 12:36:08 +01:00
d7f3b1effb chart::Wall is not a UNO service implementation
Change-Id: I6a5482f4d49e47d1a6289a29d1b573e25fa0b5c5
2014-03-28 12:14:53 +01:00
06a4698850 chart::impl::StockBar is not a UNO service implementation
Change-Id: I5faa0dd028dcc79d09c47fd53b7804121a062e2e
2014-03-28 11:54:21 +01:00
8bd24f37fe Missing XServiceInfo base class
Change-Id: Ib295357574a54de4716fcd2ff8f57c604729214d
2014-03-28 11:37:52 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
f6f179c502 Pass the rounded edge property to the diagram object.
Change-Id: I71fa1bf82b879a1da69ca78d53bcf8072bdfa9ae
2014-03-26 23:14:58 -04:00
cea725111c Add the UI bits for showing "rounded edge" property for GL3D chart.
Change-Id: Ia6083c423bf8286a0b562d490283f8e1328a0124
2014-03-26 23:14:58 -04:00
e1823a9f8a Add a boolean "RoundedRectangle" property to the GL 3D chart.
Change-Id: I3cb23461718c5713c1e76d0b37d92b3e7849d13b
2014-03-26 23:14:57 -04:00
975bbf29df Error: exception specification of overriding function is more lax than base
Change-Id: Iffcc2084e005b27653964ddc6e965744be370a16
2014-03-26 07:46:30 +02:00
44fc32edcd Properly import and export the new chart type to and from ODF.
Change-Id: I38e9813c6eb853dfb92b1537cea0b9ad97473b57
2014-03-25 22:50:50 -04:00
05efb605b3 Add a new skeleton plotter for the GL3D bar chart.
It plots absolutely nothing. It's just a place holder for now.

Change-Id: I6eb9cc23481391b83f6946a8b49a6176c5b29cd7
2014-03-25 22:50:50 -04:00
be1152e0cc List child type for GL3D bar chart type.
For now there is only one child type.

Change-Id: If39a3e75fdae62f0b20769c21e6a4e235ede941e
2014-03-25 22:50:49 -04:00
56aaa39ff8 Skeleton template class for GL3D bar chart type.
Still very much empty.  It needs to be filled with sub-categories.

Change-Id: Iad7ad34efb264025541b585a92ee2ea7b8fff56f
2014-03-25 22:50:49 -04:00
349a5b72bf Initial skeleton class for the new chart type. Still very much empty.
Change-Id: I5e9eaeb9337d51f59f800f8e676b8bc83b80df70
2014-03-25 22:50:48 -04:00
325ecb1d05 Let's be more defensive here by checking for null return objects.
Change-Id: I5164e7d82f882ea9fe296a5a2df616d396d6726f
2014-03-24 22:24:50 -04:00
d697a05905 Remove unused framework::IMutexGuard::reset
Change-Id: If05ef86284c4ed7bf66a6a6de17a4bf8d49e89e1
2014-03-17 17:25:16 +01:00
00550fbd19 Fold framework::IGuard into framework::IMutexGuard
Change-Id: I14a77fc3fbf225862bc01f677d09d5b5a52bb1aa
2014-03-17 17:25:16 +01:00
fc9c196df1 add property mapping to a few more chart types
Change-Id: If02f865741524f74277b77615dea1bc71fb576eb
2014-03-09 19:27:49 +01:00
1e9993be10 don't hardcode property mapping, read them from chart2::XChartType
Change-Id: I7889dbddab603d7650d58a04f53e7c5fe38fcce2
2014-03-09 19:27:49 +01:00
4b9d59dbbb no need for overwriting this method
Change-Id: I8d81f9f7d80ceabd85077acd3239069988be3586
2014-03-09 19:27:49 +01:00
4d6560f506 fdo#54938: Convert some places to use cppu::supportsService
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-04 07:30:02 -06:00
f2cdf8848c Remove visual noise from chart2
Change-Id: Ic8dc71c2815df265e1935e629e0220396a50aaac
Reviewed-on: https://gerrit.libreoffice.org/8239
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-27 00:44:41 -06:00
4ea1b80c48 Statics with non-trivial initialization must use StaticWithInit
...not StaticAggregate, as StaticAggregate does the initialization with
osl::GetGlobalMutex locked and can thus lead to deadlock.

Change-Id: I0cce0da84b5a277fdda1ebaaeba85b04011f5459
2014-02-26 23:15:25 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
83055835b1 fdo#74112 Preserve Chart displayunits properties during ODF import/export.
Change-Id: I38508b71ee5b3b966e1d36b0d253304fe17c0ec0
Reviewed-on: https://gerrit.libreoffice.org/7721
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-11 23:23:40 +00:00
b37bce11cf Resolves: rhbz#975421 wrong chart direction in Farsi
Where Farsi (and apparenly Moroccon) are RTL but have LTR
math and charts should reportedly follow the math direction

Change-Id: Ib60eaaaa90fe46ef240030a91169fdff3f736329
2014-02-06 15:11:59 +00:00
262fccfccd fix the time based rendering
I managed to screw it up already. I really need some sleep.

Change-Id: Ie1f13496cd36a6f48b2b094ac302f293d5fd5383
2014-01-29 08:09:32 +01:00
750b46025c give up with the nice solutions and enjoy the ugly hack
I was always hitting a corner case so it seems that this need some
drastic measures.

Change-Id: I3fdd278b9c3fed178513d653ef24ad8adf20cbd2
2014-01-29 08:09:30 +01:00
55656ee2e8 some improvements for the time based charting
The updating seems to work. It just does not update the references yet.

Change-Id: I0a971dbe2beb113c1c3e9ef103d77d5d8c7174a0
2014-01-29 08:09:30 +01:00
2d6e556abd first try at implementing time based updates in new chart implementation
Change-Id: I3d03e44a415023ca12548ea99a3732cba49c8074
2014-01-29 08:09:30 +01:00
a07cce8d06 remaining chart work for time based charting
Change-Id: Iac33c81df199a942ddf073f9eb1b34e147a34f3c
2014-01-29 08:09:29 +01:00
91e1d305a1 implement time based charting based on new approach
The old approach does not work with the current implementation of the
OpenGL backend. We now need to repaing every time the whole chart.

Change-Id: I2151a3f016c6ceecaec2d45db0cb967cfee59af6
2014-01-29 08:09:28 +01:00
7f0fe5444f bool improvements
Change-Id: I8e83eb52a8873e6c7372091c697158053da82488
2014-01-22 08:22:35 +01:00
2054af83fe fdo#72520 : Added property to store external data path in chart.
-  added new property entry to store xlsx external data for chart.

Change-Id: I3695865ad7e888359d1048e9bc380cba26108636
Reviewed-on: https://gerrit.libreoffice.org/7212
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-16 01:46:40 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
20bb1e6854 fdo#72304 Preserve Chart data table properties during ODF import/export.
Change-Id: I767bb32fdaddcaf742923055cc86bb19138b42be
2013-12-19 03:55:05 +01:00
12bbe8f130 Remove unnecessary macro
Change-Id: I8af2e887a6ad2b345b5b214eb02095c71cdafbc2
2013-12-12 08:26:43 +01:00
a62c2a5fa5 Don't hold css::uno::Type instances by pointer
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-12 08:26:40 +01:00