wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
351,299 Commits 5 Branches 0 Tags
ff05b6b10094de3e27f9d200c0ccdbb2f6cc76c5
Commit Graph

732 Commits

Author SHA1 Message Date
Thomas Arnhold
ff154adfdc fixincludeguards.sh: comphelper 2014-04-19 11:10:06 +02:00
Tor Lillqvist
728ec86062 Typo: s/cant/can't/ 
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
 2014-04-18 00:30:35 +03:00
Tor Lillqvist
6835d9f307 It's "its", not "it's" 
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
 2014-04-10 20:22:50 +03:00
Stephan Bergmann
b8757ee8c7 Clean up function declarations and some unused functions 
Change-Id: I5817a5ad3966918cfb1920be568b7401dd6f948c
 2014-04-07 13:48:53 +02:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Thomas Arnhold
c289013572 typo: tempoary -> temporary 2014-03-29 19:16:24 +01:00
Thomas Arnhold
59f1e95844 typo: previos -> previous 2014-03-29 19:16:24 +01:00
Thomas Arnhold
dc8f33ba5d typo: decription -> description 2014-03-29 19:16:23 +01:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Stephan Bergmann
36784563ed OAccessibleContextWrapperHelper does not implement XAccessibleContext 
...but rather some (non-virtual) base functionality for use in derived classes
(that do implement XAccessibleContext)

Change-Id: Idb0023906108db22bb9696245f07b9a4c053a0d1
 2014-03-14 14:29:24 +01:00
Stephan Bergmann
9b7f17dd30 Fix races in AsyncEventNotifier::execute 
* m_aDeadProcessors was useless; for one, removeEventsForProcessor could never
  have run (and set m_aDeadProcessors) between execute's reading from aEvents
  and checking m_aDeadProcessors (because of the use of aMutex in both
  functions), and if that were addressed, there would always be a race that
  execute would run a processor that has just been removed.  Clients have to be
  aware that a call to removeEventsForProcessor is just an optimization hint,
  but does not guarantee that the given processor is not called from the execute
  thread after removeEventsForProcessor returns.

* The sequence

    aGuard.clear(); aPendingActions.reset(); aPanedingActions.wait();

  could cause calls to aPendingActions.set() to get lost, both for signalling
  new content in the queue and for signalling termination.

Change-Id: I43293e3d5090c2d46db8bc8ed6fb9c71e049d55c
 2014-03-14 12:20:42 +01:00
Stephan Bergmann
61c44a9929 comphelper::OIHWrapNoFilterDialog does not implement XInitialization 
Change-Id: Idce153607c3deb3f0a1809b9d18cbcc6f30cf04d
 2014-03-13 12:50:12 +01:00
Stephan Bergmann
e3e1f9f30d Leftover SAL_CALL 
Change-Id: I895b2132ee752f191f30d6adc0af35cad005afe5
 2014-03-11 14:54:30 +01:00
Stephan Bergmann
7211162081 Clean up uses of rtl_ustr_ascii_shortenedCompareIgnoreAsciiCase_WithLength 
Change-Id: Ie37614dac882bfe05f8ce595ae6b20326dce872e
 2014-03-01 19:28:14 +01:00
Caolán McNamara
ec9e5a0f5d coverity#1187647 try and help coverity out here 
Change-Id: I94a0dad8113b8b6ac06ddf5456ff8c35d7c64fc1
 2014-02-27 12:58:51 +00:00
Caolán McNamara
697ec96e61 coverity#1187646 unused mpAbort 
Change-Id: I1fc3f0253c2af4779ba59b5b85ea7fc400226177
 2014-02-27 12:58:50 +00:00
Alexander Wilms
a67c2a12bc Remove visual noise from comphelper 
Change-Id: I7e5512b43240beee05404cff9d49a87d0217ea89
Reviewed-on: https://gerrit.libreoffice.org/8242
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-27 06:42:45 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Caolán McNamara
6fbe00f9b6 coverity#983702 Uncaught exception 
Change-Id: I3a0b4c8fe4208d0945860f6b4e1b31852aef8502
 2014-02-25 16:12:23 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
d12e472474 comphelper: sal_Bool -> bool sequel 
Change-Id: I2b9bd19abf4510fccef0374a539069cb8222ccae
 2014-02-19 14:31:09 +01:00
Stephan Bergmann
05f742d28b comphelper: sal_Bool -> bool 
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
 2014-02-17 17:55:19 +01:00
Stephan Bergmann
faced6b5f7 ucbhelper: sal_Bool -> bool 
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
 2014-02-17 17:55:18 +01:00
Caolán McNamara
3ec9bccaab silence coverity#1027865 Out-of-bounds access 
and coverity#1027864

Change-Id: Ic3d1b91ef77ab3510c7428b7135dd9f249d56b4b
 2014-02-07 09:03:48 +00:00
Stephan Bergmann
9e77c2fb7c Remove UNOIDL "array" and "union" vaporware remnants 
...and deprecate what cannot be removed for compatibility.

Change-Id: I1ea335af775b867b468b8285113631167729a92a
 2014-01-31 10:15:47 +01:00
Caolán McNamara
7cc3e9ca0c coverity#706277 Uncaught exception 
Change-Id: I1941e0a3a662faaac1fb9374437f3984b3a5c6d8
 2014-01-27 17:03:04 +00:00
Norbert Thiebaud
8df4ce0ebe coverity#1130481 : Uninitialized scalar field 
Change-Id: I41025a3dfe16af9417b1ae8c7668c76cb501c7b9
 2014-01-26 22:40:27 -06:00
Stephan Bergmann
930202b0b2 Maybe this bool clean-up avoids false -Werror=maybe-uninitialized on Android 
Change-Id: Iab12cc703d190e79650f73c646a2fbb60c6685c5
 2014-01-22 15:03:23 +01:00
Eike Rathke
db6f8f9f89 fdo#73549 do not resolve empty locale here if not determined yet 
Change-Id: Iad03d6209a2b4024b27c6195195e5aa557c295fe
 2014-01-19 15:04:08 +01:00
Noel Grandin
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls 
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
 2014-01-07 09:43:37 +02:00
Stephan Bergmann
962d4b35bd css.logging.SimpleLogRing.create() calls initialize w/ empty Arguments 
Change-Id: Iffcab3831b40ce309aa20fdb825328ebb4dd1064
 2013-12-19 20:52:25 +01:00
Stephan Bergmann
83e191e25d Do not use C++-UNO internal static_type functions in client code 
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
 2013-12-12 11:10:10 +01:00
Caolán McNamara
108eee306e Related: rhbz#1040291 Change language name from 'Oriya' to 'Odia' 
Except for our external api where the Oriya is stuck (and similar for
the vba implementation)

Change-Id: I8288c930567385eea49a4c303727b13ef8b8a89f
 2013-12-11 15:11:18 +00:00
Noel Grandin
6eac9deadd remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsL 
Convert code like this:
    if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aStr == "rem")
which compiles down to the same code.

Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
 2013-11-21 13:29:29 +02:00
Noel Grandin
d454834895 Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls" 
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.

I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
 2013-11-20 16:38:28 +02:00
Noel Grandin
acebbee971 remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls 
Convert code like:
    if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aByteStr.startsWith("rem"))

Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
 2013-11-20 13:56:08 +02:00
Stephan Bergmann
24cad6a649 Move MediaDescriptor from comphelper to unotools 
...so it will be able to use SvtSecurityOptions internally.

Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
 2013-11-14 11:13:24 +01:00
Stephan Bergmann
8061c8c70b Make requestAndVerifyDocPassword var with MediaDescriptor a mem fn of latter 
Change-Id: I645d554c7ce592d93ca0696fa7e6068ce40c9058
 2013-11-14 11:13:23 +01:00
Marcos Paulo de Souza
bcb51cff22 fdo#63020: Replace ::comphelper::stl_begin()... 
And use some templates inside include/com/sun/star/uno/Sequence.hxx

Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47
Reviewed-on: https://gerrit.libreoffice.org/6599
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-11-07 10:43:34 -06:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Stephan Bergmann
a2f9c446b7 Some clean-up 
Change-Id: I8ef80b7ae952428a62cc1cea8b03219b77a83e99
 2013-10-28 13:48:14 +01:00
Stephan Bergmann
176ac1e616 Remove unnecessary SyntaxHighlighter::Tokenizer statefulness 
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it.

Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
 2013-10-28 13:48:14 +01:00
Stephan Bergmann
c99267b326 Fold SyntaxHighlighter::initialize into ctor 
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused.

Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
 2013-10-28 13:48:14 +01:00
Stephan Bergmann
6aa24e7565 Move implementation details to syntaxhighlight.cxx 
(and clean up a little)

Change-Id: I6e660708d8ca1509b89b306cd428dc38c8b03f2c
 2013-10-28 13:48:14 +01:00
Stephan Bergmann
f5e8be8bb1 Remove unused SimpleTokenizer_Impl::nLine/nCol 
...which are never read; remove thereby unused parameters from functions.

Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
 2013-10-28 13:48:13 +01:00
Stephan Bergmann
0827aba84e Correctly fix "Terminating NUL" fix 
1cbe2313edda8a04f0fe233b4a29ef4e2485f557 "Terminating NUL at end of its buffer
is not considered part of OUString" was a thinko that cut the last character off
the last reported HighlightPortion on a line.

Change-Id: Idbe74676e85749cd93854293c6f49c7581414562
 2013-10-28 10:47:19 +01:00
Stephan Bergmann
a699e7c70d Revert "COMPHELPER: Allow empty comments in SyntaxHighlight" 
This reverts commit a79cb836b951eb2492e43aadd2ee672b9b67b914, which broke
--with-help builds again, as

  strLine.copy(i->nBegin, i->nEnd-i->nBegin)

in BasicCodeTagger::tagParagraph (helpcompiler/source/BasCodeTagger.cxx) depends
on the invariant that a HighlightPortion does not extend past the source string.

Also, I see no reason for that change, as empty comments are handled just fine
already as demonstrated by the following commit...

Change-Id: I384bae9c4cf6a38d0a0a2832fa15bde82126cace
 2013-10-28 10:47:19 +01:00
Arnaud Versini
a79cb836b9 COMPHELPER: Allow empty comments in SyntaxHighlight 
Change-Id: I0f3d5673e28e34ed3921c930aca48f3d7574b064
Reviewed-on: https://gerrit.libreoffice.org/6450
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2013-10-27 16:07:16 +00:00
Marcos Paulo de Souza
196f980012 fdo#54938: Replace existsValue for cppu::supportsService 
As now ::comphelper::existsValue is not used anymore, we're removing this too.

Change-Id: I9bd2544a9c378f5a18746255133f5684867e0114
Reviewed-on: https://gerrit.libreoffice.org/6378
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-23 14:58:17 +00:00