Commit Graph

2561 Commits

Author SHA1 Message Date
728ec86062 Typo: s/cant/can't/
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-18 00:30:35 +03:00
fee4efcb54 dbaccess: sal_Bool->bool
Change-Id: Ieb52470f9638b74898954db3890aaf2cf202290a
2014-04-17 11:17:21 +02:00
e616c346d4 WaE: Unreferenced function definition [loplugin:unreffun]
Work around a slight confusion in the Clang plugin when used with Clang
3.2. Put these 'extern "C"' function definitions consistenly outside
namespaces, as they are declared in the header.

Change-Id: Iccee41dfe0776f382e677b109009a95fb806a12c
2014-04-16 09:54:12 +03:00
fa0ffdbeb5 cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused
...since f059134fab0f91b7a15594ad06536a13fbfae034 "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).

Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
2014-04-15 07:46:43 +02:00
75f5d9d214 typo: postion -> position 2014-04-14 12:32:40 +02:00
aea96244d1 Missing includes
Change-Id: I08750fdaab137665205a6e55891d845b39b0147d
2014-04-14 10:54:34 +02:00
ae59446aab Clean up function declarations and some unused functions
Change-Id: Ie4f6197e42db298b4a3dcb6befdbd72dff6ea2b7
2014-04-13 22:40:55 +02:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
8728c34662 connectivity: sal_Bool->bool
Change-Id: Iafa52d3643b9313c20c75cf98f6b1ec231bf9d6d
2014-04-01 07:38:09 +02:00
73c1ac010c connectivity: sal_Bool->bool
Change-Id: Ia45f9776e0b27720647c664541a41b5f46eedc37
2014-04-01 07:38:09 +02:00
3194d22a24 connectivity: sal_Bool->bool and fix method name
Convert method name
  getBoleanComparisonPredicate
to
  getBooleanComparisonPredicate

Change-Id: I00c726b1fecd8352dc49f2af98c3ae3c799ef424
2014-04-01 07:38:08 +02:00
ddb07081da xmloff: sal_Bool->bool
Change-Id: I1deb10cb1581137ab92e73367e63339822a9a094
2014-03-31 12:36:54 +02:00
a7458fba26 Work around MSC "'override' cannot be used with 'inline'" bug
Change-Id: I4aeccc3957048a40e705654bf6b9972cc03648b6
2014-03-27 19:12:24 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
6df6fefed8 coverity#738610 unused member pointer value
Change-Id: I157c3bb7323767a27ac8a11361e6013bfee1de15
2014-03-22 20:20:37 +00:00
5d456dc5c6 dbaccess: prefer passing OUString by reference
Change-Id: I7cec02a40db48ce3d3003b3808d06ff0455a6eb4
2014-03-17 13:30:52 +02:00
8967b65be8 coverity#1000861 Uninitialized pointer field
Change-Id: I343ae6fde04e2ad937499909f5b5da221d1d12d5
2014-03-15 20:55:51 +00:00
98666e8625 No need for a virtual OPropertyContainer::getTypes
(and rename to getBaseTypes for clarity)

Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
0085bd2866 Model IEventProcessor acquire/release exactly after XInterface
...so classes deriving from both can easily share a single implementation for
these functions.

Change-Id: I6882dddc8b3ea3b0192d85102a0305494d964dc1
2014-03-14 12:20:41 +01:00
5fe7ecc04f sfx2: sal_Bool->bool
Change-Id: I56a50ee4a169c8f82c830ebf498f7ead1335f0b5
2014-03-14 07:50:34 +02:00
358be80f65 comphelper,connectivity: prefer passing OUString by reference
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
cfedbdea58 Remove newly unused getUnoTunnelImplementationId functions
...after recent clean-up of getImplementationId implementations.

Change-Id: I2a11f6ddf03dc7852b7e8e50dc6284a7215a0113
2014-03-11 13:03:20 +01:00
2f3be98732 dbaccess: simplify deprecated XTypeProvider.getImplementationId
Required some clean-up of getImplementationId vs. getUnoTunnelImplementationId
confusion.

Change-Id: I645dd80d24efe7ed5224b220911eed8ad880b7c0
2014-03-10 17:39:54 +01:00
3aaaab3db7 Remove unused OQueryComposer::getSomething
(OQueryComposer does not actually derive from XUnoTunnel.)

Change-Id: Ib0d358db2b6a87caae9bbc893dffb25e86109b85
2014-03-10 17:39:54 +01:00
74f0596ea0 Remove unused OSingleSelectQueryComposer::getSomething
(OSingleSelectQueryComposer does not actually derive from XUnoTunnel.)

Change-Id: I4eb26f5d217016e09d1e7e6a4b4bc10fcc5159e6
2014-03-10 17:39:53 +01:00
9661d5b164 Remove unused #include <comphelper/basicio.hxx>
Change-Id: I710d430342de0f1bfb98227264df3a44283f8dc2
2014-02-28 10:43:43 +01:00
2a33953f6e Remove visual noise from dbaccess
Change-Id: I1130439e5883672b4ca462838d72197acd6bc1f2
Reviewed-on: https://gerrit.libreoffice.org/8251
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:44:14 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
b7259532d8 Remove unnecessary bool2any
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
ad73967e99 Remove unnecessary extractInterface
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
3b06e5e646 Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I1ebfb33063d39f64dc59623df0f942501870c4e7
2014-02-22 21:51:27 +09:00
2ff57a77d8 coverity#738611 Uninitialized scalar field
Change-Id: Ib80c34fa3f6e6cbfc14cc4fa97afec24228c382d
2014-02-21 12:40:31 +00:00
b9179d8798 coverity#738612 Uninitialized scalar field
Change-Id: I6d2ffdfe3a4e70c6588988be9026e28411ee273a
2014-02-21 12:40:30 +00:00
d449366679 cid#707728 Uninitialized pointer field
Change-Id: I95528f444113ce7e70afe040b6c3e95966a561a2
2014-02-21 11:59:06 +02:00
e0e370a13d cid#707727 Uninitialized pointer field
resolved by removing the field, since it is unused

Change-Id: Ia543877ee645023bf6e1ee3c4f396cb082517f82
2014-02-21 11:59:06 +02:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
c92753e395 Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: Iafdebacd43ed24a30fb8e2d041fe975a1adbcfa0
2014-02-20 11:25:30 +09:00
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
faced6b5f7 ucbhelper: sal_Bool -> bool
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-02-17 17:55:18 +01:00
d39178ff6c Drop unused #include
Change-Id: Id1badf4ae68d322a6e05e900aa63bdb124387bab
2014-02-17 11:26:31 +09:00
c2b50457ef coverity#707725 : Uninitialized scalar field
Change-Id: Ia5ebaca5bbb35946250854abf78ab9ab2041757f
2014-02-01 15:29:58 -06:00
ce445c50d6 merge property map for import and export
why would they ever need to be different?
There was maybe/probably a bug lurking behind their being different.

Change-Id: I5db7f1596aec0d2a504ec7901c001054fd7fd121
2014-01-30 14:38:01 +01:00
9cc60839f3 bool improvements
Change-Id: I294b930214ce82033402afecf2b3eb2d04299505
2014-01-28 20:26:29 +01:00
d786af6820 coverity#705141 Missing break in switch
Change-Id: I9b94f1056fa62b2c0c609f6d448e1750bb0e9ce5
2014-01-28 15:19:33 +00:00
eab105e943 coverity#705140 Missing break in switch
Change-Id: I1b08e9afda2eeb3c4c79154376f34cad3e1f0a4c
2014-01-28 14:30:44 +00:00
5b2ba8ed5d DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Conflicts:
	dbaccess/source/ui/dlg/tablespage.cxx

Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21 16:20:10 +00:00
62951cdd17 Introduce com.sun.star.frame.theGlobalEventBroadcaster singleton
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance
service.

Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-16 18:40:05 +01:00
f60b61b2cf dbaccess: ODF export: set "Version" property on target Storage
... like SfxObjectShell::SetupStorage() does, and not on the property
set that is passed to the XML export filters where it probably does
nothing.

Change-Id: I21da1b92fc921eb47e492169e69ef15ac2f0e19d
2014-01-10 18:07:14 +01:00