728ec86062
Typo: s/cant/can't/
...
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-18 00:30:35 +03:00
fee4efcb54
dbaccess: sal_Bool->bool
...
Change-Id: Ieb52470f9638b74898954db3890aaf2cf202290a
2014-04-17 11:17:21 +02:00
75f5d9d214
typo: postion -> position
2014-04-14 12:32:40 +02:00
aea96244d1
Missing includes
...
Change-Id: I08750fdaab137665205a6e55891d845b39b0147d
2014-04-14 10:54:34 +02:00
6835d9f307
It's "its", not "it's"
...
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
8728c34662
connectivity: sal_Bool->bool
...
Change-Id: Iafa52d3643b9313c20c75cf98f6b1ec231bf9d6d
2014-04-01 07:38:09 +02:00
73c1ac010c
connectivity: sal_Bool->bool
...
Change-Id: Ia45f9776e0b27720647c664541a41b5f46eedc37
2014-04-01 07:38:09 +02:00
3194d22a24
connectivity: sal_Bool->bool and fix method name
...
Convert method name
getBoleanComparisonPredicate
to
getBooleanComparisonPredicate
Change-Id: I00c726b1fecd8352dc49f2af98c3ae3c799ef424
2014-04-01 07:38:08 +02:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
6df6fefed8
coverity#738610 unused member pointer value
...
Change-Id: I157c3bb7323767a27ac8a11361e6013bfee1de15
2014-03-22 20:20:37 +00:00
5d456dc5c6
dbaccess: prefer passing OUString by reference
...
Change-Id: I7cec02a40db48ce3d3003b3808d06ff0455a6eb4
2014-03-17 13:30:52 +02:00
8967b65be8
coverity#1000861 Uninitialized pointer field
...
Change-Id: I343ae6fde04e2ad937499909f5b5da221d1d12d5
2014-03-15 20:55:51 +00:00
98666e8625
No need for a virtual OPropertyContainer::getTypes
...
(and rename to getBaseTypes for clarity)
Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
358be80f65
comphelper,connectivity: prefer passing OUString by reference
...
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
cfedbdea58
Remove newly unused getUnoTunnelImplementationId functions
...
...after recent clean-up of getImplementationId implementations.
Change-Id: I2a11f6ddf03dc7852b7e8e50dc6284a7215a0113
2014-03-11 13:03:20 +01:00
2f3be98732
dbaccess: simplify deprecated XTypeProvider.getImplementationId
...
Required some clean-up of getImplementationId vs. getUnoTunnelImplementationId
confusion.
Change-Id: I645dd80d24efe7ed5224b220911eed8ad880b7c0
2014-03-10 17:39:54 +01:00
3aaaab3db7
Remove unused OQueryComposer::getSomething
...
(OQueryComposer does not actually derive from XUnoTunnel.)
Change-Id: Ib0d358db2b6a87caae9bbc893dffb25e86109b85
2014-03-10 17:39:54 +01:00
74f0596ea0
Remove unused OSingleSelectQueryComposer::getSomething
...
(OSingleSelectQueryComposer does not actually derive from XUnoTunnel.)
Change-Id: I4eb26f5d217016e09d1e7e6a4b4bc10fcc5159e6
2014-03-10 17:39:53 +01:00
9661d5b164
Remove unused #include <comphelper/basicio.hxx>
...
Change-Id: I710d430342de0f1bfb98227264df3a44283f8dc2
2014-02-28 10:43:43 +01:00
2a33953f6e
Remove visual noise from dbaccess
...
Change-Id: I1130439e5883672b4ca462838d72197acd6bc1f2
Reviewed-on: https://gerrit.libreoffice.org/8251
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 06:44:14 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
ad73967e99
Remove unnecessary extractInterface
...
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
2ff57a77d8
coverity#738611 Uninitialized scalar field
...
Change-Id: Ib80c34fa3f6e6cbfc14cc4fa97afec24228c382d
2014-02-21 12:40:31 +00:00
b9179d8798
coverity#738612 Uninitialized scalar field
...
Change-Id: I6d2ffdfe3a4e70c6588988be9026e28411ee273a
2014-02-21 12:40:30 +00:00
e0e370a13d
cid#707727 Uninitialized pointer field
...
resolved by removing the field, since it is unused
Change-Id: Ia543877ee645023bf6e1ee3c4f396cb082517f82
2014-02-21 11:59:06 +02:00
c92753e395
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: Iafdebacd43ed24a30fb8e2d041fe975a1adbcfa0
2014-02-20 11:25:30 +09:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
c2b50457ef
coverity#707725 : Uninitialized scalar field
...
Change-Id: Ia5ebaca5bbb35946250854abf78ab9ab2041757f
2014-02-01 15:29:58 -06:00
9cc60839f3
bool improvements
...
Change-Id: I294b930214ce82033402afecf2b3eb2d04299505
2014-01-28 20:26:29 +01:00
d786af6820
coverity#705141 Missing break in switch
...
Change-Id: I9b94f1056fa62b2c0c609f6d448e1750bb0e9ce5
2014-01-28 15:19:33 +00:00
eab105e943
coverity#705140 Missing break in switch
...
Change-Id: I1b08e9afda2eeb3c4c79154376f34cad3e1f0a4c
2014-01-28 14:30:44 +00:00
5b2ba8ed5d
DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Conflicts:
dbaccess/source/ui/dlg/tablespage.cxx
Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-21 16:20:10 +00:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
2ac31b06ae
Unnecessary use of OUString constructor inside OUStringBuffer constructor
...
Convert code like:
OUStringBuffer sVal(OUString("0x"));
to:
OUStringBuffer sVal("0x");
Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
2013-12-17 11:49:05 +02:00
2042665c6d
fdo#72696 set parameters when they have changed
...
Change-Id: Id470f98456200ed51418e31904e8a9a457fda638
2013-12-16 04:17:33 +01:00
dd0990db74
fdo#72463 RowSet: on execute when not dirty, rebuild cache
...
Change-Id: I3f27b7572b88cd1200483121614c29d414c37e20
2013-12-12 20:19:06 +01:00
afd32065b6
fdo#54938: Convert dbaccess to use cppu::supportsService
...
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
Conflicts:
dbaccess/source/core/dataaccess/connection.hxx
Change-Id: Id7602b969790b13538868b937842bc945ce3e31e
2013-12-10 08:33:25 +01:00
c5b7a5fd19
fix equalsAscii conversion. Noticed in fdo#72391
...
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.
Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
2013-12-09 12:53:18 +02:00
b0926378ac
Clean up includes of comphelper/stl_types.hxx
...
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06 17:56:11 +01:00
f51877b147
Combine comphelper::UStringMixEqual, comphelper::TStringMixEqualFunctor
...
Change-Id: I3ab3777a65fd68f8cbaf17a8e2a989dc4ad7b1cc
2013-12-06 14:28:37 +01:00
1a715d4d67
Get rid of DECLARE_STL_STDKEY_MAP
...
Change-Id: I099f94922acba0bf9cde22fbbb3eefc230776868
2013-12-06 10:37:50 +01:00
4a8175ebeb
Get rid of DECLARE_STL_USTRINGACCESS_MAP
...
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
56d4f4b7b9
fdo#70144 Don't reset Document's modified flag when inserting new table.
...
It is unclear why the modified flag should ever be blindly overwritten hence
we no longer touch the modified flag here. (This change appears to have no
undesired side-effects.)
Change-Id: I246eb7d84249794fa4d52fcd9b008d8340bbc82d
Reviewed-on: https://gerrit.libreoffice.org/6632
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2013-12-04 07:53:35 -06:00
56cdaa1869
fdo#72163 belts and suspenders
...
1) Do not dispose m_xComposer, might still be used by our m_pCache
2) Do not create a new m_xComposer if the previous one will do, so
that we do not gratiously use a different one than our m_pCache.
Change-Id: I6540c035c9159017c694b36e676721ec3e42db51
2013-12-02 23:57:16 +01:00
d4b7e3d12a
fdo#72163 after updating m_xComposer, command facets are not dirty anymore
...
Else we dispose m_xComposer too eagerly; still used by m_pCacheSet.
Change-Id: I205488465c19a356534df17b8a5e9a20ce6766c9
2013-12-02 23:57:15 +01:00
071c3f3e93
remove unnecessary use of OUString constructor in equalsIgnoreAsciiCase
...
Convert code like:
sType.equalsIgnoreAsciiCase(OUString("VIEW"));
to:
sType.equalsIgnoreAsciiCase("VIEW");
Change-Id: I6fb47e6a83b561c7e5a25da76b63606a3174858d
2013-11-22 08:07:18 +02:00
363cc39717
convert equalsAsciiL calls to startWith calls where possible
...
Simplify code like:
aStr.equalsAsciiL( "%", 1 )
to
aStr.startsWith( "%" )
Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19 12:49:29 +02:00
