Commit Graph

1515 Commits

Author SHA1 Message Date
a30fc66dd2 remove unused hrc files
Change-Id: I7ce04c206250db40076bed699bee892bdfbf19b6
2014-04-22 13:03:19 +02:00
f400bdce03 fixincludeguards.sh: extensions
Change-Id: If652bce4cf7621795b084bcbc0aa4c46dd903878
2014-04-19 11:10:10 +02:00
cf4f433dfb coverity#706522 Uncaught exception
Change-Id: If5638fa4c35a642791088f8ecda7dd0c13ac5a81
2014-04-17 21:13:51 +01:00
a6611be6bc Clean up function declarations and some unused functions
Change-Id: Ie81d270267b6c3c3620ade62eb393b28d995a654
2014-04-13 23:44:29 +02:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
de31f85d6c coverity#706530 Uncaught exception
Change-Id: Ic975df93535b47dfcf39b9e58e7e9728adce082b
2014-04-05 20:34:35 +01:00
eb97362a42 coverity#706518 Uncaught exception
Change-Id: I2db2ba69d7aac319fa9b446766729813c09d344f
2014-04-05 20:34:35 +01:00
b7dcef0b45 coverity#706520 Uncaught exception
Change-Id: I80c4a2fdff5bb487bc40a37da45a62cde3eaa9da
2014-04-05 20:34:34 +01:00
73514d205b coverity#706521 Uncaught exception
Change-Id: Ibb5623097f910d011c388c9c8d429871b62bf613
2014-04-05 20:34:34 +01:00
f2810ae4a7 coverity#706523 Uncaught exception
Change-Id: I20515693bed76163433421f7fd05b319ed472a54
2014-04-05 20:34:33 +01:00
453ee351f3 fdo#43157 : clean up more OSL_POSTCOND
Change-Id: Iaca31b4e12c258b762b3d88fbad0fb08b4f1fc16
Reviewed-on: https://gerrit.libreoffice.org/8832
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-04 07:23:43 -05:00
7938279a0d /include/connectivity/dbtools.hxx: sal_Bool->bool
Change-Id: Ie1e1952e3d39d53756583482826dfc3b65b5f9e0
2014-04-04 13:44:18 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
8f7c677dbb Avoid possible resource leaks by boost::scoped_array
Change-Id: Ibf92b3098c50388d8b6d27f4476e613a1f8918b5
2014-04-02 16:09:11 +09:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
efe704cc59 Dead code
Change-Id: I05ecb627119eb545d1781fa42613e940fc22aac1
2014-03-28 15:27:38 +01:00
f7c8d7655f Work around MSC "'override' cannot be used with 'inline'" bug
Change-Id: I6eeb47699193ee024e975915011b1c3c5483bf9e
2014-03-27 19:59:49 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
9604eb8758 svtools: sal_Bool->bool
Change-Id: I8f171f7f61ea06a79183e9bf9b15b8c35c98cc9b
2014-03-24 08:12:09 +02:00
51bef3b727 coverity#738626 Uninitialized pointer field
Change-Id: I8468009fafff845c249bddb88417a5ceeb556fb0
2014-03-22 20:36:28 +00:00
96710f8e46 convert OUString::match to OUString::endsWith
Convert code like:
    rTxt.match( "---", rTxt.getLength()-3 )
to:
   rTxt.endsWith( "---" )

Change-Id: Iada74c5e714f7234f25b326526843a36255d5599
2014-03-19 08:55:21 +02:00
b69dcab522 extensions: prefer passing OUString by reference
Change-Id: Ic411b2776d0c054d59bfdc847f67785c85c5cb9e
2014-03-17 13:30:53 +02:00
534425bfcd convert new data type dialog to .ui
Change-Id: Ia354e003903c20435947e82afa293a34a367773a
2014-03-13 20:48:49 +00:00
c7f1ce594c extensions: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I234d36bc7ef9e8e27087067f6e43d7e522e52d4d
2014-03-10 17:39:55 +01:00
25cedf1dc7 Introduce com.sun.star.beans.theIntrospection singleton
...deprecating com.sun.star.beans.Introspection (single-instance) service.

Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
2014-03-07 10:33:07 +01:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
b2371492df Use cstdlib std::abs instead of stdlib.h abs
...because the latter lacks the abs(long) overload in some popular environments,
cf. <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60401> "stdlib.h does not
provide abs(long) overload."

Similarly, stdlib.h lacks the abs(float), abs(double), abs(long double)
overloads compared to cmath there, whose use was apparently intended in
sw/qa/extras/ooxmlexport/ooxmlsdrexport.cxx.  Rewrote that to use
CPPUNIT_ASSERT_DOUBLES_EQUAL instead, which revealed that the comparisons need
rather large deltas of .1 resp. .2 (which the original code hid with an
implicit conversion to integral type, thus using an effective delta of 1).

Discovered with -Wabsolute-value ("absolute value function 'abs' given an
argument of type 'long' but has parameter of type 'int' which may cause
truncation of value") recently introduced on Clang trunk towards 3.5.

Change-Id: I4c41575ffdccb2944498b662bd3a53fd510cb0c0
2014-03-03 18:36:55 +01:00
ff71f4e55c EXTENSIONS : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Ied33afa8b32149b6b7b1c0725167349e817d6c89
Reviewed-on: https://gerrit.libreoffice.org/8407
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03 09:17:33 -06:00
0e39eba09b WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'
Change-Id: I6a15e3e705015fdfa92e0606935af8b83cc9a183
2014-02-28 13:27:01 +02:00
15246c959a Remove visual noise from extensions
Change-Id: I0397d0d0e5343b7ed192a790664b068ac6955bd3
Reviewed-on: https://gerrit.libreoffice.org/8259
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 07:34:29 -06:00
ccf0f7ef03 coverity#704633 Dereference after null check
Change-Id: I4985249110da93ba67881dcd1c8cd1dc66ae08e2
2014-02-27 12:57:25 +00:00
c521f07208 editeng: sal_Bool->bool
Change-Id: I7da10ad3ba8017d64c723b53795348edf0e7dd6d
2014-02-27 12:30:30 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
b7259532d8 Remove unnecessary bool2any
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
e4d8872d07 coverity#704631 Dereference after null check
Change-Id: Id74b7073b6e9075003a98172e85696274a8c1924
2014-02-23 14:22:42 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
32ef676504 editeng: sal_Bool->bool
Change-Id: I1b215ef78bcade675a2f80def0d6d5afe0ff3d2c
2014-02-21 12:19:23 +02:00
5f17e5eaad Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-21 14:35:52 +09:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
d548b250db Drop unnecessary #include
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
2014-02-18 13:24:11 +09:00
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
1f22e2f954 coverity#735424 Logically dead code
Change-Id: Ibd58c1660edca27141c27f7607f426f9df8d6b79
2014-02-11 20:21:49 +00:00
5ead05c352 Typo: pasword -> password
Change-Id: I612bf6bb620a76f9fa3542145e942969b9365d98
2014-02-06 21:49:21 +01:00
eb07ab05c3 coverity#707771 coverity gold, Uninitialized m_refCount
Change-Id: I98398a3cd7a86a5f31c711f7f1cff0d467a1d2e5
2014-02-06 15:11:59 +00:00
9e77c2fb7c Remove UNOIDL "array" and "union" vaporware remnants
...and deprecate what cannot be removed for compatibility.

Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-31 10:15:47 +01:00
a29cdd540c bool improvements
Change-Id: If3402725c9cbff5df45043bd2ecd22dd6241c052
2014-01-28 20:26:28 +01:00
40a8fecb58 coverity#705811 Dereference before null check
Change-Id: I275739819715f1537e80d621b19a88a6fdbab95b
2014-01-28 14:30:42 +00:00