Commit Graph

665 Commits

Author SHA1 Message Date
60db3dae6c Use already found result
Change-Id: Ifafba6f4f93b357239ddadd5ca16ac62bd6e289b
2014-04-22 15:18:57 +02:00
ab9813eaea Don't litter pCustomShapeTypeTranslationHashMap with dangling keys
...that are char* into temporary OString at the GetOOXMLPresetGeometry call site
in oox/source/export/shapes.cxx.

Change-Id: Ifd6533f9bd869b740a6b483f4a1f6e4860007b9c
2014-04-22 15:09:48 +02:00
d83dfeb5e5 filter: sal_Bool->bool
Change-Id: Icf20f23cb46ad3cb147d8c6a743f1d25a23fbca5
2014-04-22 09:56:06 +02:00
1139d618b8 handle strange brightness+contrast adjustment from msoffice (fdo#38410)
LO uses basically the formula "newpixel=(oldpixel-128)*contrast+128+brightness",
i.e. contrast is applied first. It looks like there's no "oficial" formula for this,
so a formula that applies brightness first would be ok too. MSO for some weird reason
apparently uses a formula that applies half of brightness before contrast and
half afterwards (insert funny political correctness or compromise joke here).
While the result is the same like with the LO formula if only either brightness
or contrast is adjusted, the result is different if both are involved. Just modify
the image using the MSO algorithm if this is the case.

Change-Id: I55fe8f395832685b90f024cf2f58b0797c1ba588
2014-04-18 20:53:01 +02:00
b827f6f81f Related: #i124661# crash when loading and re-saving ppt file...
with a single customshape

check the equation array element number. If the number is greater than 128, the
equation array will not be imported.

(cherry picked from commit 48653aa3a1cc24ed9ad8a14ae035b38a751e561d)

Conflicts:
	filter/source/msfilter/msdffimp.cxx

Change-Id: I49ac6ec5610a7761ca3ed4905d6fe1bc7ec079d0
2014-04-16 11:58:06 +01:00
893590f16e The entry points for these are hidden behind OSL_DEBUG_LEVEL > 1 too.
Change-Id: I728e808ac897aa1be184fb4a8bbbf781eb816cf0
2014-04-14 15:46:22 +02:00
d47e763eab typo: simpe -> simple 2014-04-14 12:32:22 +02:00
2ada2b3375 typo: dependend -> dependent 2014-04-14 12:31:58 +02:00
60c8df4326 remove static strings 2014-04-14 12:31:55 +02:00
792437f1f4 USED is never defined 2014-04-14 12:31:45 +02:00
52494aad92 Clean up function declarations and some unused functions
Change-Id: I68b488d45c77ebf82029bfede98dca2400e02f2f
2014-04-14 12:25:30 +02:00
af51f3fb5a handle .doc cropping also inside groups (fdo#38411)
Writer does handle cropping on its own, but only for "toplevel" images,
not for those inside groups, so there still use the generic code.

Change-Id: I805a4cbd2d4cea7008e0322688ccd7f35a6d4a2c
2014-04-13 23:09:00 +02:00
eacfa63670 coverity#707839 Uninitialized scalar field
Change-Id: Ib9cf1d3da0cf03b6aa0aaa7b5206803730115cc8
2014-04-11 21:16:23 +01:00
dfc39fcdbf coverity#707837 Uninitialized scalar field
Change-Id: Icce1d2cd9abfebcf26e916c4c79341b617e97b2e
2014-04-11 20:49:57 +01:00
4e939b9599 Avoid possible memory leaks in case of exceptions
Change-Id: I4f1e00dd275976cdba8490f35ccbb491914829b7
2014-04-12 01:34:45 +09:00
af2a70abc0 Resolves: #i124661# secure possible out of bound access to vector
(cherry picked from commit c9cdd9751d45b5b8b0288e9dc477e6d272ba0a0d)

Change-Id: I1c0637029fd7b4ab493956538c6e9fdf33307cbe
2014-04-11 17:26:41 +01:00
896cacf059 Avoid possible memory leaks in case of exceptions
Change-Id: I43cce6b6c41582a65ff7e59de9a107b30cf8b1e8
2014-04-11 09:55:01 +09:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
22f7c87dbd Avoid possible memory leaks in case of exceptions
Change-Id: I288c77190a8205ba320bb788a52f3b2ef9d2557f
2014-04-09 16:36:19 +09:00
abc429987c filter/msfilter: sal_Bool->bool
Change-Id: I24deda680469ce99ba358a68e83551bdb584751a
2014-04-03 09:17:52 +02:00
7a120ad4ac few more type fixes
Change-Id: I6b953a6792c8c72c29dc0e7b25bdae41da50ca6d
2014-03-29 12:52:52 +01:00
62175dfc7e Resolves: i124477 set object shadow always at PPT import...
it may be applied to object text

(cherry picked from commit 5fb2c24bd0cfc0b911aa2d0389960c5ee3d14c4a)

Conflicts:
	filter/source/msfilter/msdffimp.cxx

Change-Id: I8b93ff85333078d3e79cc9aa1002f232214a5be1
2014-03-28 12:38:33 +00:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
6137b5f72f coverity#735432 Logically dead code
Change-Id: I6bbbe539d28aefcad04ccae48f2518e78f15b240
2014-03-25 12:33:21 +00:00
554e54429c svtools: sal_Bool->bool
Change-Id: Ic9b4838c4d1b4d2d2ea4665811dd396bdbec31b7
2014-03-24 08:12:09 +02:00
96710f8e46 convert OUString::match to OUString::endsWith
Convert code like:
    rTxt.match( "---", rTxt.getLength()-3 )
to:
   rTxt.endsWith( "---" )

Change-Id: Iada74c5e714f7234f25b326526843a36255d5599
2014-03-19 08:55:21 +02:00
d593f45886 filter,formula: prefer passing OUString by reference
Change-Id: I332f1a593853283b72ecf4dfd82b36cc091661b4
2014-03-17 09:00:07 +02:00
13bc4094da svx: sal_Bool->bool
Change-Id: I673d022c01b7d076120c026b236a37735b5043b0
2014-03-14 07:50:32 +02:00
6c97bc4717 svx: sal_Bool->bool
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-11 08:18:24 +02:00
d1bffe3596 svx: sal_Bool->bool
Change-Id: I64d9c1bbe6ed85108783bf6a97329fcdc167ca62
2014-03-11 08:18:24 +02:00
4b99d7ebe0 coverity#707856 Uninitialized scalar field
Change-Id: Ib57a4703dfb20aab3b5976fab0331b93e4983c05
2014-03-10 16:17:55 +00:00
bba56d9ec7 coverity#1103652 Unchecked return value
Change-Id: Ia05313ad580d09d1e2832a81829518f4692e18fd
2014-03-10 11:36:26 +00:00
f1529383d4 coverity#705649 Resource leak
Change-Id: I4899851af28b20a20c7b07301c22ddacdbb89b27
2014-03-09 21:20:12 +00:00
a1b78271c9 coverity#1190346 silence Unchecked return value
Change-Id: If6223276d2d45431a674047b9540d4ac3eb71395
2014-03-08 14:25:03 +00:00
cd5acc5fc2 coverity#735429 Dead default in switch
Change-Id: I18d497f1e8dc339bd1ac7154a5ca9bb59895c52e
2014-03-06 16:35:50 +00:00
1cbec9cd98 Resolves: #i119480# Fixed import of curves from PPT
Reported by: Du Jing
Patch by: SunYing
Review by: Andre Fischer

(cherry picked from commit 7d4fbffcf83ae6cbd01485320c2f21155c3dd4de)

Change-Id: I1ca3caf3aaec255ab204a4a687ed8434fbdb234a
2014-03-05 09:23:40 +00:00
7edf847bf7 coverity#704638 Dereference after null check
Change-Id: Ib5e8996d8eb9e487b1c961aa2137b859c887eb6a
2014-03-02 20:08:16 +00:00
af63727b9f Resolves: #i15508# Added support for BMP file type
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4)

Conflicts:
	filter/source/msfilter/escherex.cxx
	include/vcl/gfxlink.hxx
	svx/source/xml/xmlgrhlp.cxx
	sw/source/ui/docvw/romenu.cxx
	vcl/source/filter/graphicfilter.cxx

Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27 19:30:40 +00:00
aeaded675c Remove visual noise from filter
Change-Id: Ieab1d12204bcf917b2e1bf74f3145fc96d7b207c
Reviewed-on: https://gerrit.libreoffice.org/8261
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:10:36 -06:00
57779aa019 editeng: sal_Bool->bool
Change-Id: Id4174904487fc153d8e80471da7c829c52092f78
2014-02-27 12:30:26 +02:00
ef16d954c2 editeng: sal_Bool->bool
Change-Id: Ic3d9fe45d3242d3da147067d3c388e9d7305ee61
2014-02-27 12:30:25 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
2d3ed7ebb5 cid#736173 - increase default fill chars buffer size.
Change-Id: Ib7ae9b0a0cddd070372a244cf705f71b6e793473
2014-02-25 22:56:35 +00:00
b854cb787e coverity#735747 Dereference after null check
also

coverity#736774 Dereference before null check

Change-Id: Ic2e2a341565af0609ec748b40ac7848a46c9e3af
2014-02-24 12:53:09 +00:00
ad7fdc4e0f filter: Code reduction, prevents crash.
Not all shape types have the full com.sun.star. prefix, for example
FrameShape. The existing code would crash in that case, but the new
code doesn't.

Change-Id: I9aa3d0f20f48ab91a6770e8409a8da2028816504
2014-02-24 13:24:53 +01:00
ad73967e99 Remove unnecessary extractInterface
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
8a5ad76b4e Related: #i119985# date/time is displayed as different language
(cherry picked from commit 2a3c87a5ea5e3308a138e461dffae19483c0184c)

Change-Id: I3ef171481b206f7a9d356110d1b4a1559cd5e837
2014-02-23 21:01:19 +00:00
09c0e5110a coverity#704642 Dereference after null check
Change-Id: Iae9b7caf2076722a01e6882921622b193f2b4349
2014-02-23 14:22:43 +00:00
619b751f90 coverity#704641 Dereference after null check
Change-Id: Ib30bcefedb2685038f22e33b4c7a97b0295b224c
2014-02-23 14:22:43 +00:00
324f33cb44 coverity#704640 Dereference after null check
Change-Id: I05b932002ff8176d76f842dcd57ea39c4112f181
2014-02-23 14:22:43 +00:00