Commit Graph

248 Commits

Author SHA1 Message Date
1d057cca8c Clean up function declarations and some unused functions
Change-Id: I47bdc668ecf703d85f4d50c71f1347fb9e8e89d8
2014-04-14 12:46:57 +02:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
6ac0e1399a Remove silly PUT_SEMICOLON_AT_THE_END
...and rather live with macro calls not terminated by semicolons until those
macros are gone for good anyway.  Completely remove unused
DECLARE_UNO3_XCOMPONENT_DEFAULTS.

Change-Id: I0d4eb5a91736004b0da2b09fce860e57f6d1ddbd
2014-04-07 17:27:39 +02:00
6478730e12 Forgotten TODO
Change-Id: I4fb1c155c533445856639498e73c728933bb3dd7
2014-04-01 19:42:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
cc3a302fcb typo: unfortunally -> unfortunately 2014-03-29 19:16:20 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
2598a15ed2 forms: simplify deprecated XTypeProvider.getImplementationId
...and remove thus unused unotools/idhelper.hxx

Change-Id: I63affbcb0494ef91bc010b9dd5512d4cc718d7a2
2014-03-10 17:39:55 +01:00
bed18b128f Remove visual noise from forms
Conflicts:
	forms/source/component/DatabaseForm.cxx

Change-Id: I4005fe65e89794bd92191c37221c252a3e964917
Reviewed-on: https://gerrit.libreoffice.org/8262
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 14:54:56 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
d548b250db Drop unnecessary #include
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
2014-02-18 13:24:11 +09:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
e9c62a2d9c Get rid of unnecessary comphelper::UStringEqual
Change-Id: Ia8718e49f21ccec239b2769eafa6bef90e0e9e40
2013-12-06 14:28:36 +01:00
07ab0d43b5 Get rid of DECLARE_STL_VECTOR
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-12-06 08:04:23 +01:00
6aefcb6a6f forms: avoid deadlock when setting FontControlModel properties
Deadlock found in forms_unoapi on Windows, with
OGridControlModel::setFastPropertyValue_NoBroadcast() calling event
handler that tries to lock SolarMutex.

FontControlModel::setFastPropertyValue_NoBroadcast() and its callers in
3 other classes must not send events via firePropertyChange()
because they are called by OPropertySetHelper::setFastPropertyValues()
with its Mutex locked.

It is possible (though sadly quite convoluted) to delay the sending of
the events by calling setDependentFastPropertyValue() instead.

Change-Id: I0c767cfec01fe1bcaeb1236287b5faf81a2e7441
2013-11-27 17:20:31 +01:00
bdf7b2715e fixincludeguards.sh: forms
Change-Id: I634371fcd867f20e20384f75d613dab5f69a246c
2013-11-05 09:28:53 +01:00
74d631dfb3 Resolves: #i121045 After save a xls file contain marco in AOO, macor can't...
Reported by: binguo
Reviewed by: sunying
Patched by: Jianyuan Li

Change-Id: Ie728ce5185082334e3ce250d73e0660a6097f494
2013-06-11 14:10:01 +01:00
d209e13319 fdo#46808, Convert comphelper::ComponentContext in forms module
Change-Id: I8a9913d964633381f00c0a4885cc655805fa1974
2013-06-03 10:00:03 +02:00
746784e16f fdo#46808 Convert awt::Pointer to new style
Change-Id: Ic2ff491e656ab7bcf0bd5994b601818a26478243
2013-04-25 11:03:15 +02:00
1165aac95b fdo#46808, convert form::Forms to new style
Change-Id: I966ed18d45dc8a04c97a703d3c83382714025f2c
2013-04-23 16:05:56 +02:00
8ed6f1c2bf forms: FORMS_CONSTASCII_STRING is no longer needed
Change-Id: I2b666f0e48db4c97cc4c641480a82681f5057ac2
2013-04-23 11:58:32 +02:00
a2c54dc208 ListBox: take care of validation (use binding value when appropriate)
Change-Id: I7c2ab0e42a82baa39e1b48124cc8cf58bfa126d5
2013-04-22 17:55:55 +02:00
1a19d12487 janitorial: alignment
Change-Id: I1e061635d496c54a0c948805dac968f0fb0c67f8
2013-04-22 17:55:39 +02:00
a16bb08013 Data-aware ListBox: add SelectedValue and SelectedValues properties
Change-Id: Id081e4f6bb765056f17babcfec52a1aedcd7b5d5
2013-04-22 17:55:34 +02:00
d198e7a1eb janitorial: typo in comment
Change-Id: Icc10f98e4153278d3e5bde33d0454675121306a7
2013-04-22 17:51:31 +02:00
e8ff469da5 Remove any remaining remnants of unused component_canUnload feature
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19 16:52:03 +02:00
c32b6be06b fdo#60724 correct spelling
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
2013-04-15 05:32:37 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
c893d404c6 Revert "Remove RTL_CONSTASCII_(U)STRINGPARAM in forms(frm_strings.hxx)"
This reverts commit 6591068f2a73252f4e3c9abf9b153a5b4f59410b.

The second parameter of ConstAsciiString is length.
2013-04-01 22:48:35 +02:00
6591068f2a Remove RTL_CONSTASCII_(U)STRINGPARAM in forms(frm_strings.hxx)
Change-Id: Ic94187181b102b8d1623806027b857203c4b746f
2013-04-01 22:12:21 +02:00
0502d66d88 Remove RTL_CONSTASCII_(U)STRING in forms
Change-Id: I5086a8ba9073e8ef2dfde0ecae55ee6065cb0253
2013-04-01 22:12:20 +02:00
2d9ce9191d Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)
...which is a confusing overload with unexpectedly different semantics from the
one-parameter form.  In preparation of marking it as deprecated.

Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
2013-03-20 13:05:35 +01:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
3991eaf556 reduce whitespaces between include and filename
Change-Id: I15f6ad0a760a28cbac53f99ba4d14ff5c24ce005
2013-03-19 01:26:45 +01:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
773ad75b0d fdo#46808, Adapt util::NumberFormatsSupplier UNO service to new style
Change-Id: I58436d9eea0c38d14cde2dc01aa463d5d71912e9
2012-12-06 13:20:31 +02:00
0a063f3a36 re-base on ALv2 code. Includes:
Patch contributed by Christian Lippka
    impress212: #i113063# patch: dubios self assign in svx/source/dialog/framelink.cxx
    http://svn.apache.org/viewvc?view=revision&revision=1167619

    Patches contributed by Mathias Bauer
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117712#: fix several resource errors introduced by
    IAccessible2 implementation
    http://svn.apache.org/viewvc?view=revision&revision=1172343
    cws mba34issues01: #i117719#: use correct resource ID
    http://svn.apache.org/viewvc?view=revision&revision=1172351

    Patch contributed by Andre Fischer
    Do not add targets for junit tests when junit is disabled.
    http://svn.apache.org/viewvc?view=revision&revision=1241508

    Patches contributed by Armin Le-Grand
    #118804# corrected GraphicExporter behaviour on shortcut when pixel graphic is requested
    http://svn.apache.org/viewvc?view=revision&revision=1240195
    fix for #118525#: Using primitives for chart sub-geometry visualisation
    http://svn.apache.org/viewvc?view=revision&revision=1226879
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118524: apply patch, followup fixes to 118485
    http://svn.apache.org/viewvc?view=revision&revision=1186077 13f79535-47bb-0310-9956-ffa450edef68

    Patch contributed by Regina Henschel
    linecap: Reintegrating finished LineCap feature
    http://svn.apache.org/viewvc?view=revision&revision=1232507

    Patch contributed by Wang Lei (leiw)
    #i118760# split the first table cell vertically, then undo&redo,
    the Presentation app will crash
    http://svn.apache.org/viewvc?view=revision&revision=1301361

cleanup globlmn hacks, undo dependent fixmes.
2012-11-27 12:55:10 +00:00
4dc7b3b830 correct free slot count. 2012-11-27 12:55:09 +00:00
f4776bf465 fdo#46808, fix up some NumberFormatter createInstance calls I missed
Change-Id: Ieb3ce841243797a119f1d1d40379ff2a4614168f
2012-10-23 11:33:14 +02:00
1c7a54e3a1 fdo#46808, Adapt frame::ModuleManager UNO service to new style
Create a merged XModuleManager2 interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.

Explicitly document the XNameReplace interface in the IDL, which
is already implemented by the service, since there is code currently using it.

Change-Id: Ib46349174b1ce495c240031e93c9427fc33d9853
2012-09-05 14:56:19 +02:00
ed93117447 fdo#53061: Fix for C++11 #define NULL nullptr
Change-Id: Ia1805aab4bec7fef02c96ec4e7a7a0ed9991d3c3
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2012-08-14 10:39:13 +02:00
889de665ec Typo ressource -> resource
Change-Id: Id13e7acfbe34eca5e124c9032d36d6f158bfb831
2012-07-30 09:26:00 +02:00
64517292c9 hrc cleanup: Remove include guards
Also add some missing include guards.

Change-Id: I320a3c017ca65d34f2cd516849bcde3dec9b33f1
2012-07-02 22:42:09 +02:00
57154616f0 Remove UNO includes comments
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a
2012-06-29 09:25:09 +02:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
b6db3e3acc re-base on ALv2 code.
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-06-21 13:11:06 +01:00
5dcf536b69 merge the 5 ConstAsciiString duplicate classes together
a) merge them together and move it into comphelper
b) turn it into a POD rather than having vast amounts
of destructors registered into the cxa_atexit chain

Change-Id: I04d3b9d7804f8e233013c916df9d617a0f84f96a
2012-05-17 14:03:26 +01:00