Commit Graph

430 Commits

Author SHA1 Message Date
0882cc6675 fixincludeguards.sh: formula 2014-04-19 11:10:06 +02:00
eb4c43aa61 Avoid possible memory leaks in case of exceptions
Change-Id: Ie07c6c9989da444eb6052691696e95b808c23fb0
2014-04-15 16:12:31 +09:00
625c595fc3 fdo#76294: Intern strings in AddFormulaToken() as well.
And a whole bunch of changes needed to make that happen.

Change-Id: Idd98fbc99322c0d72fb0a7848d89cb1a6abc88b6
2014-04-14 18:34:20 -04:00
b09426b83c fdo#76294: Properly intern string literals in formula on xls import.
Change-Id: Ib3a442cbb68c23294762561f2911101a087a795e
2014-04-14 17:00:40 -04:00
712d2793ec Remove unused code
Change-Id: I1355317d6baeb180417cb5f1f34038925c1299cf
2014-04-14 12:49:20 +02:00
56deaabb32 fdo#73149 add Excel 2010 functions ERF.PRECISE and ERFC.PRECISE
Change-Id: I3199470ec92923e8cc12156f21dd397d870cc1e0
Reviewed-on: https://gerrit.libreoffice.org/8930
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-11 13:43:14 +00:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
355baf5734 fdo#75741: Re-implement CompileNameFormula for formula groups.
Change-Id: I57e1e464ac5f7abc10ce5ea5752e036ddb6cf6d7
2014-04-07 14:43:16 -04:00
f07bdba6c5 fdo#71720 fix transalate strings
Change-Id: I8758e2407f1d3d1e09324b4fe5cc0442f8dda34d
Reviewed-on: https://gerrit.libreoffice.org/8819
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-02 18:43:14 +00:00
22dac22fe2 fdo#73147 add Excel2010 functions NETWORKDAYS.INTL and WORKDAY.INTL
Change-Id: I3ab9dde5c421a3a3e6022a27be37f23547197317
Reviewed-on: https://gerrit.libreoffice.org/8772
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-02 14:01:28 +00:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
4b060ce51a Remove remaining DBG_CTOR etc. remnants from formula
Change-Id: I36740cd276d2047552298606f24b2696ed61b36b
2014-03-28 15:34:01 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
8a0d8f4c0b coverity#738657 Uninitialized pointer field
Change-Id: I37c946d37a7f3add6b6798b15f5fb6ab4b7274ff
2014-03-22 20:18:46 +00:00
d4cc603a5f ISO.CEILING without _xlfn. prefix, it is defined in OOXML, fdo#71720 follow-up
Change-Id: I486261d34d62bc5eda0a202cbb1dcb875ffcf39b
2014-03-10 16:14:50 +01:00
ed77823837 fdo#71720 Add Excel 2010 functions
CEILING.PRECISE, ISO.CEILING, FLOOR.PRECISE

Change-Id: I047b65ca3adafb89fce9b6493948aa851ddca765
Reviewed-on: https://gerrit.libreoffice.org/8488
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-10 08:14:14 -05:00
0ca7ab6ea0 Make these non inline.
Change-Id: Ib139850380b039382565e3de3666eebb5750f32d
2014-03-06 20:50:02 -05:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
e4def6edaa fdo#72197 Add Excel 2010 functions
MODE.SNGL, MODE.MULT, NEGBINOM.DIST, Z.TEST

Change-Id: I55eb05e1ebdb9dbc3ce9ae84e3cdacfdfa112091
Reviewed-on: https://gerrit.libreoffice.org/7776
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 05:53:24 -06:00
cf5ac4dd3c remove unused code formula::FormulaDlg::CheckMatrix()
Change-Id: If7b09d032d0155a38b5d5e8aa1832c86a8f7cec1
2014-03-05 09:17:42 +02:00
41f5dda746 remove unused code in formula/FormulaTokenArray
formula::FormulaTokenArray::AddString(unsigned short const*)

Change-Id: I6c014f6ada3b75398112e81f9c8e7de7dd776c7d
2014-03-05 09:17:42 +02:00
d7f1f91b19 remove unused code in formula/vectortoken
Remove these methods:.
formula::DoubleVectorRefToken::GetRequestedArrayLength()
formula::SingleVectorRefToken::GetRequestedArrayLength()
formula::SingleVectorRefToken::SingleVectorRefToken(
    double const*, unsigned long, unsigned long)

and optimise some accessor methods.

Change-Id: I04f53593894a59dbefdd1cbc9505c6eb7cd8610b
2014-03-05 09:17:42 +02:00
6ef6dd0122 Store the length of originally requested array size prior to trimming.
This change adds GetRequestedArrayLength() method to both single and double
vector ref tokens, which returns the length of the requested array size prior
to trimming of the trailing empty cell region.

Change-Id: Iaba96fa2ea4ff3c8bccb0bc86fa4f1525e2f45fb
2014-02-27 21:19:36 -05:00
224f6c17f7 Remove visual noise from formula
Change-Id: Ie7503623ad9bec1806345f65b435c7bd94a08c2b
Reviewed-on: https://gerrit.libreoffice.org/8263
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 14:50:17 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
819cc64318 coverity#735751 Dereference after null check
Change-Id: Id7e11fefec40d11c509bde01533122ca68db7402
2014-02-24 12:53:08 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
2b9fe0c75e cid#707865 Uninitialized pointer field
Change-Id: I86c90a95093d6c90cbc733164a3b773468575b5b
2014-02-21 11:59:09 +02:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
cabf650ad0 sal_Bool->bool
Change-Id: I3589b3fb44ad57140567338809513b3df7c7eba5
2014-02-19 13:04:57 +02:00
ae2f7da4f9 sal_Bool->bool
Change-Id: Id5cbf2c94e3d3ff27cdb8998e2b7b3b712b537ec
2014-02-19 13:04:57 +02:00
4003da2f87 sal_Bool->bool
Change-Id: Id314bacb8af5c75ecce73a0b7cfee45f36db93da
2014-02-19 13:04:56 +02:00
2e71918d49 sal_Bool->bool
Change-Id: I628c1506573c7d5ec182048a20ed996c9ae879c4
2014-02-18 10:08:03 +02:00
0b9f65d05c coverity#1169835 Improper use of negative value
Change-Id: I73b9ea3f1da05c8ddfd8e0b2da526b65dc1891bb
2014-02-09 15:30:28 +00:00
8185ecf65a fdo#73146 Add Excel 2010 functions
PERCENTILE.EXC, PERCENTILE.INC
PERCENTRANK.EXC, PERCENTRANK.INC
QUARTILE.EXC, QUARTILE.INC
RANK.EQ, RANK.AVG

Function ScInterpreter::ScRank() has been rewritten to give the function
the same way of computing as the related functions in this patch.

Change-Id: If3096b265bd47ca5f4afcab7ff746f7c8511df82
Reviewed-on: https://gerrit.libreoffice.org/7319
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-01-30 12:30:56 +00:00
9b667561c3 coverity#1158192 Improper use of negative value
Change-Id: Ie5b455f3895e9ff53caf773e319d3342642b9945
2014-01-29 13:23:54 +00:00
78ddd6090c bool improvements
Change-Id: I9be9755170694a0071720080af4b8f2c9298f916
2014-01-28 20:26:28 +01:00
5b1e440304 fdo#72793 Add Excel 2010 functions
T.DIST, T.DIST.2T, T.DIST.RT, T.INV, T.INV.2T, T.TEST
Also, fixed some incorrect string assignments in
formula/source/core/resource/core_resource.src from previously
added Excel 2010 functions.

Change-Id: Ia4d13e7597d2a054d345a08b66b878f91c43f872
Reviewed-on: https://gerrit.libreoffice.org/7226
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-01-27 14:14:19 +00:00
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
00d0a50e3b Window::Notify should return bool, redux
Change-Id: Ib41ed9ace428081e1948cf109de095ea9e7c45c2
2014-01-17 18:45:17 +01:00
9c09211bce Add internal cell function __DEBUG_VAR to sniff arbitrary internal state.
Useful for debugging in a more flashy way.  But never ever document this
for end users.  If you are an end user reading this, use this at your
own risk.  You have been warned.

Change-Id: Ibbdb45f576287f707106327704754ffaec27ba3c
2013-12-20 20:09:51 -05:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
924f9d7ea8 fdo#72158 Add Excel 2010 functions
LOGNORM.DIST, LOGNORM.INV, NORM.DIST, NORM.INV, NORM.S.DIST, NORM.S.INV

Change-Id: I695e0645642af1757a1dd7d7f0f15c9515e21309
Reviewed-on: https://gerrit.libreoffice.org/6883
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-12-16 20:25:45 +00:00
d1e1cd128c remove unused code (ancient Calc function ZELLERROR)
code has no function, except that calc documents with formula
ZELLERROR will not produce an error. But the formula is not
interpreted, so remains 'dead code'.

Change-Id: I6e7df7040a0273bcd3ebd497055924b7afdd3311
Reviewed-on: https://gerrit.libreoffice.org/7018
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-12-13 14:09:18 +00:00
e7c10fba90 remove usage of STRING_NOTFOUND in formula.cxx
and tidy up the method a little

Change-Id: I408fd96286749ec9e3743dbdad8cf424a7bb9035
2013-12-04 08:55:35 +02:00
a0be5278c2 remove condition that cannot be hit
GetFunctionEnd cannot return STRING_NOTFOUND

Change-Id: Ic9abee0ea77789e01acedf57c6c13edb0a5c08d9
2013-12-04 08:55:35 +02:00
ca015ac131 convert formula::FormEditData from xub_StrLen->sal_Int32
Change-Id: I0127079ef3ee6bde8e36f2a83ef1f568b9f15568
2013-12-03 11:34:48 +02:00