d8db205e7f
Resolves: #i124706# Consider the toolbar alignment...
...
when executing the PopupMenu
(cherry picked from commit 46d6cabf120e6c1cdf4b01548f435a5ae6f72ae2)
Conflicts:
framework/source/uielement/popuptoolbarcontroller.cxx
Change-Id: Icfccdd35c1849ea00a1ea706aedac25de794bbf6
2014-04-18 09:56:45 +01:00
619b4c40da
and again ... geez..
...
Change-Id: Ib74e4690de547612bbc58ad7db650cf37931d7dd
2014-04-18 02:03:00 +02:00
14f917058e
and again
...
Change-Id: I79fd5b90fd79f55bd80a4ab297192114aae5da42
2014-04-18 02:01:32 +02:00
131edeac01
why obtain the string in each iteration again
...
Change-Id: I3faf1d27bb11eeabbe91da32d35480c9381c50e2
2014-04-18 02:00:37 +02:00
d4ccbef95d
why obtain the string in each iteration again
...
Change-Id: I78225a0b0b53178e6cb7d534d767f5984604e442
2014-04-18 01:59:15 +02:00
bf1737cfe6
and another SvtLanguageTable instance bites the dust
...
Change-Id: I1109d1b7a403d4feb2791e758e1c0540b25029ba
2014-04-18 01:43:24 +02:00
3f814cd286
another SvtLanguageTable instance bites the dust
...
Change-Id: I9d5ab635081539c21c84901c72f8a762f58ed409
2014-04-18 01:41:23 +02:00
d8cc554522
FillLangItems() doesn't need an SvtLanguageTable instance
...
Change-Id: I4c8b8b54c434343eb72fb75aae3c15038cff72af
2014-04-18 01:37:06 +02:00
5fd534de05
Typo: s/gurantee/guarantee
...
Change-Id: I8bd7ca5896931fbf18bf8ae25b62ced9b420fe39
2014-04-18 00:30:35 +03:00
728ec86062
Typo: s/cant/can't/
...
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-18 00:30:35 +03:00
9a7fc5ee26
Typo: s/shure/sure
...
Change-Id: I1c55d3ee8be06deb6d48a6ad5cd30d170c8b9dbb
2014-04-18 00:30:35 +03:00
2a3e221c88
Fix a memory leak
...
The stream should be freed eventually in any case.
Change-Id: I5432b48de5641adc7a13a852fea49adc18bf963b
Reviewed-on: https://gerrit.libreoffice.org/9016
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-17 12:00:04 +00:00
159acfe7b8
coverity#738544 Uninitialized scalar variable
...
Change-Id: Ife273f4e36f7d2cfc837ab6fb21796392fd45d28
2014-04-16 16:41:57 +01:00
c7f2c9c301
coverity#1202950 Uninitialized scalar field
...
Change-Id: I3f3ef0f017d35bb16ecdb7638d23e6b447f7262b
2014-04-16 11:23:10 +01:00
dc6175ff1f
Remove LockHelper::getGlobalMutex().
...
Do what the TODO suggests - change it to SolarMutex in most cases.
In some cases it is only there to guard a local static, introduce a local
mutex for those.
Change-Id: Idc3155818f737b958b36ee9125e2e9e8cb1b91a1
2014-04-15 13:10:56 +02:00
eb4c43aa61
Avoid possible memory leaks in case of exceptions
...
Change-Id: Ie07c6c9989da444eb6052691696e95b808c23fb0
2014-04-15 16:12:31 +09:00
6cde7647c9
typo: implicitely -> implicitly
2014-04-14 12:32:33 +02:00
12a881ec05
typo: inidcates -> indicates
2014-04-14 12:32:08 +02:00
f75aa26620
typo: hierarchie -> hierarchy
2014-04-14 12:32:05 +02:00
83d84adeb5
typo: befor -> before
2014-04-14 12:32:04 +02:00
b1b0530983
typo: independend -> independent
2014-04-14 12:31:59 +02:00
2ada2b3375
typo: dependend -> dependent
2014-04-14 12:31:58 +02:00
6835d9f307
It's "its", not "it's"
...
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
4198039441
Remove unused functions
...
Change-Id: I0f305ef5b9f13e3516b3bbf45d405fad5115521a
2014-04-09 14:21:42 +02:00
a6287e21f1
framework: sal_Bool->bool
...
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
2014-04-07 13:53:49 +02:00
d816acd0e2
coverity#706548 Uncaught exception
...
Change-Id: Ie3be6d503b50cfa86be8fff162d01a72c6b47bf7
2014-04-07 10:14:50 +01:00
d9701f0ebc
Typo: s/ouer/our
...
Change-Id: I0179678c6c5dd6a05b1d7d5038a901e7bf2af3de
2014-04-06 20:27:21 +03:00
e32e7946aa
Bin empty @seealso, @param, @return etc metacomments
...
Change-Id: I9582afceb5daf5993bfca1445370d8a60030c3c5
2014-04-06 20:02:08 +03:00
f4e8d2ad0e
Bin empty @seealso, @param, @return and @onerror metacomments
...
Change-Id: I30a761a21a98419816c4b67258664becd79e2db1
2014-04-06 19:37:48 +03:00
ee3945bd98
Kill superfluous spacing before semicolons
...
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
2014-04-06 19:37:48 +03:00
951ed199f1
Kill superfluous vertical whitespace
...
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
2014-04-06 19:37:48 +03:00
0c50756b5e
Remove redundant pure overrides
...
Change-Id: Ic5e50643d41c08900377a34676c2ff17977643c0
2014-04-03 15:38:23 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
9dc923b146
coverity#738544 Uninitialized scalar variable
...
Change-Id: Idbf32e20ce81e6b726f32183c6f5e1bf0657b5ba
2014-04-01 10:38:26 +01:00
2d737cc401
coverity#707886 Uninitialized scalar field
...
Change-Id: Iefcdcf992f5e25643030ab94e64bd06f9fe7c7e7
2014-04-01 10:38:25 +01:00
3156772937
coverity#707881 Uninitialized scalar field
...
Change-Id: I709bb47bc2cf083805cd8b058b94a763af2ab7ee
2014-04-01 10:38:25 +01:00
e6ff457de6
callcatcher: update unused code
...
Change-Id: I9d8601eb66a460702530e013bf573c6482c49c0b
2014-03-31 09:22:44 +01:00
1978655c32
coverity#1194897 Logically dead code
...
Change-Id: I4cf8d63822c4a68b7cdc126a8d76c1ce7b064655
2014-03-30 21:21:28 +01:00
680139fe7d
typo: opend -> opened
2014-03-29 19:16:33 +01:00
65c3e11ea9
framework: sal_Bool->bool
...
Change-Id: If3276f184c63e85762fe54ce19655c30e00aeb15
2014-03-27 13:45:07 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
65f8ce6d94
coverity#1187652 Dead default in switch
...
Change-Id: Ieedec800955c0785b73caf52ff242b54246b653f
2014-03-25 12:33:18 +00:00
1f1a0af795
coverity#707872 Uninitialized scalar field
...
Change-Id: I1dda581122caff16ab6d00a5f241d032cd021499
2014-03-22 20:43:05 +00:00
7ac3a62379
coverity#738659 Uninitialized pointer field
...
Change-Id: I5d3ebc066f36f9cdcfb031a58ecb9c64ddea26c3
2014-03-22 19:27:03 +00:00
c8239a1dd4
Remove newly unused framework::LockHelper class
...
...and make LockHelper::getGlobalLock() FWI_DLLPUBLIC again (so there's a single
such lock, not one per library).
Change-Id: I0aed77333dc93cdf1c7dd7b96620fb7a8eb3dd64
2014-03-20 17:30:03 +01:00
250a4e8875
Remove newly unused framework::Guard
...
Change-Id: I49650bfd036c5df22f81c3e8cf30bc0795154a30
2014-03-20 17:30:02 +01:00
4ddb43bcf1
Turn odd framework::LockHelper::getGlobalLock() into an osl::Mutex
...
...and extract it to framework::GlobalLock::get().
The old lock was actually effectively two different locks,
LockHelper::getGloblaLock() and
LockHelper::getGlobalLock().getShareableOslMutex(), and both were used in
different places. These places all use the same single osl::Mutex instance now,
but hopefully that does not lead to problems (which it shouldn't, given the
documentation of LockHelper::getShareableOslMutex: "Sometimes we need a osl-
mutex for sharing with our uno helper ... What can we do? We must use a
different mutex member :-( I HOPE IT WORKS!").
Of course, the "TODO: This presumable should return the SolarMutex" still
applies.
Change-Id: I7caea3241d1b70a00272fe1f2214c071ef22cf2c
2014-03-20 17:30:02 +01:00
c641f300f0
Use an osl::Mutex directly
...
Change-Id: If8ff4fc256e530f6b79cc97cf1f47880c93864bf
2014-03-20 15:15:10 +01:00
6147424302
Access safe members directly
...
Change-Id: Ie76f2219c5bce609a23a0bc70d6da43f527ce12d
2014-03-20 15:04:14 +01:00
