wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
351,299 Commits 5 Branches 0 Tags
ff05b6b10094de3e27f9d200c0ccdbb2f6cc76c5
Commit Graph

194 Commits

Author SHA1 Message Date
Jan Holesovsky
dc6175ff1f Remove LockHelper::getGlobalMutex(). 
Do what the TODO suggests - change it to SolarMutex in most cases.

In some cases it is only there to guard a local static, introduce a local
mutex for those.

Change-Id: Idc3155818f737b958b36ee9125e2e9e8cb1b91a1
 2014-04-15 13:10:56 +02:00
Stephan Bergmann
4198039441 Remove unused functions 
Change-Id: I0f305ef5b9f13e3516b3bbf45d405fad5115521a
 2014-04-09 14:21:42 +02:00
Noel Grandin
a6287e21f1 framework: sal_Bool->bool 
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
 2014-04-07 13:53:49 +02:00
Caolán McNamara
d816acd0e2 coverity#706548 Uncaught exception 
Change-Id: Ie3be6d503b50cfa86be8fff162d01a72c6b47bf7
 2014-04-07 10:14:50 +01:00
Tor Lillqvist
d9701f0ebc Typo: s/ouer/our 
Change-Id: I0179678c6c5dd6a05b1d7d5038a901e7bf2af3de
 2014-04-06 20:27:21 +03:00
Tor Lillqvist
e32e7946aa Bin empty @seealso, @param, @return etc metacomments 
Change-Id: I9582afceb5daf5993bfca1445370d8a60030c3c5
 2014-04-06 20:02:08 +03:00
Tor Lillqvist
f4e8d2ad0e Bin empty @seealso, @param, @return and @onerror metacomments 
Change-Id: I30a761a21a98419816c4b67258664becd79e2db1
 2014-04-06 19:37:48 +03:00
Tor Lillqvist
ee3945bd98 Kill superfluous spacing before semicolons 
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
 2014-04-06 19:37:48 +03:00
Tor Lillqvist
951ed199f1 Kill superfluous vertical whitespace 
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
 2014-04-06 19:37:48 +03:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Caolán McNamara
e6ff457de6 callcatcher: update unused code 
Change-Id: I9d8601eb66a460702530e013bf573c6482c49c0b
 2014-03-31 09:22:44 +01:00
Caolán McNamara
1978655c32 coverity#1194897 Logically dead code 
Change-Id: I4cf8d63822c4a68b7cdc126a8d76c1ce7b064655
 2014-03-30 21:21:28 +01:00
Noel Grandin
65c3e11ea9 framework: sal_Bool->bool 
Change-Id: If3276f184c63e85762fe54ce19655c30e00aeb15
 2014-03-27 13:45:07 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Stephan Bergmann
c8239a1dd4 Remove newly unused framework::LockHelper class 
...and make LockHelper::getGlobalLock() FWI_DLLPUBLIC again (so there's a single
such lock, not one per library).

Change-Id: I0aed77333dc93cdf1c7dd7b96620fb7a8eb3dd64
 2014-03-20 17:30:03 +01:00
Stephan Bergmann
250a4e8875 Remove newly unused framework::Guard 
Change-Id: I49650bfd036c5df22f81c3e8cf30bc0795154a30
 2014-03-20 17:30:02 +01:00
Stephan Bergmann
4ddb43bcf1 Turn odd framework::LockHelper::getGlobalLock() into an osl::Mutex 
...and extract it to framework::GlobalLock::get().

The old lock was actually effectively two different locks,
LockHelper::getGloblaLock() and
LockHelper::getGlobalLock().getShareableOslMutex(), and both were used in
different places.  These places all use the same single osl::Mutex instance now,
but hopefully that does not lead to problems (which it shouldn't, given the
documentation of LockHelper::getShareableOslMutex: "Sometimes we need a osl-
mutex for sharing with our uno helper ... What can we do? We must use a
different mutex member :-( I HOPE IT WORKS!").

Of course, the "TODO: This presumable should return the SolarMutex" still
applies.

Change-Id: I7caea3241d1b70a00272fe1f2214c071ef22cf2c
 2014-03-20 17:30:02 +01:00
Stephan Bergmann
e28207718c Use SolarMutexGuard directly 
Change-Id: I0438d85b0c51010eff9e8d53ed8acada98563a20
 2014-03-18 15:27:06 +01:00
Stephan Bergmann
3b45c88a40 Use SolarMutexGuard directly 
Change-Id: I5408403318691f9b83c5b69658a37916fa23ea69
 2014-03-18 15:27:06 +01:00
Stephan Bergmann
5e5c6656c9 Remove unused ThreadHelpBase base 
Change-Id: I367ffa9343a0227eab9726c636d7e8e622219bf4
 2014-03-18 15:27:06 +01:00
Stephan Bergmann
36a5ea2a9c Use SolarMutexGuard directly 
Change-Id: Ia80e709bea172722aa07ee75ebeeef4ac8f5281a
 2014-03-18 15:27:06 +01:00
Stephan Bergmann
8b28069c8f Remove unused ThreadHelpBase base 
Change-Id: Ib530dec8e812d8ecccba47c70e3d1e9640083378
 2014-03-18 15:27:05 +01:00
Stephan Bergmann
0bed494bfc Use cppu::BaseMutex instead of framework::ThreadHelpBase 
Change-Id: I77b88bf1bed18c6a863f9e6d753035c90ef64c07
 2014-03-18 15:27:05 +01:00
Stephan Bergmann
bff533248d Use cppu::BaseMutex instead of framework::ThreadHelpBase 
Change-Id: I3e210cee3b6e0956175083ff0b55ff52c060d9c2
 2014-03-18 13:29:13 +01:00
Stephan Bergmann
60d14352f7 Remove dead file 
Change-Id: I53dfb7f9d49a4b383dc8a32e4cd3b30a4db47819
 2014-03-17 18:04:42 +01:00
Stephan Bergmann
07b32bc2bf Consolidate framework::{Resetable,}Guard 
Change-Id: I97290c2504992f4a92e6aeb71e02a2542dd35faa
 2014-03-17 18:00:10 +01:00
Stephan Bergmann
ab3acb7ef7 Consolidate framework::{Read,Write}Guard 
...now that it is obvious that they both do the same

Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115
 2014-03-17 16:52:34 +01:00
Noel Grandin
1d6fd96df7 framework: prefer passing OUString by reference 
Change-Id: I23c2ac9ef6bfc3eedb8ad6cb199c12d42ed642c8
 2014-03-17 13:30:53 +02:00
Stephan Bergmann
927933404d framework: simplify deprecated XTypeProvider.getImplementationId 
Change-Id: Id137a35c385a5198243eefb9a42f4deace24e195
 2014-03-10 17:39:55 +01:00
Alexander Wilms
fcbefea017 Remove visual noise from framework 
Conflicts:
	framework/inc/dispatch/oxt_handler.hxx
	framework/inc/services/layoutmanager.hxx
	framework/inc/tabwin/tabwindow.hxx
	framework/source/dispatch/menudispatcher.cxx
	framework/source/helper/dockingareadefaultacceptor.cxx
	framework/source/helper/ocomponentaccess.cxx
	framework/source/helper/ocomponentenumeration.cxx
	framework/source/helper/oframes.cxx
	framework/source/layoutmanager/toolbarlayoutmanager.hxx
	framework/source/recording/dispatchrecorder.cxx
	framework/source/services/desktop.cxx
	framework/source/services/frame.cxx
	framework/source/services/urltransformer.cxx

Change-Id: Ibb04e3f6f0796e7f2be16dcce38542f8b90708d4
Reviewed-on: https://gerrit.libreoffice.org/8265
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 14:41:41 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx 
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-20 16:22:17 +00:00
Julien Nabet
94bc29cb71 Typo: I/internaly -> I/internally 
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
 2014-02-09 10:12:07 +01:00
Julien Nabet
6f0e7c36e4 Typo: seam(s) -> seem(s) 
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
 2014-02-06 21:22:42 +01:00
Tor Lillqvist
eeb840d6ba fdo#70376: Put only document (file) name in window title on OS X 
Change-Id: I0b975a1a0e73c546beec96599fd4e5f87caa51db
 2014-02-03 17:48:25 +01:00
Alexandre Vicenzi
a91de8efc9 fdo#54938 Convert framework to cppu::supportsService 
Change-Id: Id0c7c845d128920ba278de4208f5c32dcf83ecb1
Reviewed-on: https://gerrit.libreoffice.org/7754
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
 2014-02-02 14:59:51 +00:00
Stephan Bergmann
612dac063a bool improvements 
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
 2014-01-29 11:08:32 +01:00
Stephan Bergmann
2462159d7b bool improvements 
Change-Id: I754b47013d8f1aa3ecf6204fbe926a438887639d
 2014-01-28 20:26:27 +01:00
Stephan Bergmann
4abe5e61dd bool improvements 
Change-Id: Id91399027008ffbda26f3212bd3ddbba22044f2b
 2014-01-21 18:24:03 +01:00
Stephan Bergmann
a3f32769fc Fix bogus mass-conversion equalsAsciiL -> startsWith 
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.

Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
 2014-01-21 15:54:52 +01:00
Caolán McNamara
296fece62f get master dictionaries in master core 
and a janitorial drive-by in framework

Change-Id: I3106925423cb53f58b59714da49b7928c533e613
 2013-12-28 17:18:03 +00:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
83e191e25d Do not use C++-UNO internal static_type functions in client code 
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
 2013-12-12 11:10:10 +01:00
Noel Grandin
52bbd9cc00 remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls 
Convert code like:
    aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
    aStrBuf.append( "ln(x)" );
which compiles down to the same code.

Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
 2013-11-20 10:07:32 +02:00
Noel Grandin
3af99e4d59 convert equalsAsciiL calls to startsWith calls 
Convert code like:
    aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
    aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.

Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
 2013-11-20 10:07:31 +02:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin
2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro 
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
 2013-11-19 10:29:30 +02:00
Julien Nabet
897bf27a95 cppcheck: reduce scope 
Change-Id: I06c97b99a55d8b291ea31e6a751ced01b0b80e23
 2013-11-10 14:41:22 +01:00