d8cc554522
FillLangItems() doesn't need an SvtLanguageTable instance
...
Change-Id: I4c8b8b54c434343eb72fb75aae3c15038cff72af
2014-04-18 01:37:06 +02:00
dc6175ff1f
Remove LockHelper::getGlobalMutex().
...
Do what the TODO suggests - change it to SolarMutex in most cases.
In some cases it is only there to guard a local static, introduce a local
mutex for those.
Change-Id: Idc3155818f737b958b36ee9125e2e9e8cb1b91a1
2014-04-15 13:10:56 +02:00
a6287e21f1
framework: sal_Bool->bool
...
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
2014-04-07 13:53:49 +02:00
e32e7946aa
Bin empty @seealso, @param, @return etc metacomments
...
Change-Id: I9582afceb5daf5993bfca1445370d8a60030c3c5
2014-04-06 20:02:08 +03:00
f4e8d2ad0e
Bin empty @seealso, @param, @return and @onerror metacomments
...
Change-Id: I30a761a21a98419816c4b67258664becd79e2db1
2014-04-06 19:37:48 +03:00
ee3945bd98
Kill superfluous spacing before semicolons
...
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
2014-04-06 19:37:48 +03:00
951ed199f1
Kill superfluous vertical whitespace
...
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
2014-04-06 19:37:48 +03:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
7ac3a62379
coverity#738659 Uninitialized pointer field
...
Change-Id: I5d3ebc066f36f9cdcfb031a58ecb9c64ddea26c3
2014-03-22 19:27:03 +00:00
c8239a1dd4
Remove newly unused framework::LockHelper class
...
...and make LockHelper::getGlobalLock() FWI_DLLPUBLIC again (so there's a single
such lock, not one per library).
Change-Id: I0aed77333dc93cdf1c7dd7b96620fb7a8eb3dd64
2014-03-20 17:30:03 +01:00
250a4e8875
Remove newly unused framework::Guard
...
Change-Id: I49650bfd036c5df22f81c3e8cf30bc0795154a30
2014-03-20 17:30:02 +01:00
4ddb43bcf1
Turn odd framework::LockHelper::getGlobalLock() into an osl::Mutex
...
...and extract it to framework::GlobalLock::get().
The old lock was actually effectively two different locks,
LockHelper::getGloblaLock() and
LockHelper::getGlobalLock().getShareableOslMutex(), and both were used in
different places. These places all use the same single osl::Mutex instance now,
but hopefully that does not lead to problems (which it shouldn't, given the
documentation of LockHelper::getShareableOslMutex: "Sometimes we need a osl-
mutex for sharing with our uno helper ... What can we do? We must use a
different mutex member :-( I HOPE IT WORKS!").
Of course, the "TODO: This presumable should return the SolarMutex" still
applies.
Change-Id: I7caea3241d1b70a00272fe1f2214c071ef22cf2c
2014-03-20 17:30:02 +01:00
8114055880
Use an osl::Mutex directly
...
Change-Id: I37264f25b5ad89f72d25f78808ff796f581536c4
2014-03-20 15:04:13 +01:00
f9c73e458f
Use an osl::Mutex directly
...
Change-Id: I2ec909c81faabd896310b29b0d7149b0f7744b35
2014-03-20 15:04:13 +01:00
227e924bae
Use SolarMutexGuard directly
...
(both users of PropertySetHelper use a SolarMutex-based ThreadHelpBase)
Change-Id: If542914bbf33a9e81f86d654498c2af04082f31d
2014-03-20 09:48:23 +01:00
07b32bc2bf
Consolidate framework::{Resetable,}Guard
...
Change-Id: I97290c2504992f4a92e6aeb71e02a2542dd35faa
2014-03-17 18:00:10 +01:00
a98d7543ad
No need for framework::LockHelper to derive from framework::IMutex
...
Change-Id: I677abeb9e313b983f750331ec925c24ade04e95b
2014-03-17 17:41:23 +01:00
ab3acb7ef7
Consolidate framework::{Read,Write}Guard
...
...now that it is obvious that they both do the same
Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115
2014-03-17 16:52:34 +01:00
571a34e350
Remove superfluous framework::LockHelper::{acquire,release{Read,Write}Access
...
Change-Id: I2f8b8c07b943f8aea47523db99a019c7c4541248
2014-03-17 16:52:33 +01:00
7cb41ae451
Remove no-op framework::LockHelper::downgradeWriteAccess
...
Change-Id: I26c8dbfb2ad3b159d3b32dea450e063f1552d714
2014-03-17 16:52:33 +01:00
23b13bce74
No need for framework::IRWLock interface
...
...of which framework::LockHelper is the only implementation
Change-Id: I235bb699ff26b1579803f617990fc4f71fe18b22
2014-03-17 16:52:33 +01:00
fcbefea017
Remove visual noise from framework
...
Conflicts:
framework/inc/dispatch/oxt_handler.hxx
framework/inc/services/layoutmanager.hxx
framework/inc/tabwin/tabwindow.hxx
framework/source/dispatch/menudispatcher.cxx
framework/source/helper/dockingareadefaultacceptor.cxx
framework/source/helper/ocomponentaccess.cxx
framework/source/helper/ocomponentenumeration.cxx
framework/source/helper/oframes.cxx
framework/source/layoutmanager/toolbarlayoutmanager.hxx
framework/source/recording/dispatchrecorder.cxx
framework/source/services/desktop.cxx
framework/source/services/frame.cxx
framework/source/services/urltransformer.cxx
Change-Id: Ibb04e3f6f0796e7f2be16dcce38542f8b90708d4
Reviewed-on: https://gerrit.libreoffice.org/8265
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 14:41:41 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
ea8aec196b
Remove unnecessary #include
...
Change-Id: I34e6c5514aa40fe7c5e0215e4d5885bb345242d8
2014-02-03 16:05:10 +01:00
2462159d7b
bool improvements
...
Change-Id: I754b47013d8f1aa3ecf6204fbe926a438887639d
2014-01-28 20:26:27 +01:00
ba8413d262
Introduce com.sun.star.frame.theUICommandDescription singleton.
...
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28 18:52:22 +01:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
7f436c1fd3
typo fixes in comments
...
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
2b3e225853
Bin some uses of the stupid DECLARE_ASCII macro
...
Change-Id: I076eef8069e848ec3cf9c69f1b489ad44586324e
2013-09-09 00:58:15 +03:00
1817936b28
Bin unused remains of framework's own "debug framework"
...
Change-Id: I71937debf674ff11173d7d8fa5aa43dc12234ce6
2013-09-09 00:29:23 +03:00
9a8e2d09bc
Use SAL_WARN_IF instead of framework's home-grown LOG_ASSERT(2)
...
Also remove declarations for debug function that don't exist (have been
removed (misguidedly?) as unused perhaps).
Change-Id: I0bc3320c52b3d50dc851a07fdc30b593cc4856b1
2013-09-08 23:51:41 +03:00
6aa0698828
Use SAL_INFO instead of framework's own LOG_WARNING
...
Change-Id: Ief44fceaf03d2567f4aacd9ff74d361436e5e05b
2013-09-08 23:51:41 +03:00
bf42b6f9f5
fdo#62475 - remove visual noise
...
This is a follow up commit to
- 22d1beb78a475e4846af945afde1c4d6c263b5d6
- 1c7af455ab9345304a7ac48ce2e0310de2ac8a75
Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-31 22:41:10 +02:00
6a419ad8f2
Bin intermediate iterator
...
Change-Id: I49e6cd7bc6e4db95163d0b0b8c81bb4330ead081
2013-08-27 06:57:44 +02:00
932dbfd2d1
Bin intermediate iterator + rename parameter function
...
Change-Id: Ic1055af502918ee754673a6e3ad704c55ef09a36
2013-08-27 06:32:16 +02:00
1c7af455ab
Re-work 8bit characters in source code, or remove them.
...
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@suse.com >
Tested-by: Michael Meeks <michael.meeks@suse.com >
2013-08-20 19:30:59 +00:00
9dbb8db06d
Convert the easy cases in framework to WeakImplHelper
...
Change-Id: I6547c4aee2aa4d15ad516a6a45002b81b7a8ac13
2013-07-23 10:05:45 +02:00
ca8bdb17df
improve comments
...
Change-Id: Ib2735c946ca331382e0c178b303c3769c0a35185
2013-07-23 10:05:42 +02:00
ba0a57702c
remove OUString wrap for string literals
...
For some functions and all kinds of Exceptions.
CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException
createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService
bash command:
for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
| cut -d ':' -f1 | sort -u
| xargs sed -i
-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
-e "s/\($i.*\)\"+ /\1\" + /g";
done
Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-06-29 21:52:54 +00:00
fe1ac1bf90
fdo#46808, convert XMultiServiceFactory to XComponentContext
...
Change-Id: I5ed0b12bf37e7d235fc88182c006a6ed07ef2343
2013-05-22 15:20:07 +02:00
cb6d67c21f
Spelling "separate" (etc) correctly is hard
2013-05-15 11:14:28 +03:00
ee47dfa474
LockHelper::getGlobalLock is never called with an argument
...
Change-Id: I90b431345d791c887f9047258a6f439bcf222784
2013-05-14 14:41:55 +02:00
4af8a94a96
Remove unused LOCKTYPE_FRAMEWORK env var override
...
...which means that only the E_SOLARMUTEX part of LockHelper is ever used.
Change-Id: Ibff0bda324af67c85cbd2975d308c612c66e5052
2013-05-14 14:41:55 +02:00
61ac80a6f6
ENABLE_MUTEXDEBUG is never defined
...
Change-Id: I533cc7041177cceff14d1e44e4cd1d25d5e94c11
2013-05-14 14:41:55 +02:00
11fd73acce
SolarMutex does not belong into the URE interface
...
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx. It looks
like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an
abstract interface to be used to implement a SolarMutex" put it here in the
first place.
I do not consider this an incompatible change really, as no external URE client
code should have used SolarMutex anyway.
(Also included some clean up, like removing unused
{Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places
it is used.)
Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14 14:41:54 +02:00
c32b6be06b
fdo#60724 correct spelling
...
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
2013-04-15 05:32:37 +02:00
435f5e30c9
fdo#60724 correct spelling
...
Change-Id: I7318a9f4f3410edf4dbe67bf08f31682fcb4edc7
2013-04-15 05:10:29 +02:00
60fbefc615
fdo#60724 informations -> information
...
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-15 04:49:39 +02:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
