eb4c43aa61
Avoid possible memory leaks in case of exceptions
...
Change-Id: Ie07c6c9989da444eb6052691696e95b808c23fb0
2014-04-15 16:12:31 +09:00
a6287e21f1
framework: sal_Bool->bool
...
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
2014-04-07 13:53:49 +02:00
951ed199f1
Kill superfluous vertical whitespace
...
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
2014-04-06 19:37:48 +03:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
65f8ce6d94
coverity#1187652 Dead default in switch
...
Change-Id: Ieedec800955c0785b73caf52ff242b54246b653f
2014-03-25 12:33:18 +00:00
7f0a6e262f
Use an osl::Mutex directly
...
Change-Id: I7131abdc2202f80f0e9600d04633bbd6078700bf
2014-03-20 10:49:39 +01:00
67f3785650
Remove unused ThreadHelpBase base
...
Change-Id: I0e15184071fc2c1cb231ead98210d4a1654208e7
2014-03-20 09:48:22 +01:00
94f8a0e60b
Use SolarMutexGuard directly
...
Change-Id: I4b245dd68bf032a1d74fb16b910dc952fd761781
2014-03-20 09:48:22 +01:00
2299b5964d
Remove unused ThreadHelpBase base
...
Change-Id: Ibddf0ab4107772a65f27851b1ebce3f7bb5d3bcf
2014-03-19 18:17:06 +01:00
034781978a
Use SolarMutexGuard directly
...
Change-Id: Iba3daff93e8ff73a16ebfbc51a36b5b9a5a50de9
2014-03-19 18:17:06 +01:00
67b4b6b52b
Use SolarMutexGuard directly
...
Change-Id: I7c2f9205d2fc7017c6eaafec7a46d92524e3104d
2014-03-19 18:17:06 +01:00
5fe8aa2d48
Use cppu::BaseMutex instead of plain osl::Mutex as base
...
Change-Id: I2880172edbabcd41f8847359b1b308658a9e07c8
2014-03-18 13:29:16 +01:00
2d604c48aa
Use cppu::BaseMutex instead of plain osl::Mutex as base
...
Change-Id: I35c346855f0557d623d058b5a233abb08653934e
2014-03-18 13:29:16 +01:00
07b32bc2bf
Consolidate framework::{Resetable,}Guard
...
Change-Id: I97290c2504992f4a92e6aeb71e02a2542dd35faa
2014-03-17 18:00:10 +01:00
a5b57622f9
coverity#1187865 Uninitialized scalar field
...
Change-Id: I69026472ac720f0dd41710033b3ec3b5f14ccb2c
2014-02-27 12:58:51 +00:00
fcbefea017
Remove visual noise from framework
...
Conflicts:
framework/inc/dispatch/oxt_handler.hxx
framework/inc/services/layoutmanager.hxx
framework/inc/tabwin/tabwindow.hxx
framework/source/dispatch/menudispatcher.cxx
framework/source/helper/dockingareadefaultacceptor.cxx
framework/source/helper/ocomponentaccess.cxx
framework/source/helper/ocomponentenumeration.cxx
framework/source/helper/oframes.cxx
framework/source/layoutmanager/toolbarlayoutmanager.hxx
framework/source/recording/dispatchrecorder.cxx
framework/source/services/desktop.cxx
framework/source/services/frame.cxx
framework/source/services/urltransformer.cxx
Change-Id: Ibb04e3f6f0796e7f2be16dcce38542f8b90708d4
Reviewed-on: https://gerrit.libreoffice.org/8265
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 14:41:41 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
076a7eacca
Bug #63962 Dynamically scan the config directory for icon themes
...
The hard-coded icon themes have been replaced by a dynamic list
which is filled by scanning the config directory
Conflicts:
include/vcl/settings.hxx
vcl/source/app/settings.cxx
vcl/source/window/window.cxx
Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed
Reviewed-on: https://gerrit.libreoffice.org/7935
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-21 17:23:50 +00:00
24949f84ae
coverity#737202 Uncaught exception
...
Change-Id: I2ac23ed9f308b92ff9457938b265677f008aaca7
2014-02-13 14:56:21 +00:00
924a415e68
cosmetics
...
Change-Id: Ice4f20db3a590568a7ae4ae59fa0c4ff13e59051
2014-02-13 11:26:31 +01:00
25c1e9cca2
cid#705176 missing break in switch
...
Change-Id: Iaa331cc259aed93ffa7c3544586f800a795cc25d
2014-02-12 08:59:05 +02:00
d55495daf9
Do not throw if AcceleratorConfigurations are missing.
...
Which can happen on mobile platforms if we don't want them.
Change-Id: I53639ccc75886708850d2d3a01eec76104b7f2c9
2014-02-10 16:43:54 +01:00
e034b0323c
Simplify the code a bit.
...
Change-Id: I57581fb0f3439ddc4a4848466f6925d962b04aea
2014-02-10 16:43:54 +01:00
5ac9d90f0a
coverity#737167 Uncaught exception
...
Change-Id: Id1d9790b7d3229d11e83ad68a5b9104a3da159f0
2014-02-10 11:21:14 +00:00
99f50cd8e2
coverity#1169846 Uncaught exception
...
Change-Id: Iae590d7b9ca2701a6917823524f819d18cb5676f
2014-02-09 21:07:39 +00:00
53052e5bfa
fwk: Constructor feature for single-instance WindowStateConfiguration.
...
Change-Id: I0537d7a30b6c6807bf746a52dbd2c7fc66607ae2
2014-02-06 12:03:30 +01:00
92c8a8fc82
fwk: Ctor feature for single-instance ModuleUIConfigurationManagerSupplier.
...
Change-Id: I4674ed6852807e08ff8319515b0ab4e9535b668a
2014-01-30 10:48:25 +01:00
2462159d7b
bool improvements
...
Change-Id: I754b47013d8f1aa3ecf6204fbe926a438887639d
2014-01-28 20:26:27 +01:00
ba8413d262
Introduce com.sun.star.frame.theUICommandDescription singleton.
...
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28 18:52:22 +01:00
b2c89e7236
fwk: Constructor feature for one instance UICategoryDescription.
...
Change-Id: I56c906c9eeafb625dee65eec9fe39ea3aee66251
2014-01-28 18:52:22 +01:00
c2c530da69
Introduce static inline cppu::acquire(), and make use of that.
...
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.
Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-22 15:09:28 +01:00
f278397787
Change _get_implementation()'s not to do initialization directly.
...
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.
As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.
Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-21 21:25:22 +01:00
e1b85e77b1
drop using namespace ::com::sun: ⭐ :ui;
...
Change-Id: Ia10e9ad0c5495b8a4887d84781967ffb58a6a7d6
2014-01-18 18:30:17 +01:00
72b5343bd1
fwk: Use constructor feature for ModuleUIConfigurationManager.
...
And avoid css::uno::XInitialization protocol.
2014-01-18 17:02:36 +01:00
278880fbd1
fwk: Use constructor feature for ImageManager.
...
Change-Id: I3f231980b1908495b1f5ec17f95c39c464d40ff8
2014-01-17 12:25:04 +01:00
b93ea039eb
fwk: Use constructor feature for UIConfigurationManager.
...
Change-Id: Icd42b6b9b62271606659651a2f463e1ee2956fe6
2014-01-17 12:24:54 +01:00
dae9b7060d
Drop duplicate #include
...
Change-Id: Ib8969d5cd4898b81a5dcd90dc313abd28adfe052
2013-12-10 15:52:49 +09:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
d4fa4c7b38
fdo#69500: Revert "fix bug #60700 - de-crutify ODF files"
...
This reverts commit da06166015689eca260c702602bef4cea58afbd3.
2013-11-18 13:27:50 +01:00
ab5d1fbfb4
SAL_WARN_UNUSED com::sun: ⭐ :uno::Any
...
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
c4a593b6b1
remove unnecessary use of OUString constructor in FRAMEWORK module
...
Change-Id: Icbed4f318043a166ed78fe0c49a53f87ebf7201d
2013-11-11 08:36:07 +02:00
15b5412fad
fixincludeguards.sh: framework
...
Change-Id: Ia6f3cb21977095df45a176db2bf68f508c70191c
2013-11-05 09:28:53 +01:00
e2451bd729
Convert indexOf->startsWith and lastIndexOf->endsWith
...
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
dd28837249
vcl: mark more Image constructors as "explicit"
...
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22 14:42:17 +02:00
ed2cd062eb
-Werror,-Wunused-variable
...
Change-Id: I703d08f4c1080e5c5afaab9652ea2c18b4f365f1
2013-10-02 17:48:35 +02:00
eb103fa411
-Werror,-Wunused-const-variable
...
Change-Id: Id416a7bcb3ac3ea5354f6f7b5ec3daa1dc742f8d
2013-10-02 16:49:31 +02:00
6a3cf741d1
Otherwhise -> Otherwise
...
Change-Id: Iaec23e1d240f675a04b52cd251c4cb2a1242bb44
2013-09-26 10:21:12 +02:00
e8ecf30ea6
convert FRAMEWORK module from String to OUString
...
Change-Id: Iafa6b5f213d37093e7e46065c9264c7bb7fae377
2013-09-17 09:05:49 +02:00
