Commit Graph

20 Commits

Author SHA1 Message Date
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
4b60d33f88 Mark overriding CanvasCustomSpriteBase class template mem funs as SAL_OVERRIDE
Change-Id: I6c64d1b1caae27a1e1eac3a743aec078bc652d96
2014-03-12 16:24:41 +01:00
e40ceb8111 Mark overriding BufferedGraphicDeviceBase class templ mem funs as SAL_OVERRIDE
Change-Id: I707fea8100c686ab8232eaf6e4d9a348abdb5236
2014-03-12 16:24:41 +01:00
288a6d8901 Mark overriding GraphicDeviceBase class template member funs as SAL_OVERRIDE
Change-Id: Idfac26bb0f436799c3431062238e46b1a50d9f14
2014-03-12 16:24:40 +01:00
268be3ac88 Mark overriding DisambiguationHelper class template mem funs as SAL_OVERRIDE
...which reveals that some uses are not derived from XEventListener, so re-
introduce BaseMutexHelper as an alternative (which originally got superseded by
DisambiguationHelper in 09b546cf9c1d0d9f78066e70a0348c7678cdcb14 "Fix
overloaded-virtual warning in canvas").

Change-Id: I1418370733b72526ec481b70fa69f03e7c28b7ce
2014-03-12 16:24:39 +01:00
781992ceba Mark overriding SpriteCanvasBase class template member funs as SAL_OVERRIDE
Change-Id: Ie01ae7e29f22fbb2f627a9c671f48bb1c19c5f56
2014-03-12 16:24:39 +01:00
ea7adb4a3a Mark overriding IntegerBitmapBase class template member funs as SAL_OVERRIDE
Change-Id: I484ef5c4b31122605287b8e1a5f33108f7b22ea2
2014-03-12 16:24:39 +01:00
19edde1840 Mark overriding BitmapCanvasBase class template member funs as SAL_OVERRIDE
...which reveals that SpriteCanvasBase is not derived from XBitmapCanvas, so
split up BitmapCanvasBase (just XBitmap) and BitmapCanvasBase2 (plus
XBitmapCanvas) and make IntegerBitmapBase directly abstract over those two as
arguments.

Change-Id: Ieae87fe466bb9f1a861c8a95162ef25235ae5799
2014-03-12 16:24:38 +01:00
736420454a Mark overriding CanvasBase class template member functions as SAL_OVERRIDE
Change-Id: I70ebad88d126d3aaa1c2023f98f6be71dc281287
2014-03-11 17:01:29 +01:00
8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
5dd3ad8163 coverity#1103730 Uncaught exception
Change-Id: Ic4fd67374ab79856e7c51010af83b8dcee33b512
2014-02-11 14:33:38 +00:00
4d13f9129d fdo#65108 inter-module includes <>
Change-Id: Ifd86f72985928d7b044809c83c112935b433c1f4
2013-11-09 18:48:38 -06:00
0bd7f12d41 fixincludeguards.sh: include/c*
Change-Id: Icba422d99836518a1b662b15144bc9334bed1473
2013-10-23 23:22:30 +02:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
be62c01287 fdo#39674 fix some spelling
Change-Id: I72e497fb97edf8782c69000576f42896594e1556
2013-10-04 15:05:04 +02:00
717aafb9ca robustify some headers
Change-Id: Id1998b240025973f43691e83cebce17449b060ba
2013-06-30 14:52:30 +02:00
b9337e22ce execute move of global headers
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details

Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-23 22:20:31 +02:00