97a5ba4a71
remove comments why a file gets included
...
also remove some commented out code
Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
728ec86062
Typo: s/cant/can't/
...
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-18 00:30:35 +03:00
6835d9f307
It's "its", not "it's"
...
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
6ac0e1399a
Remove silly PUT_SEMICOLON_AT_THE_END
...
...and rather live with macro calls not terminated by semicolons until those
macros are gone for good anyway. Completely remove unused
DECLARE_UNO3_XCOMPONENT_DEFAULTS.
Change-Id: I0d4eb5a91736004b0da2b09fce860e57f6d1ddbd
2014-04-07 17:27:39 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
cc3a302fcb
typo: unfortunally -> unfortunately
2014-03-29 19:16:20 +01:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
b3847f3dfd
Work around MSC "'override' cannot be used with 'inline'" bug
...
Change-Id: Icd3b09f098c19268ac888dd6195fb535979557ed
2014-03-26 17:11:29 +01:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
ffbe0107e7
No need for OPropertySetAggregationHelper::disposing() to be virtual
...
("overriding" OPropertyStateHelper::disposing(), which is likewise non-virtual)
Change-Id: I767225afb4a07ae4d93493e7b894979eb98e294b
2014-03-14 17:57:24 +01:00
98666e8625
No need for a virtual OPropertyContainer::getTypes
...
(and rename to getBaseTypes for clarity)
Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
849fb80648
Mark overriding OInteraction class template member function as SAL_OVERRIDE
...
Change-Id: I1fe694c38b583b9169ee246cdcb9cbeb9bd31542
2014-03-14 17:57:24 +01:00
92e7274891
A minimal improvement
...
...in the mess that is OComponentProxyAggregationHelper and its derived classes
dispose/disposing functions.
Change-Id: Ic22ab85e86ad6657a5e06027d4fd8ea600367891
2014-03-14 17:57:24 +01:00
36784563ed
OAccessibleContextWrapperHelper does not implement XAccessibleContext
...
...but rather some (non-virtual) base functionality for use in derived classes
(that do implement XAccessibleContext)
Change-Id: Idb0023906108db22bb9696245f07b9a4c053a0d1
2014-03-14 14:29:24 +01:00
0085bd2866
Model IEventProcessor acquire/release exactly after XInterface
...
...so classes deriving from both can easily share a single implementation for
these functions.
Change-Id: I6882dddc8b3ea3b0192d85102a0305494d964dc1
2014-03-14 12:20:41 +01:00
358be80f65
comphelper,connectivity: prefer passing OUString by reference
...
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
22684273d5
forward*PropertyValue functions need not be SAL_CALL
...
...and _bSuccess parameter is unused
Change-Id: Iee5e1d5c2d4272f342b2867bfe76f8c87dcd69d4
2014-03-13 14:00:03 +01:00
fb542379d4
Mark overriding OWeakListenerAdapter class template mem funs as SAL_OVERRIDE
...
Change-Id: I8cfc2eeb8b9fd7f00c17e03871d1fed504c0bbf6
2014-03-13 12:50:12 +01:00
61c44a9929
comphelper::OIHWrapNoFilterDialog does not implement XInitialization
...
Change-Id: Idce153607c3deb3f0a1809b9d18cbcc6f30cf04d
2014-03-13 12:50:12 +01:00
3228e1f7df
Mark overriding OwnServiceImpl class template member functions as SAL_OVERRIDE
...
Change-Id: I767c60733b39de02935de8be8dd9d3e351a38cab
2014-03-12 16:24:41 +01:00
8fb6f4a74b
Mark overriding cppuhelper class template member functions as SAL_OVERRIDE
...
Change-Id: I51942d37eacd11000c08a784d8a995bd8f9f972c
2014-03-11 18:31:48 +01:00
d47ca30f1c
No need for implGetBounds to be SAL_CALL
...
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
2014-03-11 15:35:52 +01:00
a850bed771
Typos in comment
...
Change-Id: I6204090cb95213e31c11d33c5e822f8abee10963
2014-03-11 14:47:48 +01:00
33320eceb0
No need for NotifyAccessibleEvent to be virtual
...
Change-Id: Id21324f756b835fd501868175a5a2a77cb2997a7
2014-03-11 14:47:08 +01:00
c7b09e0ed6
No need for fillAggregatePropertyInfoByHandle to be virtual
...
Change-Id: If002dede857ecff300f57b73b26234d737ba98c9
2014-03-11 14:12:47 +01:00
ff19246a81
OPropertyStateHelper::getTypes isn't an override of XTypeProvider::getTypes
...
Change-Id: I633c711aabbd2ec7d1385d106b512f14672393f1
2014-03-11 13:03:20 +01:00
2726f2a785
comphelper: simplify deprecated XTypeProvider.getImplementationId
...
Change-Id: I8da24ffd5eb1ac1fe6a6d2312ddc4ab13828bf07
2014-03-10 17:39:53 +01:00
8792ec7b21
Remove visual noise from include
...
Conflicts:
include/framework/preventduplicateinteraction.hxx
include/sfx2/sfxbasecontroller.hxx
include/sfx2/sfxbasemodel.hxx
include/toolkit/awt/vclxtabpagemodel.hxx
include/vcl/field.hxx
include/vcl/settings.hxx
Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-03-01 09:51:32 -06:00
697ec96e61
coverity#1187646 unused mpAbort
...
Change-Id: I1fc3f0253c2af4779ba59b5b85ea7fc400226177
2014-02-27 12:58:50 +00:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
6fbe00f9b6
coverity#983702 Uncaught exception
...
Change-Id: I3a0b4c8fe4208d0945860f6b4e1b31852aef8502
2014-02-25 16:12:23 +00:00
c69ae9f8f8
comphelper: EmbeddedObjectContainer::GetObjectStream methods
...
These methods were added to provide access to the stream to the
embedded object itself.
Change-Id: I0a47a54852cddbd5ddd0a6599bba21999afd96ba
2014-02-24 13:24:52 +01:00
b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
ad73967e99
Remove unnecessary extractInterface
...
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
6759faa1e6
sal_Bool -> bool fixup
...
Change-Id: Id1d838fe4316bbc0e1137d395bb15db3585aed84
2014-02-18 10:55:23 +01:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
f45183d26f
Unwind comphelper::OPropertyContainer_Base typedef
...
Change-Id: Ied87e18f8297fb8e85fdbcab38d719664e3ed066
2014-02-12 12:03:28 +01:00
94bc29cb71
Typo: I/internaly -> I/internally
...
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-02-09 10:12:07 +01:00
3ec9bccaab
silence coverity#1027865 Out-of-bounds access
...
and coverity#1027864
Change-Id: Ic3d1b91ef77ab3510c7428b7135dd9f249d56b4b
2014-02-07 09:03:48 +00:00
9bd0e895a4
coverity#1079000 Uncaught exception
...
Change-Id: I7ffee42abe03c34d68b6168328143666d72e7efc
2014-01-29 16:41:32 +00:00
1b574435a5
bool improvements
...
Change-Id: I17c451d33d6d5e4edf0304ff47d63ac878d7e5d9
2014-01-28 20:24:39 +01:00
fdf9406792
misuse of OUString::boolean on sal_uInt8 values
...
regression since 64b993e046f23baaacaff1572b7d2a816588b5ef
Change-Id: Ifc907a34430c36a64318fc42342e630e2b84ad13
2014-01-20 12:32:25 +00:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
8233226fe4
No need for implbase1.hxx to include XComponentContext.hpp
...
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up,
of course.
Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
66397a4fd2
fdo#72598 Remove SunStudio cruft from code base
...
Change-Id: I5150eec33228e18e274a8ae4effd3f185851b7f4
Reviewed-on: https://gerrit.libreoffice.org/7103
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2013-12-16 20:52:39 +00:00
ab9e014d6f
Some clean-up
...
Change-Id: I8ea3018efb01069b9a0555d9ac4ddfa89a990ba8
2013-12-12 15:10:35 +01:00
3f3c755475
Remove newly unused comphelper/TypeGeneration.hxx
...
Change-Id: Ia63e07fa6f56f4797e2741f6800cb96559ff4928
2013-12-12 15:10:35 +01:00
45c0a6174d
Simplify comphelper::PropertyInfo
...
...as its sole two uses (in sw) are already fine with initializing arrays of
it dynamically, there is no harm in changing it and thereby getting rid of the
last use of comphelper/TypeGeneration.hxx.
Change-Id: I11931dbbec48dac5a694a59cf6425206c806fbfb
2013-12-12 15:10:35 +01:00
2b0063dd49
Remove unnecessary comphelper::eqFunc
...
Change-Id: I94d5e3fff2d1e039051bddfedcedfac04487529a
2013-12-12 11:48:03 +01:00
