Commit Graph

1324 Commits

Author SHA1 Message Date
d83dfeb5e5 filter: sal_Bool->bool
Change-Id: Icf20f23cb46ad3cb147d8c6a743f1d25a23fbca5
2014-04-22 09:56:06 +02:00
5df6dcf747 package: sal_Bool->bool
Change-Id: I05dd5070d0618ef7539b26c7edcaf01b0a84732c
2014-04-22 09:53:14 +02:00
d75f773f62 fixincludeguards.sh: package
Change-Id: Ia66d825baad3315c34bd579dc804f607bc6be30b
2014-04-19 11:10:11 +02:00
c3e84d4c74 sal/log.hxx functionality also includes the equivalent of OSL_LOG_PREFIX
Change-Id: I1bb0115a378003b5cc5b1cfc59c474a1f100d894
2014-04-16 22:42:40 +02:00
a60d9aa7ce package: Turn own logging infra into SAL_INFO to reduce product bin size.
Change-Id: I81b4cf62cb6ae77ea35e7781ef5f464c28b44855
2014-04-16 18:28:19 +02:00
02e14adc6e remove update_precomp.py markers 2014-04-14 12:31:55 +02:00
a736781e83 Remove dead function declaration
Change-Id: If16e9bed79cc55896cb6c35367935848140da4df
2014-04-14 11:54:48 +02:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
6f7ca49591 package: sal_Bool->bool
Change-Id: I66999e5d9f827650f4c1bccb14178f8fa8a57cbf
2014-04-03 09:17:50 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
7d3b9d3333 typo: optimisation -> optimization 2014-03-29 19:16:18 +01:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
52cc0c8f05 coverity#982784 Unintentional integer overflow
Change-Id: Ib50e0987adf419ecdd569fc5dd5c8b2b1e246e2f
2014-03-21 08:54:44 +00:00
16b6b45e8c coverity#707964 Uninitialized scalar field
Change-Id: I051e5ae4200563426d810e9a4d94ab02fb8ccf51
2014-03-21 08:54:44 +00:00
86a32589e9 Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
bf8441444c package: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I6cfedbb93fade4179d9dcbf3701116d4b320ebd3
2014-03-10 17:39:56 +01:00
1349f49a72 Use cppu::OImplementationId for XUnoTunnel IDs
Change-Id: I564ec761b7a7b3488682acfb3aff56beb3f68213
2014-03-10 08:59:23 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
d148739576 Remove visual noise from package
Change-Id: Icef40ad2d451d3c5ca90ed4b305ece5430d352f7
Reviewed-on: https://gerrit.libreoffice.org/8289
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 09:13:49 -06:00
5f17e5eaad Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-21 14:35:52 +09:00
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
faced6b5f7 ucbhelper: sal_Bool -> bool
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-02-17 17:55:18 +01:00
04ff535f72 normalize values of SYSTEM_ZLIB, SYSTEM_DICTS, SYSTEM_FONTCONFIG
Change-Id: I7530cb9d0797df5fc86695b0379cc44c159d2ab5
2014-02-12 09:53:08 +01:00
f9369d33a4 fdo#54938 Convert to cppu::supportsService
Change-Id: I512c525029ebd63d261560d27e9f38bbe94f7e10
Reviewed-on: https://gerrit.libreoffice.org/7649
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-03 14:35:46 +00:00
0f50845dbd bool improvements
Change-Id: I5dfdb3a11737a2cb805ff44652c9ca502e5fc81b
2014-01-28 20:26:25 +01:00
cb64711136 Don't use OSL_LOG_PREFIX when throwing exceptions in non-debug builds.
Using OSL_LOG_PREFIX in the exceptions is not a good idea; it blows the size
of the string literals tremendously - full build path for every line that uses
that, including the line.

Let's not remove it for good, but hide it for non-debug builds
(OSL_DEBUG_LEVEL == 0) so that anybody who would like to use this during
debugging could still do (but I doubt it has any value for anybody).

Change-Id: Icc8db95ae0862671a206e681f92c60cdf51ffc32
2014-01-27 23:21:43 +01:00
a6b0c67ee5 css::io::XInputStream _is_ allowed
Change-Id: Ib72c02a329bbc9a26390a16e115fd8ae94343263
2014-01-27 18:14:04 +01:00
01fe7b7238 bool improvements
Change-Id: I80dfcb60878d9e280e8a03297ccc4833277c235d
2014-01-22 08:22:32 +01:00
c20db8735e Revert "impl. enumeration for ZipPackage"
This reverts commit 5b2cca80eeb2c8ee210820cc8ed95e5d69214807.
Also reverts commit 86a5053df0d755d10121d65c533f3d327340a0fd.
2014-01-16 16:40:00 +01:00
28619201e9 do not close input, unless it was us who opened it
Change-Id: I6ffedd1e64e48b4fc4bd6f5eb63e96b49f1a8508
2014-01-16 16:39:59 +01:00
86a5053df0 bah
Change-Id: I0fd33c8ee1791714ee9b42f50cabbdc51ebe4440
2014-01-15 21:44:26 +01:00
5b2cca80ee impl. enumeration for ZipPackage
Change-Id: I800d22d8ec99e943b59467cf64b96aaa1f797953
2014-01-15 21:27:47 +01:00
ed6b4dc7f6 package: avoid un-necessary modification event work.
Change-Id: Ia4b4e3edccf661b8c5f474c5c7474b5f9e497fcc
2014-01-05 16:23:39 +00:00
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
88b9e7f391 fdo#71786 : Implemented Glossary folder
1. Glosary folder is imported as Intrograb and exported.
   2. Added unit test case

Reviewed on:
	https://gerrit.libreoffice.org/6825

Conflicts:
	sw/qa/extras/ooxmlexport/ooxmlexport.cxx
	writerfilter/source/filter/ImportFilter.cxx

Change-Id: Ifd51a75a65e030d44d30e02cd7ab51fb088186b3
2013-12-13 11:19:42 +01:00
827b44d38a Related: EDB-29934-1 add .zip cppunit tests
Change-Id: Iaafdcc4e2c97e06bee245251316b18b3d9e87262
2013-12-02 12:26:26 +00:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
0865c446c2 fdo#54938: Convert package, writerfilter and writerperfect
Change-Id: I5220e172bf9722ad86eef3bc557c30779f07201c
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-30 16:27:50 +01:00
8df17a3409 gbuild: set Package default target to INSTDIR
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28 20:17:26 +01:00
da5449da0c fdo#54938: More uses of cppu::supportsService
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d
Reviewed-on: https://gerrit.libreoffice.org/6423
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-25 08:07:04 +00:00
f852bda5ec clean up some include guards
Conflicts:
	sw/source/ui/inc/content.hxx

Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6
Reviewed-on: https://gerrit.libreoffice.org/6388
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-23 10:28:07 +00:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
2d30d16e13 -Werror,-Wunused-variable
Change-Id: I682b5d72c1785e8d8cb9c8bb42d4a0bab6db263e
2013-10-11 10:05:49 +02:00
ad7b757a25 'ist' -> 'is' here and there.
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
2013-10-04 20:27:30 +02:00
7bdbe709ea WaE: unused variable
Change-Id: Iad493e5022a36895a30438340826ef4df50b2837
2013-10-02 19:37:30 +03:00