Commit Graph

2422 Commits

Author SHA1 Message Date
cc1352243e typo: accesible -> accessible 2014-04-14 12:32:01 +02:00
9d7ee8a70f qadevOOo: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I1efcc27818c8ec92db32151afc8f17bbf7fc1f40
2014-03-10 17:39:57 +01:00
faabee6755 Remove visual noise from qadevOOo
Change-Id: I3d65145422039d629d2375c9fef030cd6ee41124
Reviewed-on: https://gerrit.libreoffice.org/8291
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:59:24 -06:00
8e000814ef Typo: folowing -> following + elemtens -> elements
Change-Id: Ice7ae2e82085ba5f0061ba1a960f693744e45e63
2014-02-25 22:11:12 +01:00
4ed804d928 Typo: realtion -> relation
Change-Id: I2ec2d716eaff6c6dc03bf657e77daa8e4d57cb53
2014-02-06 21:25:21 +01:00
8f50196ef1 *_AppDispatchProvider_get_implementation cannot bypass XInitialization
...as SfxAppDispatchProvider implements new-style service
css.frame.AppDispatchProvider that doesn't declare any non-default ctors (which
looks broken, though) and old-style service css.frame.DispatchProvicer.

(And fix the test code to pass in meaningful XInitialization arguments.)

Change-Id: Ifcc32d17f6b96ade2acc40ccdb60f7bad2d503a4
2014-02-04 11:51:49 +01:00
ef602ba8ce Remove unused XInitialization.args data
...now that ModuleUIConfigurationManager no longer implements XInitialization
since 72b5343bd16deec540d8cd148cd7aebd74e92c16 "fwk: Use constructor feature for
ModuleUIConfigurationManager."

Change-Id: I479c6c93e9982d80318e53b794bac99e949a5e46
2014-01-20 17:40:52 +01:00
be053c9a80 Spelling correction: s/retrive/retrieve/
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20 23:26:58 +02:00
718de51eb9 Some Java String clean-up
Change-Id: I6728720a13f4b66edc6c5cd0b7a9bcb036e86ff2
2013-11-24 20:58:56 +01:00
a25d360b3e Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed, the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments" plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 "Also cope with
intermittend DisposedExceptions."

Change-Id: I5244e8f8af9560ae986ed3a836bdf9571574420f
2013-11-04 18:24:25 +01:00
baa68e4e89 Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed, the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments" plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 "Also cope with
intermittend DisposedExceptions."

Change-Id: I64389b817d91a2bed8dfe1b8d92bafec42eba21a
2013-11-01 09:41:30 +01:00
ee337e7ed6 Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed, the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments" plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 "Also cope with
intermittend DisposedExceptions."

Change-Id: I4b0ca00c04c2b1c8ffbfe4aaf926305ee9b51f30
2013-10-22 12:24:31 +02:00
dcee4cfcdc Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed, the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments" plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 "Also cope with
intermittend DisposedExceptions."

Change-Id: I4d429a96b7b595776aaf3fa20e3e03b00ca886bc
2013-10-08 10:55:32 +02:00
f52d78bf7c Unused variable (AccessibilityTools is all static members)
Change-Id: I5f3be57dea77cec1cfa3f48833758b0c2328350e
2013-10-08 10:55:32 +02:00
b5dd2b4218 Also cope with intermittend DisposedExceptions
...while waiting for the .uno:PrintPreview request to be processed, see
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments."  (However, to avoid an endless loop in case DisposedExceptions
are caused by a crash of soffice.bin, cap the loop at 10 sec.)

Change-Id: I13518eea46deb68731604ef08461bad5bb5f7cdf
2013-10-07 10:22:16 +02:00
32e0f451d6 junit: add 'r' to creating, and better exception descriptions. 2013-09-30 15:28:58 +01:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
5b5c52a3a4 Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed and
xRoot/oObj would still be null.  Hopefully, it does not introduce infinite
loops, though.

Change-Id: Ie79e0b0a3185528ab4036ed7a33de81117c02c83
2013-08-28 13:23:58 +02:00
77dc93ddea What's it with all those *static* XSpreadsheetDocument instances?
...appears to be completely unnecessary, and maybe this helps fix some obscure
DispsedException failures in JunitTest_sc_unoapi (not ones resulting from a
crashed soffice.bin, but "genuine" ones happening when chasing
util.AccessibilityTools.getAccessibleObjectForRole).

Change-Id: I127940e9a2a9784d01255307b60614d53c86436f
2013-08-22 14:55:29 +02:00
bcce27d283 No (apparent?) need for xSheetDoc to be static
Change-Id: Iea653925d383537f5f7f5ef9dd7559e7cb8730cf
2013-08-21 14:19:10 +02:00
8dbfb3bfb1 More little fixes for JunitTest_forms_unoapi
...needed since 8ee69b0ba13f74d1515fac71df92947eb6328ab1 "fdo#67235 adapt form
control code to time nanosecond API change, step 3."

Change-Id: If0fc8109d6da56c8e8df181ae0b35a4d9b34e767
2013-08-05 11:57:23 +02:00
89fbed7e29 Revert "Java cleanup, AccessibilityTools.."
This reverts commit d702dd4396161f8e2e7396f5c24554088b752fcb, which reproducibly
broke JunitTest_sc_unoapi:

java.lang.NullPointerException
 at util.AccessibilityTools.getAccessibleObjectForRole_(AccessibilityTools.java:177)
 at util.AccessibilityTools.getAccessibleObjectForRole(AccessibilityTools.java:95)
 at mod._sc.AccessibleEditableTextPara_PreviewCell.createTestEnvironment(AccessibleEditableTextPara_PreviewCell.java:149)
 at lib.TestCase.getTestEnvironment(TestCase.java:121)
 at base.java_fat.getTestEnvironment(java_fat.java:319)
 at base.java_fat.executeTest(java_fat.java:167)
 at org.openoffice.Runner.run(Runner.java:234)
 at org.openoffice.test.UnoApiTest.test(UnoApiTest.java:38)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:601)
 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
 at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
 at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
 at org.junit.runners.Suite.runChild(Suite.java:128)
 at org.junit.runners.Suite.runChild(Suite.java:24)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
 at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
 at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
 at org.junit.runner.JUnitCore.run(JUnitCore.java:136)
 at org.junit.runner.JUnitCore.run(JUnitCore.java:117)
 at org.junit.runner.JUnitCore.runMain(JUnitCore.java:98)
 at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:53)
 at org.junit.runner.JUnitCore.main(JUnitCore.java:45)

Change-Id: I3601fe24db21bd63f7dc6cdf0a1eb69f447d962a
2013-05-21 16:56:30 +02:00
d702dd4396 Java cleanup, AccessibilityTools..
was using a global variable. Yuck.
Fix it to use a local variable. Not perfect, but better.

Change-Id: I27bbbb2ddc89402da53be7f19d2cd963b03b1a83
2013-05-20 09:21:20 +02:00
2ce25faffd fix typos (wich instead of which) 2013-05-06 20:07:23 +02:00
6f17a2f66f Java cleanup, access static methods using correct syntax
Change-Id: I8443aef43d82de33ac7cb47d40cc5b544f7c9c87
2013-04-26 08:36:04 +02:00
64e85a4cc8 Java cleanup, remove unused imports
Change-Id: I697017f196a7f7e5684011ae23941e54051c45dd
2013-04-26 08:29:38 +02:00
ada0298167 Java cleanup - reduce use of global fields
This field does not need to be global, it is returned from the relevant
methods

Change-Id: Ic53eec4a699d6acc4410e71dde385e6a49ded745
Reviewed-on: https://gerrit.libreoffice.org/3567
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-23 10:30:31 +00:00
37eee65fbf Java cleanup - static fields that should not be static
Somebody appears to have been confused about the purpose of static
in Java.
These are instance fields and should therefore not be static.

Also reduce the visibility of some methods and fields.

Change-Id: I0b5875b6cbd91ee89823e2058b87c1087dc5c92e
Reviewed-on: https://gerrit.libreoffice.org/3555
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-22 14:38:25 +00:00
8d87758d65 Java cleanup, remove the rest of the unnecessary casts
Change-Id: Ia61d250f6b3711abc29569c5ece38a6f87e38daa
Reviewed-on: https://gerrit.libreoffice.org/3432
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-19 07:52:08 +00:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
435f5e30c9 fdo#60724 correct spelling
Change-Id: I7318a9f4f3410edf4dbe67bf08f31682fcb4edc7
2013-04-15 05:10:29 +02:00
811462723b qadevOOo: fix typo
Change-Id: I00e90954f535d023b48a80d319563c43bd935d93
2013-03-12 20:59:42 +01:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
0c317af38a s/childrens/children/
Change-Id: I1731710811506383d29c835a613b07506e7232f0
2013-02-22 09:32:10 +02:00
ee43379455 Revert "Use XNotifyingDispatch to avoid races"
This reverts commit 21ea372541a81972aa33cb2226dbc2ee3886e23a.  Looks like
neither XNotifyingDispatch nor XSynchronousDispatch can be used to avoid this
race; sigh.
2012-12-10 18:25:09 +01:00
21ea372541 Use XNotifyingDispatch to avoid races
Change-Id: Ia91bd08122052f5ea206eb9e6c03524e6e3ec245
2012-12-07 16:21:49 +01:00
d23508eebb Revert "Use XSynchronousDispatch to avoid races"
This reverts commit 16383552c8477ac4620d6260a2b7981a9a6aaf17, which was broken,
but toplevel "make .../workdir/*/JunitTest/sc_unoapi/done" did not trigger
qadevOOo rebuild, so got unnoticed at first.

Change-Id: I6031cf9f67a8cc69cbabd197bd01462968eeb07e
2012-12-07 12:35:58 +01:00
16383552c8 Use XSynchronousDispatch to avoid races
Change-Id: I517ae0f3a17e769da20219d69d7ff4bac44623cd
2012-12-07 12:14:22 +01:00
57d97807f7 i#25473: this was fixed by previous commit, so enable...
...those tests again.  Also there does not appear to be a reason to
exclude MAYBEVOID properties.

Change-Id: Ic73adb8800aee7f65e86394cecfe13b7b24eed13
2012-12-04 00:57:46 +01:00
7a8d933585 API CHANGE: remove com.sun.star.text.XTextEmbeddedObject
This interface was apparently never implemented in OpenOffice.org.

EXISTENCE: published key "/UCR/com/sun/star/text/XTextEmbeddedObject"
exists only in registry 1

Change-Id: Ib802fa3f035d1842c9ee8018ef15f35a4680fe2b
2012-11-30 18:56:44 +01:00
28327c28ce API CHANGE: remove com.sun.star.system.XProxySettings
... and related services:

com.sun.star.system.SOffice52ProxySettings
com.sun.star.system.ProxySettings
com.sun.star.system.SystemProxySettings

The implementation for these has apparently been removed in
OpenOffice.org 2.0 or thereabouts.

EXISTENCE: published key
"/UCR/com/sun/star/system/SOffice52ProxySettings" exists only in
registry 1
EXISTENCE: published key "/UCR/com/sun/star/system/ProxySettings" exists
only in registry 1
EXISTENCE: published key "/UCR/com/sun/star/system/XProxySettings"
exists only in registry 1
EXISTENCE: published key "/UCR/com/sun/star/system/SystemProxySettings"
exists only in registry 1

Change-Id: If00c332edf08619fcad12ed07d0d8a13a714045e
2012-11-29 23:53:37 +01:00
e6f81b1898 API CHANGE: remove com.sun.star.document.XDocumentInfo
The following badly designed interfaces and services were deprecated
in OpenOffice.org 3.0 and are now remove from the API:

com.sun.star.document.DocumentInfo
com.sun.star.document.StandaloneDocumentInfo
com.sun.star.document.XDocumentInfo
com.sun.star.document.XDocumentInfoSupplier
com.sun.star.document.XStandaloneDocumentInfo

The supported replacements for these have been introduced in OOo 3.0:

com.sun.star.document.XDocumentProperties
com.sun.star.document.XDocumentPropertiesSupplier
com.sun.star.document.DocumentProperties

http://www.mail-archive.com/interface-announce@openoffice.org/msg00432.html

Remove the implementation of these interfaces and services in sfx2
(SfxBaseModel, objuno.cxx)

Also remove unit tests for these services in qadevOOo and sfx2.

Conflicts:
	offapi/type_reference/types.rdb

Change-Id: Ib0b48a4e53a8079c82fac3bb49a829812f8e5256
2012-11-26 23:14:33 +01:00
31170413ae API CHANGE: com.sun.star.lang.IllegalArgumentException
... derives from com.sun.star.uno.RuntimeException instead of
com.sun.star.uno.Exception.

Only test that breaks with this change is jurt_uno/AnyConverter_Test,
which for mysterious reasons effectively tests that
IllegalArgumentException is a subclass of Exception and not
RuntimeException.  Presumably this is just a generic exception test that
happens to use IllegalArgumentException.

Some further testing indicates there are no problems expected at
runtime:
Running "make subsequentcheck" with all Java test code compiled against
a ridl.jar that does not contain the change, running against a soffice
that uses ridl.jar and rdbs with the change + ridl.jar with the change
on the test side yields exactly the same AnyConverter_Test failure, with
no other failures.

Change-Id: Iad183de76ec7e0d56648084e97cdcc160b5b033d
2012-11-26 23:14:33 +01:00
117fdb9898 convert users of XDocumentInfo to XDocumentProperties
Change-Id: I10f395f90d554d0ec26fe9f2654ae839e21c7ee5
2012-11-22 12:10:30 +01:00
f2d8b05b73 improve junit test failure messages around CLSID. 2012-11-15 16:06:07 +00:00
08894f7c7d add native XTextSearch / cppunit test framework.
ported from the broken java ver.
adds a native ICU regex sanity test.
2012-11-12 11:46:07 +00:00
d3f60c050a fdo#51304: Remove @author and more commented code
More tags removed and with it, more commented code was found. So remove it all.
Not functional changes here, just a cleanup.

Change-Id: Id4a6b3126ca32f3460dec3056b9caa370d0ee69c
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2012-09-27 12:22:04 +01:00
9ac86f484b Improvement on previous commit, UCB clean up
* As UCB is only ever initialized with "Local"/"Office", remove this
  configuration vector completely.  The "create" ctor creates an instance
  internally initialized with those "Local"/"Office" keys.  Special (test) code
  can still instantiate an uninitialized one via plain createInstance.  And for
  backwards compatilibity process startup still ensures to create an initialized
  instance early, in case there is still code out there (in extensions) that
  later calls plain createInstance and expects to get the already-initialized
  (single) instance.

* XInitialization is an "implementation detail" of the UniversalContentBroker
  service, do not expose in XUniversalContentBroker.

* ucbhelper/configurationkeys.hxx is no longer needed and is removed.

* ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that
  requires ucbhelper::Content constructors to take explicit XComponentContext
  arguments now.

* The only remaining code in ucbhelper/source/client/contentbroker.cxx is
  Android-only InitUCBHelper.  Is that relevant still?

Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
2012-09-14 18:24:49 +02:00
bf4352084b Java cleanup, remove unnecessary imports
Change-Id: Iacfcb2e16cb0e3c25a4cd0678a374fe5111284f7
2012-09-06 17:13:58 +02:00
ab7f5365ae Make it easier to use IDE with Java
Java IDE's get upset if the package does not match the path, so move some
files to make them match.

Change-Id: Ia6a1f3dc572cc1d30492491de9cf1462f2887e6f
2012-09-05 21:01:44 +02:00