Commit Graph

641 Commits

Author SHA1 Message Date
1c27bb5237 Some trivial -fsanitize=undefined adaptions
Change-Id: I60f6e2b5f041919319cb6b72684b8b7b8504560c
2014-04-16 14:13:47 +02:00
be9e778230 remove outdated RS6000 checks 2014-04-14 12:31:48 +02:00
b06a6bba31 Clean up function declaration
Change-Id: I3c38149f9c99b45170f44f48725087cbe5dba40e
2014-04-08 10:10:43 +02:00
7e629ac799 coverity#707973 Uninitialized scalar field
Change-Id: I882bca4d09fe655275543cfeb3add59d4584d14b
2014-04-04 12:14:22 +01:00
baa6b723d1 coverity#707522 Uninitialized scalar variable
Change-Id: Ib655e3763c1d8deb1c10a10616390d5fdefe2291
2014-04-01 10:38:26 +01:00
f9903a57dc callcatcher: update unused code
Change-Id: If4615e5bcb012321c554f75cd936dbf9b0dbf8ab
2014-03-14 08:55:34 +00:00
f008fe11b7 coverity#708798 Unused pointer value
Change-Id: Ib27f174b37577a8572fb853a7040de51e95d665e
2014-03-13 16:25:11 +00:00
1eeb20f395 CurrencyFields cannot be loaded from .src anymore
Change-Id: I3ccdb71e39a13dc8c697d3a52dc693cff10c614d
2014-03-13 11:18:37 +00:00
feff54d8ce MetricBoxes cannot be loaded from .src anymore
Change-Id: Id7b44402975ed75171f4475aa64ebd2a3d6bd687
2014-03-13 11:18:37 +00:00
1de7c36a94 CurrencyBoxes cannot be loaded from .src anymore
Change-Id: I662aab01ecf5f78c4406838118ccea3988060521
2014-03-13 11:18:37 +00:00
4737ed363a DateBoxes cannot be loaded from .src anymore
Change-Id: Ic9d3c73cf67e855dc5931e96bc03014998cce9e0
2014-03-13 11:18:37 +00:00
24cfa40779 TimeBoxes cannot be loaded from .src anymore
Change-Id: I1fa101656538c40c402fc8608f33961f293bd58d
2014-03-13 11:18:36 +00:00
d40971a478 MoreButtons cannot be loaded from .src anymore
Change-Id: Ib831895b33323dd478cc125b3bf93c43826ef59d
2014-03-13 11:18:36 +00:00
e218663251 fdo#63154 Remove unused solar.h
Removed from dbaccess. editeng, filter,
framwork, formula, lotuswordpro, reportdesing, rsc,
uui

Conflicts:
	framework/source/uielement/menubarwrapper.cxx
	reportdesign/inc/RptDef.hxx
	uui/source/iahndl.hxx

Change-Id: Ia6f1d8679736c3de99bd8060d8a7f76975268273
Reviewed-on: https://gerrit.libreoffice.org/8118
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-28 15:01:05 -06:00
9aee4d1c9e harmonize Tell() Seek() type.
Change-Id: I2e472aa0279d0763762d3c660207cd74da512626
2014-02-24 23:14:45 -06:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
d33d1e316c coverity#708799 unused pointer value
Change-Id: I141bb64b5e4e2f8624008f12c9551881e91f4fdb
2014-02-10 11:30:33 +02:00
b826f09e18 bool improvements
Change-Id: Ib1663b761675eebf9399c4d006b2fc59dd72cb47
2014-01-28 20:26:24 +01:00
8c06444d0e coverity#983075 : ressource leak
Change-Id: I70c0be6be1e880dacbf56aa6b040d6a514ce0f5c
2014-01-25 21:07:22 -06:00
b833876805 Use bool
Change-Id: Id6c1f1d4e4ee7aa29f16ef6930c1eb3d4a3a411f
2014-01-10 17:11:44 +01:00
f276c0057c Be explicit when using bool as integral value
Change-Id: I0712b56dbcf8508876ed6eca5e0f02d85b35af67
2014-01-10 17:11:44 +01:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
66397a4fd2 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I5150eec33228e18e274a8ae4effd3f185851b7f4
Reviewed-on: https://gerrit.libreoffice.org/7103
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-16 20:52:39 +00:00
b3c2cf2ae1 widht -> width
Change-Id: I661eeb167a95540a223ce72aac51789daf3767dc
2013-11-23 23:22:25 +01:00
73342dbb82 remove unnecessary RTL_CONSTASCII_STRINGPARAM
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.

Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-22 08:07:19 +02:00
5112f6a6c6 remove RTL_CONSTASCII_STRINGPARAM in OString constructor
Convert code like:
    OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
    OString aKeyName("NDX");
which compiles down to the same code

Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
2013-11-20 13:56:07 +02:00
1730df0127 remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::append
Convert code like:
   aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
   aOStringBuf.append( " is missing )" );
which compiles down to the same code.

Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20 10:07:32 +02:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
0937d07cd5 Simpligy: Bin odd atexit crack
Change-Id: Ib7e491ae66525b8ba2555b50fe7c9e1fed150987
2013-10-12 21:03:36 +03:00
dc76fc4eda CID#707521 unintialized member
Change-Id: Ieb4417ae89718d8c5e9abf77cb3e1830c080ae4e
2013-10-09 16:59:44 +01:00
dd0999570a CID#707522 uninitialized member
Change-Id: Iaadc8ea9f14dc2596f252e2f06a1613e6080f9ff
2013-10-09 16:59:44 +01:00
5a0d01ee83 CID#441298 use after free
Change-Id: I4fd16f157244fa3406036d0f506c32bed0cf5b8a
2013-09-12 13:09:03 +01:00
e13fd39593 getFallbackStrings() with bIncludeFullBcp47 parameter
so the various places that check the full tag first do not have to get
it just to delete it again.

Change-Id: Ib4e3cf1b16988464db875f1b6ac5cf4a0ab60fe5
2013-09-05 16:51:28 +02:00
f00cd93a66 callcatcher: update unused code, esp unused Resource based ctor
e.g. no ImageRadioButton is now loaded from any res/rsc file, so
that ctor and associated code paths can be stripped out

Change-Id: Ic4cf19d45adb7c734f150e0b89eef193157a74a7
2013-08-27 09:58:35 +01:00
087ee66013 encapsulate IsoLangEntry again
Change-Id: I66475eb3914b07b4c7a045e295ef77a5de9439d4
2013-08-23 23:09:09 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
cc0b40f6a9 add some a11y relations and enable translation of ms
Change-Id: Ib509a7ae62aefc919bdaed269c1605ac6bae9564
2013-08-18 13:47:31 +01:00
ce043bb4f9 callcatcher: update unused code list
Change-Id: I84f693aa6747f639bd4ae60a02dd4d8c30b7d029
2013-08-16 13:59:30 +01:00
2235f495e3 add a seconds unit
Change-Id: I3507caab5cd61c282102ab21bf034ec54e497af3
2013-08-13 14:51:15 +01:00
d0e6571634 add degrees and pixels as known spin field units
Change-Id: I5937843a5c5485f469ef1fb6b5844aa15c33a14d
2013-07-08 18:40:11 +01:00
f9075eb5cc warning C4805 unsafe mixture of type int and type bool
It is a mystery what this is supposed to do, but rsc is sort of going
away in the mid-term anyway so who cares...

Change-Id: If1c1b8216c0429909c0571b3360b6dca97f265c4
2013-07-04 20:08:57 +02:00
bb45bdf359 module rsc: String, bool and other clean-up.
Change-Id: I2dcde42e6068631a5a643961a764df86dc63dca2
Reviewed-on: https://gerrit.libreoffice.org/4690
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-07-03 20:53:12 +00:00
e67c21ee06 Search for char instead of 1 char long string, when possible.
follow-up of a7674482254ee996b1c4fee60f3064778be369aa

Change-Id: I25f40c601454c092078307d931333af1bc1447ac
2013-06-29 09:53:41 +02:00
61fd1d2e78 fdo#62699 remove rsc/inc/vclrsc.hxx
Change-Id: I8a90bfcfff904d42a529644ae7b6f03d0ac762eb
2013-06-28 06:55:38 +02:00
51daa4de4f fdo#43460 sd,rsc,ucb,sdext: use isEmpty()
Change-Id: I7a7a77c26b74078f7fc160fbaa1c8d4e912b844e
Reviewed-on: https://gerrit.libreoffice.org/4442
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-06-24 21:44:24 +00:00
96c2986dd4 Quiet cppcheck
Change-Id: Ib860b6dc3b7ace5f737d283778827bfb0783b362
2013-05-16 21:57:57 +02:00
56fa2d1bed Revert "coverity#983096: Resource leak"
This reverts commit 039bfd3e517f75cf99eb8eb105d3b83692f6e484.
2013-05-08 10:48:10 +01:00
039bfd3e51 coverity#983096: Resource leak
Change-Id: I91c1d505ef0b0eb442bf76e4da66c95fa0e1bb2d
Reviewed-on: https://gerrit.libreoffice.org/3818
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-05-08 08:27:08 +00:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00