Commit Graph

3922 Commits

Author SHA1 Message Date
947177a5cb fdo#74555: Avoid excessive calls to GetPreviewCellStyle().
GetOptimalHeight() gets called *all the time* and is very performance
sensitive.  Let's not do an expensive operation such as GetPreviewCellStyle()
which slows down pretty much everything else after the non-default font is
applied.

Change-Id: I5d5b2e706dd5dd98173044642b98ccaedd9536f0
2014-04-16 14:50:47 -04:00
d593956174 SfxItemPool(..., ATTR_STARTINDEX, ATTR_ENDINDEX, aItemInfos, ...) off by one
...since d9ef61fb546af443736057557552e3a95c569c11 "API CHANGE: roll back the
XStyle changes to add a new Hidden property on Style" bumped ATTR_ENDINDEX for
ATTR_HIDDEN but didn't adapt aItemInfos, and mstahl suggests its better to
adapt aItemInfos than to use ATTR_ENDINDEX-1 in the SfxItemPool ctor call.

Change-Id: Iafdf595091ac300793bad1bcd87d58abba4fda6d
2014-04-16 16:28:33 +02:00
99b06e60ca CID#736182 guard against a dubious call from SearchAndReplace()
Change-Id: I6ce1b577c377721b882c1f8ec757a61e600ae671
2014-04-16 00:04:23 +02:00
b09426b83c fdo#76294: Properly intern string literals in formula on xls import.
Change-Id: Ib3a442cbb68c23294762561f2911101a087a795e
2014-04-14 17:00:40 -04:00
8f40305196 fdo#77209: Share string pool with clip documents.
We do the same with undo documents, and it will only make sense to do
the same with clip documents as well.  Also, put the sharing part into
a common method (for ease of tracking).

Change-Id: I342b22d95374ee06d16318a66ffea0ac5b42621c
2014-04-14 11:41:05 -04:00
141a87dd3c Clean up function declarations and some unused functions
Change-Id: If2c233a8ced8815b065a72caff907f10ef6166ff
2014-04-14 15:41:27 +02:00
75f5d9d214 typo: postion -> position 2014-04-14 12:32:40 +02:00
f9cc0daec2 fdo#77307: Compare external formula tokens correctly.
To avoid different external (add-in) tokens from being evaluated equal.

Change-Id: If78187901bdca7fe0da50442b0bb66e0650dc70f
2014-04-11 21:40:28 -04:00
0e63ca4fde fdo#77300: Do the same for the shared formula case as well.
Change-Id: I560b0beabe81907e3f85d8845041a9df25d2200d
2014-04-11 00:56:10 -04:00
66c6a3bfc9 fdo#77300: Don't re-compile formulas when the hybrid formula is not there.
Change-Id: I9b0f8d031fec08bb8d92333ff67074fdc739e034
2014-04-11 00:44:55 -04:00
f1ca138470 also check if a newly read password protection applies to a range
Change-Id: Ibbf4fee2b87c82cdbd565681690a231fb06da66f
2014-04-08 14:44:27 +02:00
a65e9fd24d hold security descriptors read from OOXML independently
If anyone knows how to interpret that stuff and convert between
BIFF/OOXML feel free to implement..

According to ISO/IEC 29000 the securityDescriptor is application
defined, but recommends that username@domain be used, which is addr-spec
of RFC 822. Well, what Excel2013 writes is something like this
'O:WDG:WDD:(A;;CC;;;S-1-5-21-2328606873-448790680-2149751550-1003)'

Change-Id: I138fa116b019f200c211272abf69831bc49127ab
2014-04-08 11:54:33 +02:00
615f6aa293 fdo#75741: Share the context objects to avoid poor performance.
Change-Id: I1015dbfa9e2220cd23244dae17ee8dc4828c6a67
2014-04-07 21:30:35 -04:00
355baf5734 fdo#75741: Re-implement CompileNameFormula for formula groups.
Change-Id: I57e1e464ac5f7abc10ce5ea5752e036ddb6cf6d7
2014-04-07 14:43:16 -04:00
8f6c55a839 Replace SV_DECL/IMPL_REF macros with SvRef template
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-07 12:38:27 +02:00
c4c51709ea whitespace cleanup in sc
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-04-06 17:19:54 +02:00
791257261d coverity#738791 Uninitialized scalar field
Change-Id: I962aa178ee4d99d4b0dba3a864a5da0e728b269d
2014-04-04 16:24:35 +01:00
261391b247 coverity#738790 Uninitialized scalar field
Change-Id: Id33ca48b70382bbb59f0ee0a34510c00766e5610
2014-04-04 16:24:35 +01:00
453ee351f3 fdo#43157 : clean up more OSL_POSTCOND
Change-Id: Iaca31b4e12c258b762b3d88fbad0fb08b4f1fc16
Reviewed-on: https://gerrit.libreoffice.org/8832
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-04 07:23:43 -05:00
2bd665fadb callcatcher: another layer post pivottable conversion
Change-Id: I58a6a1f0cf0d67bfadddb331364551776998908a
2014-04-04 12:14:26 +01:00
cc911e8bc4 just nitpicking on scope
Change-Id: I01969fb4596e7866ddb348d026a22f45deeef0c8
2014-04-02 16:58:50 +02:00
6f3545833e coverity#738789 Uninitialized pointer field
Change-Id: I990e8ba0e2b8ad2a43a33343ac832e42777e28cb
2014-04-02 15:51:44 +01:00
45ce21ac5a coverity#738787 Uninitialized pointer field
Change-Id: Ic2f968d3150bba458dc3f40799ef0933a423a9e0
2014-04-02 15:51:43 +01:00
e65141e93a re-enabled user-defined numeric fields for dBase export
Since commit f59e350d1733125055f1144f8b3b1b0a46f6d1ca it was impossible
to define a numeric field with a precision of less than 2 decimals, even
if all values were integers. It was also impossible to define a field
width larger than needed for any values in that column. Furthermore, the
integer part was shortened if the overall column's values resulted in
more precision than defined, but the overall length did not reach the
predefined length.

This does not change the behavior of the original intention of
f59e350d1733125055f1144f8b3b1b0a46f6d1ca to give the precision of number
formats precedence over precision defined in the column header, which is
debatable though because conflicts may silently change the field
definition.

Change-Id: I234c4bceaa1a6aadbd259cb8d9b6cb6f16bf91c2
2014-03-31 22:31:23 +02:00
e75f8d8e05 sc: clean-up pivot.hxx/pivot2.cxx
Change-Id: I88ed4da8dd2ca026eeea4a3fb267f4f9954c180a
2014-03-31 09:44:45 +02:00
2ec45841b9 rhbz#1080196: Delete the destination first then paste.
Deleting in-between pasting was causing the block iterators to become
invalid when the deletion took place, which resulted in a segfault.

Also cleaned up the bits about handling filtered rows.  It was using the
old row flag which is empty these days (so it never would have worked).
Plus we do bail out earlier if the destination contains a filtered row.

Change-Id: I78d3ee8bce1647c1c8685f92a3df3c38cc014811
2014-03-28 20:56:32 -04:00
0c8c30a95e bRefSizeChanged is always false
Change-Id: I2f27e55a11f972374e7ef0d007a69f3cfb92a7bb
2014-03-28 15:35:53 +00:00
11676ac765 coverity#1078506 troubling Logically dead code
Change-Id: I9687ab7340e9c9ab45ff4dd27eb53e671492e7b5
2014-03-28 15:35:53 +00:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
003a27a14d fdo#74322: Handle moving of named ranges correctly.
But named ranges are adjusted if and only if the references are absolute.

Change-Id: I6c5287b413884b045f1a798c6c6683aa17863f24
2014-03-25 22:37:10 -04:00
98c6b4149e union of a to be edited range may be distributed over two different records
Change-Id: I1d0047e04394a79134b3333eef35ba0cfe6a8ca1
2014-03-25 20:43:07 +01:00
a603ddf9ad fdo#76402: Write unit test for this first.
Change-Id: Ib4fccb0e29d4a21a211de4af2cdeaf956f9b9cc6
2014-03-25 12:41:57 -04:00
61df9ee7b1 made range not editable if password is assigned
... until we can verify the password.

Change-Id: I3690e9d8c0e07185a0533b669a034581895ab57a
2014-03-24 23:11:59 +01:00
44956c3261 coverity#1078504: Remove logically dead code.
Change-Id: I6bb3ee8f604d9b79209cda13a48ccd7f2df4f26e
2014-03-24 13:08:07 -04:00
f516cff220 Avoid possible resource leaks by boost::scoped_array
Change-Id: I7b72c5680d5665b3f1f720f50a2d3ea6fc0c3e39
2014-03-24 03:10:18 +09:00
e00136005d WaE: unused variable 'it'
Change-Id: Ib98e20284a2311db5b93412be7c59026deeefee2
2014-03-23 08:29:24 +02:00
5f01a51762 coverity#983375 Dereference before null check
Change-Id: Ib00b65a5c532c2968785c8783d43d1728b1dfb29
2014-03-22 17:50:27 +00:00
474b2ea601 fdo#76470: Avoid joining new formula cells individually.
Instead, insert the formula cells in the group first, then only try to join
the top and bottom cells afterward. Otherwise the grouping would get messed
up and a problem would ensue.

Change-Id: I4fdd5326c029032a636d8225b5fb16cbde427c7d
2014-03-22 09:51:41 -04:00
0e0755e390 use enhanced protection permission to override protection attribute
Change-Id: I53eeb5ffe6e700dd02e3966ccd66738c7b5ab464
2014-03-22 03:43:43 +01:00
eceba55126 no need to use the getter here
Change-Id: I5bbec2c06a641729194ceee3882b88e7372d41a9
2014-03-22 03:43:42 +01:00
926435ef5a added editable testers to enhanced table protection
Change-Id: If535d92dada1e8a539af9aa105aa2f16aed629e9
2014-03-22 01:06:08 +01:00
0536356202 copy-construct maEnhancedProtection in ScTableProtectionImpl
Change-Id: Ia1f7415b853f9e5ac585f89cbc938c2464c33fe5
2014-03-21 22:21:58 +01:00
4d9ccf41db update enhanced protection ranges
Change-Id: I15eb63da7123f8c2bf9ae1b77fdd32289dba3636
2014-03-21 15:21:58 +01:00
e0d936ef7b More code that's specific to OpenCL kernel pre-compilation.
Change-Id: I82474c48924aca36d9fde468081fb2457a153ac6
2014-03-20 10:14:03 -04:00
5d4f525da7 Disable kernel pre-compilation for now.
Change-Id: I8ba765a4d89618f301572c5fd9931f86d87af10d
2014-03-20 09:54:57 -04:00
6daff4ed35 range list might be nil, who knows
Change-Id: Iee5554f1b51db0f6dc22ccbed743ae431bb895f6
2014-03-20 13:03:33 +01:00
9cee6a4563 added ScEnhancedProtection to ScTableProtection
Change-Id: Id6a444bd01873e30ea1522aaf3b951f4d5adc261
2014-03-20 13:03:33 +01:00
a8c9edffd4 coverity#707994 Uninitialized pointer field
Change-Id: I667f93be72bd5d6cc68725b7cb5d97e30d8df521
2014-03-19 15:37:58 +00:00
71c88f02a0 sc: prefer passing OUString by reference
Change-Id: I85e8823e872bf53182ce90576225e462edb1930a
2014-03-17 13:30:50 +02:00
83ee6b640e Use listener's listening range when re-activating area listeners.
Otherwise listeners may end up listening to larger areas than their original
listening areas after the relocation.

Change-Id: I12a7f49aec1c78611db5c31ba2d18574e91a5416
2014-03-15 15:33:38 -04:00