Commit Graph

1113 Commits

Author SHA1 Message Date
97a5ba4a71 remove comments why a file gets included
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
07b9e2fade coverity#1202951 Uninitialized scalar field
Change-Id: I309ea6c881ffb6902750ed3cb4fba1c4bc8e6975
2014-04-16 11:23:10 +01:00
1bfa21f864 coverity#1202952 Uninitialized scalar field
Change-Id: I83d861fa03afa6e6b6adcd5ca340c28ef8c6cfdf
2014-04-16 11:23:10 +01:00
1531b523bf Clean up function declarations and some unused functions
Change-Id: I7a2b5970fd0ab2059b5f5b0100a049e04ba54ee3
2014-04-14 17:55:32 +02:00
0fb30c1e79 typo: misformed -> malformed 2014-04-14 12:32:21 +02:00
59da9b507d typo: ddjust -> adjust 2014-04-14 12:32:20 +02:00
2617208832 typo: referenzed -> referenced 2014-04-14 12:32:19 +02:00
e4309eb87d typo: adjustement -> adjustment 2014-04-14 12:32:19 +02:00
4c2c4e36ed typo: styte -> style 2014-04-14 12:32:18 +02:00
fbd23c2e73 typo: currect -> correct 2014-04-14 12:32:17 +02:00
68ae78c3c2 typo: objectes -> objects 2014-04-14 12:32:16 +02:00
2a7f68c776 typo: deppending -> depending 2014-04-14 12:32:06 +02:00
f75aa26620 typo: hierarchie -> hierarchy 2014-04-14 12:32:05 +02:00
cb1384b324 cp#1000054: Avoid crashing.
Change-Id: Iedafa35cfedce1d56468774fcb6bbfa8e42612df
2014-04-04 12:10:01 +05:30
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
f754176e0f coverity#1194898 Logically dead code
Change-Id: Iceef129ed11ab4551008eedf765ec0fe5a72c09a
2014-03-29 21:15:22 +00:00
b3530c2c3e coverity#1194891 Copy-paste error
Change-Id: I79c5587725850fc14a54f827b931959fbadaf566
2014-03-29 21:01:47 +00:00
ae00e71afd Bin rest of DBG_WARNING[123]
Change-Id: Iaaf36d012e353f73f083c9c0ebbbb6d0953b16c8
2014-03-28 16:52:36 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
ca276d55ea coverity#982466 Unchecked dynamic_cast
Change-Id: I6016ab4ffd2712d62cf3a8136a7d292f06abc8dd
2014-03-25 17:03:49 +00:00
95ff4bb714 coverity#1103725 Dereference before null check
Change-Id: Ie09af4913d3ac7681a7328c43595d01a98050a07
2014-03-22 17:10:10 +00:00
ac01de882d sfx2: sal_Bool->bool
Change-Id: I87c5a180566e9da185c2992844e6522e82c17747
2014-03-18 11:27:38 +02:00
cc2700245d sd: prefer passing OUString by reference
Change-Id: Ide21e1f51284fb2d4c7aaaa358417c6080b2fdde
2014-03-17 13:30:51 +02:00
5fe7ecc04f sfx2: sal_Bool->bool
Change-Id: I56a50ee4a169c8f82c830ebf498f7ead1335f0b5
2014-03-14 07:50:34 +02:00
13bc4094da svx: sal_Bool->bool
Change-Id: I673d022c01b7d076120c026b236a37735b5043b0
2014-03-14 07:50:32 +02:00
cecd77cb94 warning C4702: unreachable code
Change-Id: Ie5fe1348ed325b9de4af9e17846470fdc31067d7
2014-03-11 17:26:42 +01:00
0c17ccc493 fdo#30770 - Speed up xslx import
Conflicts:
	include/svl/style.hxx

Change-Id: Ie3d855923c651b6e05c0054c8e30155218279045
Reviewed-on: https://gerrit.libreoffice.org/8485
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-11 08:54:37 -05:00
6c97bc4717 svx: sal_Bool->bool
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-11 08:18:24 +02:00
d1bffe3596 svx: sal_Bool->bool
Change-Id: I64d9c1bbe6ed85108783bf6a97329fcdc167ca62
2014-03-11 08:18:24 +02:00
e955433c35 Use SfxStyleSheetIterator to iterate over style sheets in sd/stlsheet.cxx
It is not possible to access n#708518. We must hope that this
is not a regression

Change-Id: I4500d72cc7d6fc488fb015aa8b7907238fa09ac0
Reviewed-on: https://gerrit.libreoffice.org/8484
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-10 12:10:15 -05:00
4025168125 Use SfxStyleSheetIterator to iterate over SfxStyles in sd/stlfamily.cxx
Change-Id: I535b47de0fb4e66dc4b02d4c75b6631eb7d87ed4
Reviewed-on: https://gerrit.libreoffice.org/8482
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-10 11:17:26 -05:00
12aab9c087 coverity#735831 Dereference after null check
Change-Id: Ic41ed1f547a42668b17ec0c0d35a7cf2054c509c
2014-03-07 12:19:25 +00:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
ded5965ce8 editeng: sal_Bool->bool
Change-Id: I51b4ae54c2c440d38879439f74d4fea39d243004
2014-03-03 08:59:38 +02:00
7c8d2e2b6d coverity#735830 Dereference after null check
Change-Id: I62342173f01a593fe245ce897f712b9011926620
2014-03-02 20:08:21 +00:00
51c4430287 coverity#704732 Dereference after null check
Change-Id: Ida02c1d9f0bc35d115f3762d5c360231ab800b23
2014-03-02 20:08:20 +00:00
c521f07208 editeng: sal_Bool->bool
Change-Id: I7da10ad3ba8017d64c723b53795348edf0e7dd6d
2014-02-27 12:30:30 +02:00
57779aa019 editeng: sal_Bool->bool
Change-Id: Id4174904487fc153d8e80471da7c829c52092f78
2014-02-27 12:30:26 +02:00
ef16d954c2 editeng: sal_Bool->bool
Change-Id: Ic3d9fe45d3242d3da147067d3c388e9d7305ee61
2014-02-27 12:30:25 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
2ef9df8aee Remove visual noise from sd
Change-Id: I0957cabd66ddc4e25c7e6ff54ec2a555eda0792c
Reviewed-on: https://gerrit.libreoffice.org/8306
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 06:53:03 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
32ef676504 editeng: sal_Bool->bool
Change-Id: I1b215ef78bcade675a2f80def0d6d5afe0ff3d2c
2014-02-21 12:19:23 +02:00
4692d28e90 sal_Bool->bool
Change-Id: I83a9267cc461c2921b5da04a1122539ba0ac7d2d
2014-02-21 12:19:19 +02:00
5c3a6d383e callcatcher: update unused code
Change-Id: Ie4df15ab292df51274d983d31ce8e21e0549de81
2014-02-21 09:05:21 +00:00
dbfc495a9a Add config option used when we try to link one huge object file.
In theory, it should not be used, we use it now to mark duplicated
symbols from sdi slots as weak. See idl/source/objects/types.cxx.

Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
2014-02-21 07:52:24 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00