Commit Graph

965 Commits

Author SHA1 Message Date
ef141bb147 Do not drop existing LD_LIBRARY_PATH
Change-Id: I5b3599596dc40d1f88c075257c466b56ed73e795
2014-04-22 18:21:53 +02:00
f61cdf6fa8 fdo#71217 PDF Import: Fix importing of JPEG images
Change-Id: Ic0902a3f9340d2d05be05d13d98f168879b4c3e3
Reviewed-on: https://gerrit.libreoffice.org/9120
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-22 16:08:01 +00:00
16b81b0dbf Fix order of CPPUNIT_ASSERT_EQUAL arguments
Change-Id: Ib341ed33e98c31e296bb5ee6bff5789cf2459113
2014-04-22 17:21:42 +02:00
efaa53bc98 fdo#69051 fdo#72028 PDF Import: text fixes
1. Set font size not only on text span, but also on text frame.
2. Some copy-paste from Draw import code to Writer import code:
2.1. Set frame's auto-size properties.
2.2. Set correctly line joins and caps.

Change-Id: I6beecfb50aa7f45d20cc3cb3740e415172394638
Reviewed-on: https://gerrit.libreoffice.org/9091
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-18 09:20:49 +00:00
42dd561542 Related: rhbz#1088625 PresenterPaintManager seen as NULL
Change-Id: I3b7ba51d48ebc5f9304f6125de0595d41d50ad4d
2014-04-18 09:47:57 +01:00
c79a5f87b1 remove executable bit
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
2014-04-17 15:11:14 +02:00
1635a70e31 typo: diposed -> disposed 2014-04-14 12:32:46 +02:00
8a3eeff238 Clean up function declarations and some unused functions
Change-Id: I80d15f503bb5714340c051cc1c4890a445e44d56
2014-04-13 23:50:17 +02:00
54b8eb252a fdo#35064 PDF Import: Add support for simple text scaling
Change-Id: I81ff611f5f326c7ef97a75011cec4f4144d2cca4
Reviewed-on: https://gerrit.libreoffice.org/8916
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-11 11:13:52 +00:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
a20e145cf9 fdo#45001 fdo#77105 PDF Import: rotated text fixes
1. Fix 180 degrees text rotation;
2. Make rotated text fully editable.

Change-Id: Ie937f29031bbd0146207ce83678db351b65d2f8d
Reviewed-on: https://gerrit.libreoffice.org/8890
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-08 14:50:13 +00:00
453ee351f3 fdo#43157 : clean up more OSL_POSTCOND
Change-Id: Iaca31b4e12c258b762b3d88fbad0fb08b4f1fc16
Reviewed-on: https://gerrit.libreoffice.org/8832
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-04 07:23:43 -05:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
2498e4725e fdo#49431 PDF Import: Improve line and space detection algorithm
Change-Id: Ia0d53e90f49fa020e0738e295a4584254e2b474e
Reviewed-on: https://gerrit.libreoffice.org/8800
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-31 15:19:06 +00:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
7fce0e3fe7 coverity#982469 Unchecked dynamic_cast
Change-Id: I6fa95fbd64f69cca1837b57f9c632f0bdbaec1d0
2014-03-25 17:03:50 +00:00
356263dcdb coverity#982468 Unchecked dynamic_cast
Change-Id: Ie98fa4199ebfa96495bdb7fa4582b09926fac8f1
2014-03-25 17:03:49 +00:00
53cbca6ee1 fdo#44710 PDF Import: Correction of position of rotated text
Change-Id: Ie53b25a6cec88c07a317c50bd0965282fac64ff0
Reviewed-on: https://gerrit.libreoffice.org/8725
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-23 11:42:39 +00:00
86a32589e9 Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
54b4add666 Remove unused HelpCloseListener
Change-Id: I9040a1262b31f8d0f19594b6efcf12b2c38be7be
2014-03-12 16:24:43 +01:00
7963d2b0f6 fdo#40513 PDF Import: Hack: Replace incorrect values of font's ascent property
Change-Id: Ib7bd6e15fff5213b5d935c6f03f2c65ea3f6ca50
Reviewed-on: https://gerrit.libreoffice.org/8416
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03 09:20:24 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e6bd9d718d Remove visual noise from sdext
Change-Id: I792249b9e92db9af4daee0bd835e04044d29bca5
Reviewed-on: https://gerrit.libreoffice.org/8308
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 08:19:03 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
0ac8d57b0c coverity#983817 Uncaught exception
Change-Id: I91883489d9557c5e3779c6b16bf377c1b95e49da
2014-02-23 03:28:23 +00:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
7f8e774119 fdo#75195 PDF import: Revert commit 128adf7e5c06fff378c8d72b44ec4be1e462984f
Change-Id: Icb03088809e57a388317f98046f9de3197772a41
Reviewed-on: https://gerrit.libreoffice.org/8126
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 14:03:34 +00:00
97a185d8b9 cid#983380 Dereference before null check
Change-Id: I9504738a5291b85362a80e630d9e413825fa6572
2014-02-20 09:31:11 +02:00
988b695bcc fdo#37246 PDF Import: Color to string conversion fix
Change-Id: I5ec9f0246f6c2d1b12a389906d04133b2f5a6f9f
Reviewed-on: https://gerrit.libreoffice.org/8106
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-18 20:19:17 +00:00
9616b786ad fdo#45003 PDF import: Implementing linejoin and linecap properties
Change-Id: I4b09cd7b970d5aca4500ae333edef0e4c2f618b9
Reviewed-on: https://gerrit.libreoffice.org/8009
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-12 10:48:51 +00:00
4415f6b7b1 cppcheck: duplicateExpression
See http://nabble.documentfoundation.org/Cppcheck-Same-expression-on-both-sides-of-in-PresenterPaneBorderManager-cxx-sdext-td4094873.html

Change-Id: I7dbb8d0254ca77127250d6ca02de7b945ef8051e
2014-02-08 09:09:02 +01:00
9db3b5585c fdo#35143 PDF import: Reimplementation of whitespace detection function
Change-Id: I5b230aaebf72b70bbb7e206414a5ac0e01f01f86
Reviewed-on: https://gerrit.libreoffice.org/7564
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04 15:13:15 +00:00
32b8c5c4a9 fdo#54938 Convert basctl, mysqlc, sdext, svgio, writerp. to cppu::supportsSer.
Change-Id: I60128dbb5bf83f25eea847fe655d7126c9077414
Reviewed-on: https://gerrit.libreoffice.org/7756
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-02 18:53:03 +00:00
e7d1a81ee3 bool improvements
Change-Id: I969de97522ae2e3f8693e82a500a73e28451ef77
2014-01-28 20:26:22 +01:00
a3f32769fc Fix bogus mass-conversion equalsAsciiL -> startsWith
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.

Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-21 15:54:52 +01:00
7cc255c9df Use proper bool operations
Change-Id: If9d439faba5a02b50152dfa1090b9eb1afa0fc18
2014-01-10 17:11:48 +01:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
6e06bd6cb5 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I8dfbbb36cca3cf71c8d347b248dd206c447db6d2
Reviewed-on: https://gerrit.libreoffice.org/7136
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-18 15:53:50 +00:00
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
417c85bf58 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc
Reviewed-on: https://gerrit.libreoffice.org/7104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-17 11:57:04 +00:00
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
2ac31b06ae Unnecessary use of OUString constructor inside OUStringBuffer constructor
Convert code like:
    OUStringBuffer sVal(OUString("0x"));
to:
    OUStringBuffer sVal("0x");

Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
2013-12-17 11:49:05 +02:00
8548abbac5 Remove unnecessary use of OUString constructor in OUStringBuffer::append calls
Convert code like
  aStrBuffer.append(OUString(" AS "));
to
  aStrBuffer.append(" AS ");

Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
2013-12-17 11:49:04 +02:00
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
de45a49273 sdext: clean up some pointless #ifdefs
Change-Id: Ic23c0ccc45d7a98b3581feab43fc4c8c8aef9013
2013-12-05 13:00:26 +01:00
3b2f956ba6 Drop duplicate #include
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
2013-12-02 01:02:06 +09:00
05d2994c13 Further XCanvas != XBitmapCanvas cleanup.
It seems I missed a few places in
21ec9beae29b19b8ec6f0a16fd0e708e4f210208, getting that straight
now hopefully.

Change-Id: I34fc8df2d1ee65bef0639b3de9487ff311bed89a
2013-11-29 18:26:48 +01:00
1b10205c2c Fix fdo#71527 no unguarded ptr dereference here.
This is the real problem - mxPane can be validly NULL.

Change-Id: Ie8d055db9bfb68cb9031fa970518343f5aec6619
2013-11-29 18:26:28 +01:00
b807b2d929 Revert "Resolves: fdo#71527 don't crash in presenter console"
This reverts commit bae01385c895a100b5371879889e606927cff877.

Change-Id: Id149bae0904fd6c2120209d69490d0b257ac3f64
2013-11-29 18:26:17 +01:00