Commit Graph

10266 Commits

Author SHA1 Message Date
aa39d21107 clean up hrc files
Change-Id: I76756fe539589d2ab086fd1f1aeec50a9f39af37
2014-04-22 13:03:18 +02:00
40064f479b clean up hrc files
and remove some unused stuff

Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
2014-04-22 13:03:17 +02:00
9d2977d0a3 remove some more bloat
Change-Id: I7b6c04d99c41360ff49be774afcb4447a829d31c
2014-04-21 09:39:35 +02:00
cadf6cc31f adjust output file extension when exporting (bnc#870581)
If foo.odt is open, 'foo.odt' is the file name passed to the file dialog
for File->Export to PDF (simply because it's the document name).  If automatic
file extension is enabled, the file dialog will fix this to the PDF file type,
but if disabled, the default filename will remain foo.odt, possibly overwriting
the source file if the user is foolish enough to confirm without checking.

Change-Id: I46504630b5f4e489d5a0cedf0b2b358305763722
2014-04-20 14:33:05 +02:00
29d5ce2d88 sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too.
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
2014-04-18 22:51:06 +02:00
b731d71c67 sfx2: Move InitInterface_Impl() method out of SFX_IMPL_INTERFACE.
SFX_IMPL_INTERFACE previously looked like a function; where in fact it is
several methods defined at once, and only the last one has a body.

This is extremely confusing and hard to read; let's kill that nonsense.

Change-Id: Ia4ae22eb58b1260c9c827c894f5345693bad49e7
2014-04-18 22:51:06 +02:00
8c3ab6093a sfx2: Kill SFX_STATUSBAR_REGISTRATION macro.
Change-Id: Iff0ffdb955892117a767e1f31c1f854a93feb560
2014-04-18 22:51:06 +02:00
f4d61eca61 sfx2: Kill SFX_CHILDWINDOW_REGISTRATION macro.
Change-Id: Icd56e0cee1ce0283e8a1cbaafc81ecca25469185
2014-04-18 22:51:04 +02:00
7acb27081c sfx2: Kill SFX_OBJECTBAR_REGISTRATION macro.
Change-Id: Ic80e9bebba8c7e76a0400769a2f9d75301227194
2014-04-18 22:49:27 +02:00
62256ea10a svidl: Unwind SFX_ARGUMENT macro, and kill it.
Change-Id: I61334b687c251ccc90f125e8bf95f8689028b8c3
2014-04-18 22:49:26 +02:00
635823696f coverity#1202785 Division or modulo by zero
Change-Id: I5ede52be101a7603d4edad30b7a1f8ee0fc4b07d
2014-04-18 12:21:43 +01:00
12c0d40f82 coverity#1202784 Division or modulo by zero
Change-Id: I982b72abd92584b9ed97de593c17f2cf0b8b3667
2014-04-18 12:21:43 +01:00
728ec86062 Typo: s/cant/can't/
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-18 00:30:35 +03:00
629cc605a4 Intermediate commit of hacking on --disable-database-connectivity
Add HAVE_FEATURE_DBCONNECTIVITY to <config_features.h> instead of
using (or not, more likely) -DDISABLE_DBCONNECTIVITY.

The plan is still that database connectivity would be disabled always
for the non-desktop platforms, and otherwise disabling it would be a
configure option.

But, still lots to do; the TiledLibreOffice iOS test app gets tons of
undefineds when linking if I actually try to disable the database
connectivity.

Change-Id: If1e4b55faa1514cd55dec5fc5487a30d689739ac
2014-04-18 00:04:15 +03:00
262aa2c2e5 More generic way to disable avmedia
Introduce a configure option --disable-avmedia. For non-desktop,
avmedia is always disabled (for now), and for desktop enabled by
default. Add AVMEDIA to BUILD_TYPE when enabled. Don't build avmedia
when disabled. Add HAVE_FEATURE_AVMEDIA to <config_features.h>. Bypass
avmedia-related code when disabled.

Change-Id: I919c6e199bff87d9f142d55dff6373f0ed217f39
2014-04-17 22:18:02 +03:00
bcbf14f607 coverity#1202773 Logically dead code
I can't find any evidence that it was possible to be
other than true/false here before sal_Bool got converted
to bool

Change-Id: Ieacc780b5f5abce0fe166337a50284bd5e0aef45
2014-04-16 16:41:58 +01:00
5e651d4084 coverity#1202948 Uninitialized pointer field
Change-Id: I2764b1f9c3d50cf7ff7bd2c552a3dec93509b245
2014-04-16 11:23:13 +01:00
4a277e39db coverity#1202947 Uninitialized scalar field
Change-Id: Ieee8f9eba25f17ba789d3be5a006e056108c386b
2014-04-16 11:23:10 +01:00
717aa1ac75 fdo#72287 Scroll automatically to show selected item when keyboard used.
806919adf9c9bafbaba92c2d2ab35d2e2f9863f8 added finer-grained scrolling using
the scrollbar / scrollwheel, but inadvertently prevents the display from scrolling
when an item is selected that is currently offscreen (e.g. by using the down-arrow
button on the keyboard).

Change-Id: Iaa3a7dc6d214741d37cf4ec78c00ed0034ed1e42
2014-04-15 19:55:57 +01:00
8fbbd1bd98 fix hacked bool in SfxDispatcher::SetSlotFilter
The bEnable flag was being passed an extra value.
Make this explicit now using an enum.

Change-Id: I292aca44e8592c9f3c1497c24c41140c8c3b5452
2014-04-15 09:02:32 +02:00
b6d7773a12 typo: artifical -> artificial 2014-04-14 12:32:42 +02:00
13943b18b7 typo: controlls -> controls 2014-04-14 12:32:29 +02:00
3bd26180c6 typo: nummer -> number 2014-04-14 12:32:24 +02:00
5e378e331e typo: titel -> title 2014-04-14 12:32:23 +02:00
4e0129e799 coverity#708157 Uninitialized scalar field
Change-Id: I9d798c8b6472241dc7d16e3d7b52653ad0d76654
2014-04-11 11:21:12 +01:00
39ae696f1e unused bInAppBASIC member
Change-Id: If7adfb573e4a7605953a2561fd280a5bc22b02fd
2014-04-11 11:21:12 +01:00
04148c6fbd coverity#738831 Uninitialized pointer field
Change-Id: I9de07f4fe8b9919ec2a7e83019b5131647e552c1
2014-04-11 11:21:11 +01:00
578cd010f5 Use valid UNOIDL identifiers in css.frame.Status.ItemState
These are present since OOo 2.0, but are unpublished and appear to be rarely
used, so changing them is hopefully OK.

Change-Id: I144eceb074cfdd91777f4c940cbfbc0dd73d4347
2014-04-11 08:41:09 +02:00
058cfa72dc Fix fdo#71423 - crash while editing Impress tables.
Band-aid fix for this nasty crasher, seems sometimes the
family item is not found.

Change-Id: I7f78d59cbf2c9595ad512fa7a78370629924cd06
2014-04-10 19:43:23 +02:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
31911865e5 DownLoad -> Download.
Change-Id: Ia1729f570cc80a0375532da6478de9d58518556e
2014-04-10 15:07:53 +02:00
1d25e1de0b Clean up function declarations and some unused functions
Change-Id: I9d6e9df0b686c61597aaa0e194ab321445671a20
2014-04-10 09:31:46 +02:00
b818619266 Do not leak SfxDialogExecutor_Impl
Change-Id: Ife3e8e4b339b3e2cba3bc81e14f616d75c4f5ed0
2014-04-09 17:51:41 +02:00
b43ffeb828 Remove unused MacroOrganizer
Change-Id: I637e84ae7fa82f687eb3f05b3e24e236f0ba8e3c
2014-04-09 16:44:20 +02:00
bf621a2e28 Remove unused MakeVariable
...unused ever since at least fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial
import."

Change-Id: I6ec792b68ce6b13b1cf074d9719a23daf3356e66
2014-04-09 16:13:32 +02:00
8141b349dc Remove always-null SvFileObject::pDownLoadData
...left over after 66e4540041f09b4e779d27190f0925479f74103b "aDataAvailableLink
in SfxMedium was never called."

Change-Id: If2cfcc27f2b26ea3c950c2da1c673df940d94773
2014-04-09 15:37:23 +02:00
54f2d50360 loplugin:literaltoboolconversion
Change-Id: I7a312fb31774e198b71e5f733a2932d6b9607f57
2014-04-08 21:11:15 +02:00
005976286b coverity#704796 Dereference after null check
Change-Id: I97aaaa38620f162a3a4d08bb66690815beb7880e
2014-04-08 16:26:28 +01:00
53f03a3c83 coverity#704792 Dereference after null check
Change-Id: Ie6f3174266dfa42a1eff81df45fc408656d4fbd9
2014-04-08 16:26:28 +01:00
7096a32e16 coverity#704791 Dereference after null check
Change-Id: I7e973ac9b91ab112952f56ce290c07c9fc5670b2
2014-04-08 16:26:28 +01:00
ceebfc0436 coverity#704790 Dereference after null check
Change-Id: I276b404405b9717a03d43a24c6ffecd5c6553969
2014-04-08 16:26:28 +01:00
9660716fb9 WaE: implicit conversion of literal of type 'int' to 'bool'
Change-Id: I501dcb0ca3465e5e07564a7156a0dfa3f2767af5
2014-04-08 11:38:52 +03:00
b19e943c50 coverity#708175 Uninitialized scalar field
Change-Id: I235f46bf9b0e672ddad16d9766a09f5c7c88a3e0
2014-04-08 09:18:39 +01:00
380d4600d7 use TriState instead of sal_Bool as there's three possibilities
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-08 09:18:33 +01:00
21c3f6ac12 WaE: -Werror=uninitialized
Change-Id: I4c2eb1e323505c6298203cb89769dc693f4e63bb
2014-04-08 09:18:32 +01:00
53a0914c5c Bin empty @seealso, @param, @return etc metacomments
Change-Id: I1590c20c4080578f5b528f4d6d43749e4e939fde
2014-04-07 19:56:50 +03:00
d913a5a9df untangle the bFmt == 2 hack
Firstly, IsFormat is unused so there's no "escape" of
bFmt back into the outside world.

Then bFmt has two purposes.

Purpose 1 is 'not be a format dialog, be a format dialog, be a format dialog but hide standard button'

so, lets just add an explicit "Hide standard button" method and call
it in the (apparently) one place where it's necessary.

Purpose 2 is to flag that "BaseFmtHdl" was called from clicking
the "Standard" button at which point its set to 2.

SfxTabDialog::Init_Impl had...

"
  // bFmt = temporary Flag passed on in the Constructor(),
  // if bFmt == 2, then also sal_True,
  // additional suppression of the standard button,
  // after the Initializing set to sal_True again
  if ( bFmtFlag != 2 )
      m_pBaseFmtBtn->Show();
  else
      bFmtFlag = sal_True;
"

but the variable acted on is bFmtFlag a copy of bFmt, and is never read again
after that line, so setting it to sal_True is meaningless. The comment suggests
that the intent is to reset bFmt to true if it was 2 during initialization,
which fits with the later use of bFmt == 2 to indicate that the standard button was
clicked, i.e. reset bFmt back to its standard value.

So make bFmt a simple toggle of dialog as a format dialog or not, add a way
to remove the standard button and add a second variable to indicate the standard
button got pressed.

Change-Id: I98a441f5f314845abe243e05b6d92fd71d7b0b04
2014-04-07 13:47:02 +01:00
74fdda0cd4 sfx2: sal_Bool->bool
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
2014-04-07 13:53:50 +02:00
8f6c55a839 Replace SV_DECL/IMPL_REF macros with SvRef template
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-07 12:38:27 +02:00
56b82942e8 WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'
Change-Id: Ib477afa1740f14832f49ce85822410b2e9db8d46
2014-04-06 09:19:42 +03:00