29d5ce2d88
sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too.
...
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
2014-04-18 22:51:06 +02:00
12c0d40f82
coverity#1202784 Division or modulo by zero
...
Change-Id: I982b72abd92584b9ed97de593c17f2cf0b8b3667
2014-04-18 12:21:43 +01:00
717aa1ac75
fdo#72287 Scroll automatically to show selected item when keyboard used.
...
806919adf9c9bafbaba92c2d2ab35d2e2f9863f8 added finer-grained scrolling using
the scrollbar / scrollwheel, but inadvertently prevents the display from scrolling
when an item is selected that is currently offscreen (e.g. by using the down-arrow
button on the keyboard).
Change-Id: Iaa3a7dc6d214741d37cf4ec78c00ed0034ed1e42
2014-04-15 19:55:57 +01:00
8fbbd1bd98
fix hacked bool in SfxDispatcher::SetSlotFilter
...
The bEnable flag was being passed an extra value.
Make this explicit now using an enum.
Change-Id: I292aca44e8592c9f3c1497c24c41140c8c3b5452
2014-04-15 09:02:32 +02:00
4e0129e799
coverity#708157 Uninitialized scalar field
...
Change-Id: I9d798c8b6472241dc7d16e3d7b52653ad0d76654
2014-04-11 11:21:12 +01:00
39ae696f1e
unused bInAppBASIC member
...
Change-Id: If7adfb573e4a7605953a2561fd280a5bc22b02fd
2014-04-11 11:21:12 +01:00
578cd010f5
Use valid UNOIDL identifiers in css.frame.Status.ItemState
...
These are present since OOo 2.0, but are unpublished and appear to be rarely
used, so changing them is hopefully OK.
Change-Id: I144eceb074cfdd91777f4c940cbfbc0dd73d4347
2014-04-11 08:41:09 +02:00
1d25e1de0b
Clean up function declarations and some unused functions
...
Change-Id: I9d6e9df0b686c61597aaa0e194ab321445671a20
2014-04-10 09:31:46 +02:00
7096a32e16
coverity#704791 Dereference after null check
...
Change-Id: I7e973ac9b91ab112952f56ce290c07c9fc5670b2
2014-04-08 16:26:28 +01:00
ceebfc0436
coverity#704790 Dereference after null check
...
Change-Id: I276b404405b9717a03d43a24c6ffecd5c6553969
2014-04-08 16:26:28 +01:00
74fdda0cd4
sfx2: sal_Bool->bool
...
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
2014-04-07 13:53:50 +02:00
a20b62dac8
svl/eitem.hxx: sal_Bool->bool
...
Change-Id: I45dfd2429a490af3cc80f51340e0c05a91425668
2014-04-04 13:44:18 +02:00
2cf50102a0
sfx2/objface.xx: sal_Bool->bool
...
Change-Id: I1227c958d58903dc114a4e4173fb2714b2ec33f2
2014-04-03 09:17:49 +02:00
e3495f475e
GraphicFilter::LoadGraphic: SAL_WARN -> SAL_INFO
...
Only the caller can decide if trying to load a graphic is really a
problem, e.g. in case no persona is configured, then loading its header
is OK.
Change-Id: I7286b7d907940fa3a80f6256cd5264cbd5718fb8
2014-04-02 09:43:16 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
dcc8c9173d
SAL_WARN -> SAL_INFO in SfxDispatcher::_FillState()
...
These warnings were hidden so far, don't make them noise till one starts
to actually fix them.
Change-Id: I142726d54fbc20c1c5591a5b20d26356986ba4b8
2014-03-31 16:24:01 +02:00
c1a1ec5391
coverity#1194926 Dereference before null check
...
Change-Id: I1825de227b760624faaa68a1de2d3ecd5b7657a5
2014-03-31 09:42:15 +01:00
6ef2df7b9b
Remove remaining DBG_NAME* uses
...
...that had been used for DBG_CTOR, DBG_PROF, etc.
Change-Id: I8eac38e24b7110511feb7813aaf5a20ab82bdbe0
2014-03-28 17:26:09 +01:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
671f7130a3
Remove legacy DBG_PROFSART/STOP calls
...
...probably better done with callgrind, if still relevant at all.
Change-Id: I15069df4e2f271b0c240231f35af2e664a02c296
2014-03-25 18:49:17 +01:00
9759de7a88
Adapt to sal/log.hxx
...
Change-Id: I7afe7bfe295dfa20206fdb6bc10da8ea31adb47e
2014-03-25 16:17:08 +01:00
93d7c75305
Adapt to sal/log.hxx
...
Change-Id: I96786bcab1205d212926af6c7c6afbf88bfe1453
2014-03-25 10:00:10 +01:00
cafdef8109
svtools: sal_Bool->bool
...
Change-Id: I56072620f9ea28833e1590a7fff7d71ed11fc34c
2014-03-24 08:12:08 +02:00
f516cff220
Avoid possible resource leaks by boost::scoped_array
...
Change-Id: I7b72c5680d5665b3f1f720f50a2d3ea6fc0c3e39
2014-03-24 03:10:18 +09:00
06d44ce1d6
coverity#708156 Uninitialized scalar field
...
Change-Id: I0ef0047684bf97453c7f0bd958aee73ec5af26a6
2014-03-22 20:46:00 +00:00
893e6f6ac6
bUseTarget is never read
...
Change-Id: I1a21cfd62de2e188c93453f7eebb4d322010de3a
2014-03-22 20:45:09 +00:00
16752a8a77
sfx2: sal_Bool->bool
...
Change-Id: Ief810c49b821e2e60ee2c8b14187dd8d7d81c461
2014-03-19 09:21:24 +02:00
c3e3f46657
sfx2: sal_Bool->bool
...
Change-Id: I375a72c34e46778385a9fdc24c9ebd0f0a3f3c9b
2014-03-18 11:27:39 +02:00
fb77ab1dc2
sfx2: sal_Bool->bool
...
Change-Id: Ib2a02c7e05e48657b9745bcccc8f8f626daaef2d
2014-03-18 11:27:38 +02:00
a8f721ff96
sfx2: sal_Bool->bool
...
Change-Id: I626371bac4fbd9c6a2cdc5a57a3022f8b6ac55b2
2014-03-14 07:50:34 +02:00
5fe7ecc04f
sfx2: sal_Bool->bool
...
Change-Id: I56a50ee4a169c8f82c830ebf498f7ead1335f0b5
2014-03-14 07:50:34 +02:00
c2324940d3
sfx2: sal_Bool->bool
...
Change-Id: If960d94f867a1988ace83975cf16441c6f8866b0
2014-03-14 07:50:33 +02:00
0dc38bdde0
sfx2,svl: prefer passing OUString and OString by reference
...
Change-Id: I9833265f6e635a057cea2c4a945cc73809b1e2ef
2014-03-13 11:05:53 +02:00
f02cda1680
coverity#735847 Dereference after null check
...
Change-Id: I564d00d279d0b1cfee4eead4b9bc9b6e98a3b0f2
2014-03-07 12:19:24 +00:00
3952988da6
Fix deselection problems of template view
...
deselectItems() were added to make recent docs
view work, but it is unneccessary to
affect template view too.
Change-Id: I0c805774321939991e308e9c8c669604e81dbad5
2014-03-07 10:24:26 +01:00
42a6e74fc3
remove unused code in SfxBindings
...
SfxBindings::GetSlot(unsigned short)
SfxBindings::GetSystemWindow() const
Change-Id: Icc024abcde1394ade86d3f4e623e4030382d2b63
2014-03-05 09:17:50 +02:00
2e7807cb86
remove unused code SfxDispatcher::IsOnTop(SfxShell const&)
...
Change-Id: I107f732cb0f26bf0546e6cf6181b4236a6ad7b49
2014-03-05 09:17:50 +02:00
967c694cfe
remove unused code TemplateLocalView::HasUnfilteredItems(FILTER_APPLICATION)
...
Change-Id: Ia4e8c6139b20f2370219d9e7b72e6b3083301ba0
2014-03-05 09:17:46 +02:00
49d85c1536
remove unused code in ThumbnailView
...
ThumbnailView::DeselectItem(unsigned short)
ThumbnailView::GetItemText(unsigned short) const
ThumbnailView::SetColor(Color const&)
Change-Id: Ifed909b3c6b32e7e553bee29fbf989963c733e69
2014-03-05 09:17:46 +02:00
7ac4babfd6
SFX2 : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Change-Id: I35a9403da152ea2b637c0235d776c7789e2ef207
Reviewed-on: https://gerrit.libreoffice.org/8420
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-03-03 09:23:34 -06:00
9ee630ee01
remove unused code RecentDocsView::SetThumbnailSize(long)
...
Change-Id: I9a898fda8e494693f48d7611c07bd65e86c22bdf
2014-02-28 08:32:00 +02:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
c7c40687f6
Remove visual noise from sfx2
...
Change-Id: I0f556a386ce64d154b695c2a35f808c94b9f0b7a
Reviewed-on: https://gerrit.libreoffice.org/8310
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 08:12:10 -06:00
b8ebdae034
Yet another one undefined comparison of 'const' and a 'non-const' iterators (hope the last one)
...
Change-Id: Iefcd1f5561e5a8cac4152f16e72e8f628e9204a5
Reviewed-on: https://gerrit.libreoffice.org/8223
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-25 16:21:27 +00:00
f6cef562c0
remove unused method SfxBindings::GetDispatchProvider_Impl()
...
Change-Id: Ie2a04a2b5056bf607911f9705c06b74b9637d211
2014-02-25 15:16:59 +02:00
523fcec55d
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: I72b0e8b07bd7309a23d5635b7e0b7dbdc9c2c721
2014-02-25 11:15:06 +09:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
e8f8f24c84
vcl: sal_Bool -> bool
...
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
12f1faf7bf
svl: sal_Bool -> bool
...
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
