Commit Graph

1113 Commits

Author SHA1 Message Date
9ea483e8a9 svtools: valueset.cxx - use scoped_ptr and clean-up
Change-Id: I91528f55af39faccfe1bf95999ac29669ead0aad
2014-04-18 21:07:02 +02:00
6b6bf85661 Cleanup valueset.cxx
Change-Id: Ib0a27d8d3a3e974f73e7873ad8baae4721f6fb87
2014-04-18 21:07:01 +02:00
902cafe656 coverity#1202783 Division or modulo by zero
Change-Id: I183416ad3db39108e52c1e69b60fb547448b21a8
2014-04-18 12:21:43 +01:00
516a22afa5 coverity#704807 Dereference after null check
Change-Id: Ifbfdbc016cde790a2027a0036294b3be9e37a85c
2014-04-17 18:33:37 +01:00
cfddda092b sal_Bool to bool in SvtRulerAccessible
Change-Id: Ib5f451fadb9eedc49d6bded0cbd92cfbbde71bae
2014-04-15 09:02:32 +02:00
fa72a0e94d Remove unused code
Change-Id: Ifaab2aecec65ec6e81056e5fca430df8ca3af908
2014-04-09 10:15:47 +02:00
0d46e05cf2 coverity#704828 Explicit null dereferenced
Change-Id: I5e27241334cfeb4dffecbbf1d010abe94fbc52df
2014-04-04 20:58:27 +01:00
f19ca44a04 callcatcher: update unused code
Change-Id: I23ad8bcbef9a0ef17aaa5d401d111c40a6560ee2
2014-04-04 09:35:19 +01:00
aa16ca7326 Resolves: fdo#76905 long delay when changing font size from % to pt
Change-Id: I33d72b51536ab96653ccda64c6e058c497289327
2014-04-02 13:47:54 +01:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
2591ed293e coverity#984148 Uninitialized pointer field
Change-Id: I17a4a4e1c5aa1b5481e283f1c232e6483c135e84
2014-04-01 10:38:24 +01:00
856c749963 Kill FSYS_MAC which is for ancient non-OS X Mac
Change-Id: I51e91b97217507bcdca8c82f8a8683758d871185
2014-04-01 12:14:45 +03:00
018652591d coverity#982312 Logically dead code
Change-Id: I2b40ac902812ad27dc06bd20603414dff3358eef
2014-03-28 17:24:07 +00:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
c849d750eb svtools: sal_Bool->bool
Change-Id: I05dd992f332ab2f3dbcc65aed6dac909872168d4
2014-03-25 14:32:55 +02:00
2d3a1d2a46 svtools: sal_Bool->bool
Change-Id: I6c57a52b4fc3ecb993af4526fefcca352ad269b5
2014-03-25 14:32:55 +02:00
f5864e8ff4 svtools: sal_Bool->bool
Change-Id: Ia0280d3d4f2d5b8a93a37a93847951391e928028
2014-03-25 14:32:53 +02:00
1e46d2f607 coverity#735504 Logically dead code
Change-Id: Idb3b2e4fe3ab67c65324de9625807808e1355cee
2014-03-24 12:12:29 +00:00
f7074d8de5 svtools: sal_Bool->bool
Change-Id: I2044e6c1f15579b6051fad5d36fcfa8795f88953
2014-03-24 08:12:10 +02:00
7a679ee19c svtools: sal_Bool->bool
Change-Id: I35c9c1514c67860e61b6e2457ab4548d04a4d159
2014-03-24 08:12:10 +02:00
9604eb8758 svtools: sal_Bool->bool
Change-Id: I8f171f7f61ea06a79183e9bf9b15b8c35c98cc9b
2014-03-24 08:12:09 +02:00
b1de52241c svtools: sal_Bool->bool
Change-Id: Iaa489318f25107e91fc8133523fbd9d724493314
2014-03-24 08:12:08 +02:00
cafdef8109 svtools: sal_Bool->bool
Change-Id: I56072620f9ea28833e1590a7fff7d71ed11fc34c
2014-03-24 08:12:08 +02:00
402fffa1b4 Add dash-dot and dash-dot-dot line styles.
We need these for Excel interop.

Change-Id: I91450c1d205f28636edfb4392aa6ae5091b1d7b7
2014-03-19 00:28:16 -04:00
e1d99bc0d5 ToolbarMenu does not implement XStatusListener
Change-Id: Ia0195e794ac5e23905035738f0ab7e658c3bb92b
2014-03-14 17:57:25 +01:00
9a76d79dc4 coverity#708296 Uninitialized pointer field
Change-Id: I05b10b0b9812a79ea8c55e5af3bcde83f24e12cf
2014-03-13 14:03:28 +00:00
41776e53c5 svtools,svx: prefer passing OUString and OString by reference
Change-Id: Iceb2cbcda9d8ddb4ee00db9365c751e0e5d8b3a6
2014-03-13 13:13:38 +02:00
62fae8bda8 svtools: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I2534ad4a720dd5d13324ac6fb19b8676ae50ff4e
2014-03-10 17:39:58 +01:00
dc4746a25b coverity#708299 Uninitialized scalar field
Change-Id: I15b3c6d8a2af7be1fd8cada39c58ed706271f307
2014-03-09 21:20:11 +00:00
a3f0803059 coverity#704317 Logically dead code
Change-Id: I680efdff5be6a9f699b8954c11eddc027f972a76
2014-03-07 16:26:43 +00:00
4516e30053 crash indexing -1
Change-Id: Ia339bed9bad3b43ec1e4ea813646cab81cf3a619
2014-03-05 20:41:07 +00:00
160d289564 cast to the higher capacity type instead
Change-Id: I515f315c93dd19016dfdabdf9524606214f84891
2014-03-05 16:21:25 +01:00
9d4c3a2a21 WaE: comparison of integers of different signs
Change-Id: I936e7bdaf3a4236775add4982005b465f229eb78
2014-03-05 16:25:43 +02:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
0feaf45541 SVTOOLS : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: I83e39d69deaf2aa1c5ca455c92d070a2d33def3f
Reviewed-on: https://gerrit.libreoffice.org/8421
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03 09:19:11 -06:00
381f8a5673 sal_Bool -> bool in mostly vcl module
Conflicts:
	include/vcl/settings.hxx
	svtools/source/table/tablecontrol_impl.cxx
	sw/source/core/frmedt/fecopy.cxx
	vcl/inc/canvasbitmap.hxx
	vcl/inc/headless/svpframe.hxx
	vcl/inc/unx/salframe.h
	vcl/inc/win/salframe.h
	vcl/inc/win/salprn.h
	vcl/inc/win/salvd.h
	vcl/osx/DragSource.cxx
	vcl/osx/DragSource.hxx
	vcl/osx/DropTarget.cxx
	vcl/osx/DropTarget.hxx
	vcl/osx/OSXTransferable.cxx
	vcl/osx/OSXTransferable.hxx
	vcl/osx/clipboard.cxx
	vcl/osx/clipboard.hxx
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/canvasbitmaptest.cxx
	vcl/source/components/fontident.cxx
	vcl/source/control/edit.cxx
	vcl/source/control/spinfld.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/virdev.cxx
	vcl/source/helper/canvasbitmap.cxx
	vcl/source/window/dockwin.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/kde/UnxFilePicker.cxx
	vcl/unx/kde/UnxFilePicker.hxx
	vcl/unx/kde4/KDE4FilePicker.cxx
	vcl/unx/kde4/KDE4FilePicker.hxx
	vcl/unx/kde4/KDESalFrame.hxx

Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 03:19:47 -06:00
64977e5c2b remove unused code FontSizeBox::GetValue(unsigned short, FieldUnit)
Change-Id: I63df5364d69bf60e7a5ee2b5854b41ce27f10894
2014-02-28 08:32:04 +02:00
04539b9bba remove unused code Ruler::GetPageWidth()
Change-Id: I7a061b869a699771b321d7143559c5b9f48937c5
2014-02-27 10:27:34 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
bee1cc83ec Remove visual noise from svtools
Change-Id: I7c2b74a449fb20aae5bc643e24a22cf6f732136d
Reviewed-on: https://gerrit.libreoffice.org/8320
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:14:09 +00:00
83aa6d8180 Remove some temporaries around calls to SvNumberFormatter methods
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
2014-02-24 09:08:35 +01:00
c19cb642db Adapt to osl_atomic_inc-/decrement
Change-Id: I848873b07ab05cefdc755a8bf1301907fdfbc299
2014-02-24 08:08:00 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
c4a766db25 coverity#441203 Dereference after null check
Change-Id: I166e9ab8d3693568cc2b6a0ecd7d49532508116b
2014-02-23 03:28:22 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
d13545987a callcatcher: update unused code lists
Change-Id: Ie975f8a970eec63b593933ebb2394db76d537c51
2014-02-18 10:10:01 +00:00
0d3082dbf2 callcatcher: update unused code
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-12 13:03:50 +00:00
06d5616f65 svtools: add some missing locks in new code
Change-Id: I6f000fb0f205b437e4ff5238c8ede5735c403077
2014-02-11 12:52:22 +01:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00