Commit Graph

752 Commits

Author SHA1 Message Date
fa72a0e94d Remove unused code
Change-Id: Ifaab2aecec65ec6e81056e5fca430df8ca3af908
2014-04-09 10:15:47 +02:00
82925f1a21 Remove unused getCommandType
Change-Id: I76c9ea0740223b601440ca7c7122b814e777fca3
2014-04-03 15:36:43 +02:00
4a94fc286f clearFieldAssignment only used in AssigmentTransientData
Change-Id: Ic7d11a7ad3c643354e0bb2aaf20bda2c3e41dba6
2014-04-03 15:35:37 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
80ef0dfedc svtools: sal_Bool->bool
Change-Id: I42a341b5805e0b2a7d619ba552700db35815afd5
2014-03-25 14:32:57 +02:00
f5864e8ff4 svtools: sal_Bool->bool
Change-Id: Ia0280d3d4f2d5b8a93a37a93847951391e928028
2014-03-25 14:32:53 +02:00
a4dc5ea2f7 svtools: sal_Bool->bool
Change-Id: I288a5c8b86d21a1b91f464aaf162aed9aca35a42
2014-03-24 08:12:10 +02:00
f7074d8de5 svtools: sal_Bool->bool
Change-Id: I2044e6c1f15579b6051fad5d36fcfa8795f88953
2014-03-24 08:12:10 +02:00
cafdef8109 svtools: sal_Bool->bool
Change-Id: I56072620f9ea28833e1590a7fff7d71ed11fc34c
2014-03-24 08:12:08 +02:00
f5179bcbac just give the enclosing frame the required helpid
Change-Id: Ifb0209eaea4f738ac5b5826f924552465cccc272
2014-03-21 15:15:15 +00:00
41776e53c5 svtools,svx: prefer passing OUString and OString by reference
Change-Id: Iceb2cbcda9d8ddb4ee00db9365c751e0e5d8b3a6
2014-03-13 13:13:38 +02:00
0feaf45541 SVTOOLS : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: I83e39d69deaf2aa1c5ca455c92d070a2d33def3f
Reviewed-on: https://gerrit.libreoffice.org/8421
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03 09:19:11 -06:00
51e937c270 loplugin:literaltoboolconversion
Change-Id: If5949c6123e2816d0e7d9fd93d3e24dfecba1a56
2014-02-28 11:17:52 +01:00
bee1cc83ec Remove visual noise from svtools
Change-Id: I7c2b74a449fb20aae5bc643e24a22cf6f732136d
Reviewed-on: https://gerrit.libreoffice.org/8320
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:14:09 +00:00
88dee977c2 Typo: alowed -> allowed
Change-Id: I3b02f092e294016a5b50900e94dc1917b6896a6f
2014-02-25 22:11:11 +01:00
ad73967e99 Remove unnecessary extractInterface
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
ac6e8ac7e4 typo fixes in comments
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
bd9581d46d bool improvements
Change-Id: I23e29995bc7af791067de4996923b6279f7f8892
2014-01-28 20:24:40 +01:00
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
99ffbb9dc1 EndDialog takes long nResult, not bool
Change-Id: I04210f48f091a652b7867754484a9c5dd6b19471
2014-01-10 17:11:52 +01:00
ee536e482b Translated German comments
Reviewed on:
	https://gerrit.libreoffice.org/7303

Change-Id: I6c5f4571ad691d19ca93c39550000114f263da8b
2014-01-09 19:11:03 +01:00
afcfe47703 translated German comments
Change-Id: I450e1e179edbc0332e2bcf4edee17664083c4786
Reviewed-on: https://gerrit.libreoffice.org/7296
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-01-09 17:31:57 +00:00
4a8175ebeb Get rid of DECLARE_STL_USTRINGACCESS_MAP
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
7586bea9fb Add data for Alfresco Cloud CMIS connection
Change-Id: Ie5374f2e81e1429294805f05ae432fba86cc50df
2013-11-19 14:52:39 +01:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
39768755e8 OAuth2 application keys shouldn't be in the code.
The GDrive OAuth2 key is now defined at configure time. If either the
client secret or client id is missing, the Google Drive connectivity
will be disabled at runtime.

Tinderboxes can set up a GDrive key, but they need to make sure it's
not persisting in the build log.

Change-Id: I09bc748641ec14eae890f273f05bffe4ed421dbb
2013-11-07 18:48:55 +01:00
c91d7e9759 fixincludeguards.sh: svtools
Change-Id: I7db0d4a7bd948204ff6efd7e61c80efd413967cd
2013-11-05 09:28:53 +01:00
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
abd3338486 desktop: stop replacing %PRODUCTNAME %PRODUCTXMLFILEFORMATVERSION
... and %PRODUCTXMLFILEFORMATNAME at runtime and hard-code
OpenOffice.org 1.0 for these too.

Change-Id: Id96390506d2a0f367f932e85d3115362ad483bc3
2013-10-01 18:03:38 +02:00
a48cf78fab merge queue_layout and queue_resize
so that any window derived class, and not just dialogs, can trigger layouting
of their children. Merge together the handful of hacked-up impls of this.

Do that then for the sidebar PanelLayout so that when the label of the custom
animation frame changes that the frame allocates enough space for the new label
to display fully

Change-Id: I9a95f6c3f60cd6cea47656e66cb9ffcc154a3a5a
2013-09-30 16:09:56 +01:00
35a16a88eb route wizards child queue_resize requests to preexisting layout
As an interim measure, until wizards can only be constructed from .ui and then
always contain layout widgets, implement listening for layout widget children
announcing layout change requests and route that to pre-existing original
positioning code. That allows e.g. the mail merge output page in writer to
show/hide the alternative descriptions on selecting letter/email.

Change-Id: I086921f4d46b29756cf4f4fccdf3bdf632ea70b8
2013-09-28 20:58:15 +01:00
c9483451aa convert mailmerge select page to .ui
Change-Id: I34f527ff8e1e9819f4e6ac728efa1e31f8bc3d48
2013-09-27 11:16:12 +02:00
d023339c2f Turn sidebar back to non-experimental
This reverts commit 7ce2a89f4f8fa84232896766276cb3433ada239c.

Change-Id: I53f572777e84f66fd4c3d18fb686dac09095804a

revert d38cb53e3bcf3fd95a75e03b01c3b7a209d07b46

Change-Id: I5b243b69e50084316aaeab250d6b01079c12b718

Revert "sidebar: disable impress task pane if sidebar is enabled."

This reverts commit ee1726bfdba483623d496a3bcc09089e8b55cd65.

revert 54d820a7815af03a248c1aa424fae9bf9a4881f4

Change-Id: Ie7c83d88f5427a7e42fa50879280a0c4a7c2cdd1

Revert "Only register and use the Sidebar if it is globally enabled."

This reverts commit 66a5cc468cef0c6db8b42b7f25367f04208e6f2e.

Conflicts:
	sfx2/source/view/viewfrm.cxx

Change-Id: I17fe702996c4adf7f387573d36ea993f8cc32c96

Revert "disable sidebar menu option if it is disabled."

This reverts commit 05f0eb57618d090fa45011120a907a3b1157accb.

Revert "finally get the taskpane rendering again"

This reverts commit 228bb7ffe0d404ba1225f7b4d26ca71e098577d9.

Conflicts:
	officecfg/registry/data/org/openoffice/Office/Impress.xcu
	sd/source/ui/framework/factories/TaskPanelFactory.cxx
	sd/source/ui/framework/tools/FrameworkHelper.cxx

Change-Id: I248cc9a769695cde19e78774d42ce666dc685599

Revert "don't throw up the sidebar on start."

This reverts commit 645db9a2bd9b1eec381de60c491e6b7f9ee7a7b4.

Conflicts:
	officecfg/registry/data/org/openoffice/Office/Views.xcu

Change-Id: I911859757e2e019836e8ed5213d2ba69ff82aec8

Revert "update to the right service name for new URLs."

This reverts commit 55f49970f4085e3a1498961edabd5303bd6bea6c.

Conflicts:
	sd/source/ui/framework/tools/FrameworkHelper.cxx

Change-Id: I1ba2762a4c969a9125ff8354a9b6035813290021

Revert "tentatively restore more UNO / task-pane goo ..."

This reverts commit 052ac10a6f9b28b9b06884dd3ed41879722be6c9.

Conflicts:
	officecfg/registry/data/org/openoffice/Office/Impress.xcu

Change-Id: I7e62f27329af033df811549436718648a6447dea

Revert "more reverts, first cut at making sidebar optional."

This reverts commit a65a423e22fc03d0b7850bbf20dfc30f6cfa34dd.

Revert "add experimental option for sidebar to 'Advanced' pane."

This reverts commit 54d820a7815af03a248c1aa424fae9bf9a4881f4.

Conflicts:
	cui/source/options/optjava.cxx
	sd/source/ui/framework/module/ImpressModule.cxx

Change-Id: I09a6c0f7834c8ef330d05a014505aaaf09ae096f

Revert "Restore FrameworkHelper taskpane URLs."

This reverts commit e9c2d5b26b1e1b52bdf87192a76314b7362fa80c.

more foo

Change-Id: I2eaa2fbd74dc7a2f7ba937d310472cee6b5a0b57

really go to town on it

Change-Id: I885dc03cd0286bbfdf05c05da9f0bbea2b78bcf4
2013-09-20 16:35:29 +01:00
e95b076744 fdo#63926: remove extra include paths in svtools/ and sfx2/
Change-Id: I0b47849ba0fa0dfaf4a481779a5ece09be496c1e
Reviewed-on: https://gerrit.libreoffice.org/5973
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-09-17 18:51:54 +00:00
ee0d567ff0 convert SVTOOLS module from String to OUString
Change-Id: I647e952769c79b95e11af778b07d64d3a6fbe226
2013-09-17 09:05:37 +02:00
363446eb61 Resolves: fdo#69236 route size request to layout widget, not hard-coded value
a) For the sidebar the sidebars automatically handle scrolling, but for the
older panel the widgets has to do the scrolling so add scrolling parents to the
.ui

b) Fold the DialogListBox scrolling widget implementation into
VclScrolledWindow and remove the duplication.

Change-Id: Ife9ccd8c501e5dee7bf3102a92c8261d979cd834
2013-09-16 11:33:20 +01:00
d71c8d1ed4 convert svtools/source/dialogs/* from String to OUString
Change-Id: Ib868e94bb73f244fcb5b1b47962ded0118023a26
2013-08-22 10:49:32 +02:00
04f72acef2 convert include/svtools/addresstemplate.hxx from String to OUString
and make the local field protected->private, because nothing
else needs to access them.

Change-Id: I4411b98cacb06f3e80a7ab2108917b497dc63625
2013-08-22 10:49:26 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
2680e19419 make svtools XubString free
Change-Id: I27fc5b954ad90bebfd895d8b45f0c37875df6cdd
2013-08-16 16:09:53 +01:00
593a298dd3 Revert "fdo#63926 - remove extra include paths in svtools/ and sfx2/"
This reverts commit 389bdc162415abff78971b1ce7c5d47482e1d37b.

Sadly this was going in the wrong direction...
2013-08-15 17:19:02 +02:00
3994dd5e34 convert include/svtools/insdlg.hxx from String to OUString
Change-Id: I72c5e3e47040e78976f46f585b50ab6c12f84986
2013-08-15 09:11:36 +02:00
00f5fde6c4 convert include/svtools/roadmapwizard.hxx from String to OUString
Change-Id: I1b5a0c3f5946aac9d353550091616cf5a31e6f82
2013-08-15 09:11:35 +02:00
a912a3027c convert include/svtools/wizardmachine.hxx from String to OUString
Change-Id: I8adc23b10f23a8a25e93be671ce16845a44fa57f
2013-08-15 09:11:31 +02:00
63483b882c XubString->OUString
Change-Id: Ibcb2dd5861ad14e286596999b757ca5c41137626
2013-08-12 11:20:10 +01:00