Commit Graph

311 Commits

Author SHA1 Message Date
88c3b4bbf0 table not resizing when rows/columns added to it
I happened across a presentation whose table didn't resize when extra rows and
columns were added to it. It worked on a higher resolution machine, but not on
a 1024x768 one

Change-Id: I98a7a04bee0b0175174e6376e9ebc046b9eff2dc
2014-04-22 12:06:19 +01:00
16e917643f fix namespace
Change-Id: I4bd345e54d9d5a5901cd6e7aa409135b4dabecef
2014-04-22 11:52:55 +01:00
0060649399 coverity#708389 Uninitialized scalar field
Change-Id: If4b05a34b77cc0b6366880ad65132e801b297a62
2014-04-22 11:39:22 +01:00
be88947bac svx: sal_Bool->bool
Change-Id: I464eba5fd5521c31868c6fc8a2137f17428d421e
2014-04-15 09:02:33 +02:00
5047891d04 typo: positon -> position 2014-04-14 12:33:12 +02:00
8f703221a0 Clean up function declarations and some unused functions
Change-Id: Ic720aa7b30bbe56d67e0b65f3e047ad3ae521a97
2014-04-10 11:24:39 +02:00
409ebeb20d coverity#708388 Uninitialized scalar field
Change-Id: Idaa2ec4863beb6be790022c3c66bc4a72e9bf626
2014-04-08 09:18:39 +01:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
0523304875 svl: sal_Bool->bool
Change-Id: I6938314a08d061d2b07d9129742d74a989bd1385
2014-04-03 09:17:52 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
1db5a63365 typo: selektion -> selection 2014-03-29 19:16:31 +01:00
1d3e4bc3b6 Resolves: #i120201# added forcing TableLayouter to take action...
in table undo/redo (CellUndo)

(cherry picked from commit 88b1d35131b0ea44ac6ba6f7edeab82d1c29a39f)

Change-Id: I407323bf6c96ad577d8fc24c82118afc6173f97d
2014-03-28 13:54:54 +00:00
6e61ecd096 Merge back branch alg_writerframes to trunk
(cherry picked from commit b635b4fa4e42053d30ab639643d2236a20243f62)

Conflicts:
	comphelper/inc/comphelper/TypeGeneration.hxx
	comphelper/source/property/TypeGeneration.cxx
	cui/source/factory/dlgfact.hxx
	cui/source/inc/cuitabarea.hxx
	cui/source/tabpages/tabarea.cxx
	cui/source/tabpages/tabarea.hrc
	cui/source/tabpages/tabarea.src
	cui/source/tabpages/tparea.cxx
	drawinglayer/source/primitive2d/polypolygonprimitive2d.cxx
	drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
	drawinglayer/source/texture/texture.cxx
	editeng/inc/editeng/unotext.hxx
	editeng/source/items/frmitems.cxx
	include/drawinglayer/texture/texture.hxx
	include/editeng/brushitem.hxx
	include/svx/sdr/primitive2d/sdrdecompositiontools.hxx
	include/svx/svxids.hrc
	include/xmloff/xmltypes.hxx
	reportdesign/source/ui/misc/UITools.cxx
	sc/source/ui/drawfunc/drawsh.cxx
	sfx2/source/dialog/tabdlg.cxx
	svl/source/undo/undo.cxx
	svx/inc/svx/unoshprp.hxx
	sw/Library_sw.mk
	sw/inc/doc.hxx
	sw/inc/format.hxx
	sw/inc/frmfmt.hxx
	sw/inc/swatrset.hxx
	sw/inc/unomap.hxx
	sw/inc/unoprnms.hxx
	sw/source/core/access/accpara.cxx
	sw/source/core/attr/format.cxx
	sw/source/core/attr/swatrset.cxx
	sw/source/core/doc/docdraw.cxx
	sw/source/core/doc/docfly.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/inc/frame.hxx
	sw/source/core/inc/frmtool.hxx
	sw/source/core/layout/atrfrm.cxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/text/inftxt.cxx
	sw/source/core/text/porfld.cxx
	sw/source/core/text/txtfly.cxx
	sw/source/core/txtnode/fntcache.cxx
	sw/source/core/uibase/app/docst.cxx
	sw/source/core/uibase/app/docstyle.cxx
	sw/source/core/uibase/shells/drawdlg.cxx
	sw/source/core/uibase/shells/frmsh.cxx
	sw/source/core/unocore/unoframe.cxx
	sw/source/core/unocore/unomap.cxx
	sw/source/core/unocore/unoprnms.cxx
	sw/source/core/unocore/unostyle.cxx
	sw/source/ui/fmtui/tmpdlg.cxx
	sw/source/ui/fmtui/tmpdlg.src
	sw/source/ui/frmdlg/frmdlg.cxx
	sw/source/ui/frmdlg/frmpage.src
	sw/source/ui/inc/frmsh.hxx
	xmloff/source/text/txtprhdl.cxx
	xmloff/source/text/txtprmap.cxx

Change-Id: Id3ffaa83bb5594d287f1ac8f2c1c9cf55c70946d
2014-03-28 14:31:08 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
26b06662eb avoid repeated table layouting (fdo#75622)
With the document from fdo#75622, this saves 3775 calls and leaves only 13.
e586fe4585dc07e6f6dd061d09f6a7fb0b22948c removed avoiding the call
to LayoutTable(), which made loading slow. I checked that the doc from that
bugreport still works, so if very original code was correct in avoiding
the call sometimes, this should be ok too.

Change-Id: Ia80f974d4497e5cb04612331527eb87b579ddb76
2014-03-25 11:31:36 +01:00
8ff746e1ad fdo#75260: Align exterior borders of a table correctly for double lines.
Change-Id: I76527d610b74018b5e056ff72cc9e37e9f9c6f03
2014-03-18 21:47:20 -04:00
ffe291088b coverity#982473 Dereference after null check
Change-Id: I394a65ace05c94ae18f4cf0f5bfca6e10e7bedf5
2014-03-15 20:55:49 +00:00
6c97bc4717 svx: sal_Bool->bool
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-11 08:18:24 +02:00
53c91a6db1 svx: sal_Bool->bool
Change-Id: Ib562c23af0ca853165b63750695615578cd55d03
2014-03-11 08:18:23 +02:00
ef61173187 svx: sal_Bool->bool
Change-Id: Idfffbcad1a51192c5ccad28a16c4e613060fc2dc
2014-03-11 08:18:22 +02:00
ea2fb5f8f9 svx: sal_Bool->bool
Change-Id: I360b459102e61562b7cd1987545288d5ce8aed6b
2014-03-11 08:18:13 +02:00
050d7fc852 editeng: sal_Bool->bool
Change-Id: I7a7b5e9ae1762cace1f87b379b32398b231745fd
2014-03-11 08:18:13 +02:00
3b0b4ac5fc svx: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I520563a98c1285fed97174d2aaedfdd042ca699f
2014-03-10 17:39:59 +01:00
3b1fefac9a remove unused code in sdr::table
sdr::table::Cell::getName()
sdr::table::SdrTableObj::getRowCount() const

Change-Id: Icd4cbe591703aedb1412f8e9b485c773ffe79551
2014-03-03 08:58:59 +02:00
57779aa019 editeng: sal_Bool->bool
Change-Id: Id4174904487fc153d8e80471da7c829c52092f78
2014-02-27 12:30:26 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
b1181b89f3 Remove visual noise from svx
Change-Id: I56497d953b0500ba0967fddb36ca8bbbe86c62ad
Reviewed-on: https://gerrit.libreoffice.org/8321
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 07:42:24 -06:00
4a9347fa32 Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I8e11ffe888aac8887c4c0875c41de51f343debae
2014-02-25 16:33:15 +09:00
76b114f849 implicitboolconversion: warn about implicit conversion of call args to bool
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.

Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.

(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)

Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24 17:25:05 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
327dde336e editeng: sal_Bool->bool
Change-Id: Ib1113ebcfc523c8c97731debb2bf456a8c99d802
2014-02-21 12:19:21 +02:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
a02ec9ebef cid#705907 dereference before null check
Change-Id: I51f0331830fc6d6eaae1ca33c7387e76390ec1cb
2014-02-17 14:04:32 +02:00
811e6f6745 coverity#738003 Uncaught exception
Change-Id: Iddb64e592ae47dd5f22430778b8018fc8c9880c5
2014-02-13 21:04:53 +00:00
be921ceb35 coverity#738003 Uncaught exception
Change-Id: I09a015a590eeb2457963dbb3cfcafd6a714f82c9
2014-02-13 21:04:52 +00:00
624eb1cc6a coverity#1132667 Unchecked dynamic_cast
Change-Id: Ia1e8a041d1eb1770757731554ab4fe007a62c111
2014-02-07 12:24:41 +00:00
0d957046f1 bool improvements
Change-Id: Ic32faa81bfbb66a9d8632fb3db187e33c31188ed
2014-01-28 20:26:17 +01:00
d803483f6a convert more SvStream::operator<< calls
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.

Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:39 +00:00
03725013b6 bool improvements
Change-Id: Ic46fa46c200b94e2e6c5a073ba89b9aae5c14542
2014-01-17 18:45:15 +01:00
a2218b0d8b fdo#54938: Convert svx and svl to cppu::supportsService...
...final season

Change-Id: Ie51ac231def4a8a6e2681b81de7580798c95eed2
2014-01-16 10:25:53 +01:00
4bb39ccf53 cppcheck: fix same expression, check once !mxTable.is()
Change-Id: Ie12146f3c2f18c5ec9a49a666f327772493fcf03
2013-12-13 23:30:29 +01:00
55edb3faf6 cppcheck: Prefer prefix ++/-- operators for non-primitive types
Change-Id: Ibc34750a0f9b5a36c8fa0743e9ac88482ccfecc4
2013-12-13 23:30:29 +01:00
61492fadb6 WaE: field 'mxImpl' will be initialized after field 'mnPreviousSelectionCount'
Change-Id: I7d6facb76317d8e7de3adbafdf3763f37c1b0837
2013-12-13 12:30:32 +02:00
e9c08cfed4 fixes for issues checked out by coverity
(cherry picked from commit 6f53c4f2f46691d41ccf2c2a99ae40105606e489)

Change-Id: I76e21409fee4f39bd6f048636e4fbc392807a486
2013-12-13 10:09:44 +00:00
4a85afa514 <: could be a digram - fix tinderbox.
Change-Id: I128d6912ce556cfc17c38ed51267fc965c384fea
2013-12-12 11:25:17 +01:00
83e191e25d Do not use C++-UNO internal static_type functions in client code
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
a62c2a5fa5 Don't hold css::uno::Type instances by pointer
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-12 08:26:40 +01:00
123e2c3e93 Revert "Don't hold css::uno::Type instances by pointer"
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now:
Ach, old GCC doesn't like plain string literals to initialize members
of OUString type...

Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11 15:38:30 +01:00