97a5ba4a71
remove comments why a file gets included
...
also remove some commented out code
Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
e8c424c3e3
coverity#738948 Uninitialized scalar field
...
Change-Id: Ieca446ab69b84249059c5ce4ec713832bd0a8134
2014-04-17 09:43:17 +01:00
618a0f8c03
whitespace for include statements
...
Change-Id: I76bd0ef07a2fa134e948724cecdf539ffe6ccb8a
2014-04-15 13:43:13 +02:00
8a81f542a6
xmloff: sal_Bool->bool
...
Change-Id: I873c80baec8e70e3e8f642644563b92137571a30
2014-04-15 09:02:31 +02:00
9c51f5b806
Clean up function declarations and some unused functions
...
Change-Id: I2ca50a15209503020047975ac848df98b74089af
2014-04-09 12:04:12 +02:00
302bd1c4ec
coverity#441207: Logicaly dead code
...
Change-Id: Ia198d64a95d86a1cd47987d6db3aa3faafba84f4
2014-04-06 13:11:30 -05:00
3bc729b4b9
resolved fdo#76777 now write correct number style condition operator !=
...
https://gerrit.libreoffice.org/8834 and
https://gerrit.libreoffice.org/8836 will prepare 4.2.4 and 4.1.6 to
accept the correct != operator instead of <> that was written so far.
Change-Id: Ib89bbaf096e2d459767c4d05e5bf5151a1120c1a
2014-04-04 12:26:04 +02:00
dfcc851d65
accept proper number style condition != as not equal operator, fdo#76777
...
ODF 1.2 specifies '!=' as not equal operator in <number:number-style>
<style:map> style:condition attribute. So far '<>' is written, accept
the correct operator.
Change-Id: I6087992ee35fff5c7aa52b7cec2b83b0a78dbac1
2014-04-04 12:06:01 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
0f912872b6
xmloff: sal_Bool->bool
...
Change-Id: Id3d8f4f4ef32280a131907ffa32eb2ad5d6ea2e1
2014-03-31 12:39:03 +02:00
0e8ab0fa29
xmloff: sal_Bool->bool
...
Change-Id: Ib4a73215187923dccd72fc7793ffd4bcbef24ab9
2014-03-31 12:39:02 +02:00
6ac6fb820f
xmloff: sal_Bool->bool
...
Change-Id: I64c33ae4c157e270acac9a1f820d3e6272ba0bea
2014-03-31 12:39:02 +02:00
ba6cfaaa6b
xmloff: sal_Bool->bool
...
Change-Id: Idc7b0ef2591e65e82903d55af68434acbeca0e55
2014-03-31 12:37:25 +02:00
c98a7eec7f
xmloff: sal_Bool->bool
...
Change-Id: I1c97da5b7bbac348150399afbf386613433e5551
2014-03-31 12:37:25 +02:00
ddb07081da
xmloff: sal_Bool->bool
...
Change-Id: I1deb10cb1581137ab92e73367e63339822a9a094
2014-03-31 12:36:54 +02:00
3f60a32aa2
xmloff: sal_Bool->bool
...
Change-Id: If694d16088ae0dcdc8b99797eed575c90d646fe5
2014-03-31 12:35:53 +02:00
55ee8a75c1
xmloff: sal_Bool->bool
...
and remove some unused return values
Change-Id: I957b4befd2e2574a1d202edee440f65325d5388a
2014-03-31 12:35:53 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
5fb78604c1
Split TYPEINFO into plain and TYPEINFO_OVERRIDE
...
...where the latter contains SAL_OVERRIDE annotations
Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-26 11:54:55 +01:00
fe0f96e4aa
coverity#705345 Missing break in switch
...
Change-Id: I7ed37e384a0f3bb3863d957ac0333ddc2c7434a3
2014-03-21 11:13:54 +00:00
27a8609b20
coverity#704114 Unchecked return value
...
Change-Id: I9f92b4536557d8f6f482d6ce7646125035db3f1d
2014-03-21 11:13:52 +00:00
402fffa1b4
Add dash-dot and dash-dot-dot line styles.
...
We need these for Excel interop.
Change-Id: I91450c1d205f28636edfb4392aa6ae5091b1d7b7
2014-03-19 00:28:16 -04:00
fddde2b74a
xmloff,vbahelper: prefer passing OUString and OString by reference
...
Change-Id: I8b7e4284c122549c03edaa7f3963cbfb2024b3fc
2014-03-13 15:05:31 +02:00
c15913b273
Spelling fix: suported
...
Change-Id: I3b67edd5ba4541a65cb0916abea6db1362c32afd
2014-03-12 15:56:04 +02:00
db5c67e100
Keying on XTypeProvider::getImplementationId is unnecessary here
...
...given that cases where "every instance of getPropertySetInfo returns a new
object [...] must not be cached" anyway, so just key on the XPropertySetInfo
instances.
Change-Id: I11f0a1fe030226d1d26d6b6e6a2654f4511fdce8
2014-03-10 08:59:23 +01:00
e896b8ecdb
fix ODF validation error
...
that attribute was only written for backwards compatibility
Change-Id: Icf06300809c55c3a20a74ee3b9d36644d6f5c2d9
2014-03-08 18:31:13 +01:00
2c62596cf2
fdo#75260: Correctly draw double lines for both Writer and Calc.
...
Fix all sorts of incorrect double line handling in drawinglayer in order to
draw thick-thin double line types correctly. Also change handling of border
lines in writer tables. There are still some outstanding issues but it's
much better than how it was before.
Also realized that Word and Excel handle simple thin double lines differently;
Word varies widths of all of the lines and the gap whereas Excel only has one
fixed size for its double line. For this reason I decided to add a separate
double line type (DOUBLE_THIN) to handle Excel's double line.
Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4
2014-03-04 22:02:37 -05:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e23ea87cb3
Remove visual noise from xmloff
...
Change-Id: I205d4e555f5b88654a90007eb7ac05bc7b00a904
Reviewed-on: https://gerrit.libreoffice.org/8346
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 04:32:34 -06:00
b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
8b34d05cb1
sal_Bool->bool
...
Change-Id: Iab0165ef642dfee5bd315fc1f42f4bad8e86aa47
2014-02-14 14:15:15 +02:00
fd3c9e16e1
sal_Bool->bool
...
Change-Id: Ia453c7868e030e3f10a7f69c1e2d28244758fdef
2014-02-14 14:15:14 +02:00
a9cb2af8c2
cid#705344 missing break in switch
...
Change-Id: I734d4ed0dbb7b1cdf7640b76d88ea1ff2d19da4c
2014-02-12 08:59:08 +02:00
503b719173
fdo#73281: Why!?
...
This restriction makes absolutely no sense. It was likely someone's
temporarily hack that was totally forgotten in the past 10 years...
Not to mention removing this fixes my bug.
Change-Id: I7394cccdc9fe486fda6cdd9b7eaf98fd291895a9
2014-02-07 21:55:51 -05:00
72b2fafebf
Remove this duplicate and use the UNO constant values instead.
...
Change-Id: Id81aacc6c594ad25d97f6f6dc578ed9ca16549ab
2014-02-02 18:24:46 -05:00
fa189d7447
bool improvements
...
Change-Id: I238ab0ebe54cc804c85356a3de9fbdcc396057d3
2014-01-28 20:26:18 +01:00
0df3ba835d
coverity#736746 Resource leak
...
Change-Id: I01fc15563b57560fd503f66abf2e2fc07301feb7
2014-01-24 14:02:00 +00:00
b663316e83
Resolves: fdo#73355 reconcile legacy path bug detection
...
reconcile
"223f6b631c1b087754c0f9051fb55f029f2503ce
Resolves: #i123433# Detect pseudo-vertices at svg import..."
with
"7a19798c73fd39d8d69ff6364f0696e68cdd1381"
Compatibility option for incorrect relative moves after closePath (fdo#47406)
and
"a2ee8055e9c136923f0244fe289cac6377933c31"
Fix fdo#47406 incorrect relative moves after closePath
Change-Id: I1221099a40500aeb4165a3350d8ae2df1fd3111b
2014-01-24 12:56:09 +00:00
77637324ab
warning C4805: '|=' : unsafe mix of type 'bool' and type 'sal_Bool'
...
Change-Id: I9a23865f7b1cf9d88f5b4f754b15e95554da3fda
2014-01-22 17:15:11 +01:00
bbd9668d5f
bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
...
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
9f76437548
Removed unused solar.h reference
...
Change-Id: I1ff7d4bad068a8bc8cdc7f27dbfaee199d0f2e5f
Reviewed-on: https://gerrit.libreoffice.org/7513
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-01-20 21:32:27 +00:00
0c9d002ecd
bool improvements
...
Change-Id: I42127c096aa4310e3c8b6c9b6487b4de63e7ac9a
2014-01-14 21:28:09 +01:00
82625bb98e
remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
...
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
06824ff1de
cppcheck: const_cast instead of C cast
...
Change-Id: I9b4a01364ff8b8c82fec687ab0cbd73952b3e237
2014-01-04 12:46:59 +01:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
ebc1b2fe50
added bool bForExport parameter to XMLPropertySetMapper ctor
...
Set to true for export, false for import. If export true, an
XMLPropertyMapEntry with mbImportOnly==true is not added to the
mappings. This to be able to have more than one mappings for import
(for example a current extension namespace and the future namespace
proposed to the ODF-TC, or corrected typos in element or attribute
names), but map only to one entry on export, of course.
Change-Id: Ia01ea949c88eda2f8a6c10f51c59e35e7abdcaf3
2013-12-20 03:26:57 +01:00
9dd7ee88bd
prepared XMLPropertyMapEntry with mbImportOnly flag
...
Change-Id: Id5a54a591a42c836884af1fd09dc055f2fce6db5
2013-12-20 03:26:56 +01:00
dd902b8e25
reordered member variables for 4 byte alignment
...
Change-Id: Iaae7689d1ed3c74e261fcc90fa88b5521468e376
2013-12-20 03:26:53 +01:00
