aa39d21107
clean up hrc files
...
Change-Id: I76756fe539589d2ab086fd1f1aeec50a9f39af37
2014-04-22 13:03:18 +02:00
40064f479b
clean up hrc files
...
and remove some unused stuff
Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
2014-04-22 13:03:17 +02:00
c9e2ce548b
WaE: Unreferenced function definition [loplugin:unreffun]
...
Change-Id: Ibac16b109d9024a75fc6045d5d55fb5d21eee70a
2014-04-19 22:24:04 +03:00
55c70634b8
fixincludeguards.sh: xmlsecurity
2014-04-19 11:10:08 +02:00
bfed8b9c9b
Clean up function declarations
...
Change-Id: I448e0cf2abeeafb0f6266baeb95705b3a11705a4
2014-04-14 16:00:03 +02:00
fb1b0c1f7b
Use valid UNOIDL identifiers in XCompressedDocumentHandler
...
...which is new in LO 4.3 and still unpublished.
Change-Id: I2d6b553c27906d7855c62f33fdf0060b58d3ec62
2014-04-11 08:41:09 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
cbfc354088
coverity#708739 Uninitialized scalar field
...
Change-Id: I2ac9aa4d74321c9d4312650e744ce54c4af553bb
2014-03-21 11:13:41 +00:00
108c5bb958
coverity#708740 Uninitialized scalar field
...
Change-Id: Ic3cb17f2344192a3e9704ff7e1d825e62dc45d19
2014-03-21 11:13:40 +00:00
4386863e1a
xmlsecurity: prefer passing OUString by reference
...
Change-Id: I44b96a8adc2f6309088d99ff3bce438f660d302d
2014-03-17 13:30:53 +02:00
68ec95b3f8
made ListBox handle more than 64k elements, fdo#61520 related
...
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.
Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2014-03-05 07:31:19 -06:00
4d6560f506
fdo#54938: Convert some places to use cppu::supportsService
...
The last cases are non obvious, so it's pratically done
Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
2014-03-04 07:30:02 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
ac6e8ac7e4
typo fixes in comments
...
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
5a7532b5ed
convert cert path page to .ui
...
Change-Id: Ic726e5665a46b9e34fb05d800460b50977d94ee6
2014-01-30 10:41:28 +00:00
3103445754
convert view certs tabdialog to .ui
...
Change-Id: Iee67e273cf19a1af6c4947870bb9f131f0a6cc11
2014-01-30 10:00:40 +00:00
25570b1853
bool improvements
...
Change-Id: I550337b24e6efe96bb8ac40bd6e574065e84b135
2014-01-28 20:26:18 +01:00
7f84ebe93b
bool improvements
...
Change-Id: I74db1d1b8250a6832fc68a6856912713b1d8944b
2014-01-22 08:22:34 +01:00
92f162eb0b
Convert xmlsecurity to cppu::supportsService
...
Change-Id: Ifcec9e067e54cc8a3d1254d41d09ea251820849d
2014-01-17 12:24:57 +01:00
82625bb98e
remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
...
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
be053c9a80
Spelling correction: s/retrive/retrieve/
...
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20 23:26:58 +02:00
8233226fe4
No need for implbase1.hxx to include XComponentContext.hpp
...
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up,
of course.
Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
08fe82e59c
Remove unnecessary use of OUString constructor in + expressions
...
Convert code like
aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp");
to
aFilename = OUString::number(nFilePostfixCount) + ".bmp";
Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
2c35fff7ec
remove most use of RTL_CONSTASCII_USTRINGPARAM macro
...
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
ab5d1fbfb4
SAL_WARN_UNUSED com::sun: ⭐ :uno::Any
...
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
fcd1637d51
convert OUString compareToAscii == 0 to equalsAscii
...
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
16b91e13c7
Converge on SvtSecurityOptions::isTrustedLocation
...
Change-Id: Ibcf4b7d9d11295c7679637a37d41dc2960e04f8f
2013-11-09 16:24:56 +01:00
0121f632ef
remove unnecessary use of OUString constructor in XMLSECURITY module
...
Change-Id: I95b0eda83c60456f3db267183030fe5f6cd70bc4
2013-11-07 11:28:38 +02:00
5285beeaa4
remove redundant calls to OUString constructor in if expression
...
Convert code like:
if( aStr == OUString("xxxx") )
to this:
if( aStr == "xxxx" )
Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
54a17dd246
windows: warning 4355 is disabled globally in com_MSC_defs.mk
...
So there is no need to do this locally, too.
Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-28 01:02:13 +01:00
a7724966ab
Bin comments that claim to say why some header is included
...
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
094f00651a
CID#708741 uninitialized members
...
Change-Id: I15475d560e889b0f0fc91d96cfa6ae97e81a41b5
2013-10-03 13:30:13 +01:00
4763c0acbd
-Werror,-Wunused-const-variable
...
Change-Id: Ic8279d6a52691532b987e7947709bdc14064cc3e
2013-10-02 16:49:40 +02:00
6ea6a422fb
s/wiki.services.openoffice.org/wiki.openoffice.org/g
...
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-09-07 14:21:22 +02:00
f1dd6b8d62
WaE: 'BufferNode::notifyAncestor': recursive call has no side effects
...
Interesting function that just traverses a chain of objects using
recursion, but does nothing at all otherwise. Kill it. But at least it
had an Enterprise Ready block comment in front.
Change-Id: If2296d2534cb9451d4ceadaf966b8c70f0a17557
2013-09-04 01:57:54 +03:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
b5e5ce956b
fdo#57950: Remove some chained appends in xmlsecurity
...
Change-Id: I35ac622abb995a9259f0774f463ec2816b3668b6
Reviewed-on: https://gerrit.libreoffice.org/5477
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
2013-08-18 13:53:54 +00:00
182bf2a63a
Revert "fdo#57950: Remove some chained appends in xmlsecurity"
...
This reverts commit 4f20c9f6f95c117bcdb520682df4fa1429a56477
Change-Id: I4d8cef801d570b0c20e580144e79a5940b100271
Reviewed-on: https://gerrit.libreoffice.org/5476
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
2013-08-17 15:28:01 +00:00
4f20c9f6f9
fdo#57950: Remove some chained appends in xmlsecurity
...
Change-Id: If70fa38ad4836b6dacdd0c5577c66b78be6826a6
Reviewed-on: https://gerrit.libreoffice.org/5465
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
2013-08-17 07:48:21 +00:00
9499df9f8c
Ifdef out code which had been accidentally un-commented-out
...
The code snippet had been commented out since its introduction in
2004. In 1452e5659796db395efa222d50cc8158275c5442 it was accidentally
un-commented-out, but it causes compilation errors. So ifdef it out
instead, with a comment. Note that I have no idea what the code does
and whether it actually is useful to keep for future reference or not.
Change-Id: Ie60ca065b2c65f86a7b382e246c1b650424daa1d
2013-08-12 09:28:57 +03:00
1452e56597
fdo#62475 removed pointless comments
...
Change-Id: I02b264a9661bcefaea96d6c5743352914154427d
Reviewed-on: https://gerrit.libreoffice.org/5345
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2013-08-11 19:37:59 +00:00
ec52a20edb
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
Change-Id: Ie959aa5a6874aae3c60273355a959c344e82699e
Reviewed-on: https://gerrit.libreoffice.org/5083
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-07-24 20:18:36 +00:00
bddd4d4598
Mark as const
...
Change-Id: I2746b92b1360c3c181879a81f653c44ef609f351
2013-07-22 21:03:55 +09:00
52bce8fadd
convert versions of dialog to .ui
...
Change-Id: I1be2211b5c936e6e00f2fe81883b8fb1e67ef550
2013-07-16 12:45:56 +01:00
9eeacd2751
XmlReadOnlyImage is now unused post .ui conversions
...
Change-Id: Ib90966ed6e791371dacd8d9cdf8234fa66b02858
2013-07-02 11:59:52 +01:00