cbce40e965
Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.
Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
89c77994d4
remove some unnecessary typedefs around uno::Reference
...
Not very useful these days, since we have the css:: prefix to reduce
verbosity.
Found with a search like:
git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;'
| grep -v 'std::'
Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd
Reviewed-on: https://gerrit.libreoffice.org/16730
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-06 06:14:15 +00:00
465489d97a
Fix typos
...
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-07-03 09:43:46 +00:00
1a8915ef83
Fix typos
...
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2015-06-30 15:57:12 +00:00
6390d2c52b
Get rid of comphelper::string::is*Ascii functions
...
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
2015-06-24 15:27:28 +02:00
3fa7b0b70f
Fix typos
...
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
Reviewed-on: https://gerrit.libreoffice.org/16310
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:25:13 +00:00
01532b1ab8
Fix typos
...
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:05:58 +00:00
8d8f264f57
cppcheck: passedByValue
...
Change-Id: I444c40340bcfd64f88dac34da6cc858f66996fe6
2015-06-15 11:11:43 +01:00
3a05a08ba7
loplugin:redundantcast: const_cast to same type
...
Change-Id: I5fe081bc2edfe14c81372ae0fd407e493d80d689
2015-05-29 12:04:32 +02:00
3aebc670e1
Remove include stdio (part2)
...
Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd
Reviewed-on: https://gerrit.libreoffice.org/15775
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-05-18 05:33:52 +00:00
99e60d8d62
std::ptr_fun became deprecated since C++11
...
Change-Id: If93609d032c9864e0251230bf9ed76e6b6741a62
Reviewed-on: https://gerrit.libreoffice.org/15672
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-05-08 15:54:12 +00:00
e95b073790
loplugin:staticmethods
...
Change-Id: I60678dfd1bd0d2e4754dbbe6ba053e90d5870780
2015-05-05 09:30:40 +02:00
d1ca0f4ed0
Bin some pointless comments and reduce some vertical whitespace
...
Bin pointless '// predeclarations' or '// forward declarations' comments. If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?
Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.
Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-30 06:14:12 +03:00
5db2f661ce
More loplugin:simplifybool
...
Change-Id: I8996d0afb3669046040a4dfebc9c2c6c07fc7644
2015-04-27 15:30:56 +02:00
54e87df11f
Change INetProtocol enumerators to CamelCase
...
...to avoid clashes with macros and poor warnings about hiding global FILE
Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
44b3e56bb4
Change INetProtocol to scoped enumeration
...
...and fix o3tl::enumarray::operator [] const overload
Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
cf42ba089f
Replace remaining getCppuType et al with cppu::UnoType
...
Change-Id: Ifd082fb63b791441a9af595e02f6ce1732d36ab0
2015-04-01 08:39:17 +02:00
73e2c6ae27
Clean up C-style casts from pointers to void
...
Change-Id: I9564d76c9b6fb808ca92b53f1bca07ec0850c6f8
2015-03-28 19:09:20 +01:00
39c4b2787e
forms: Replace these macros
...
Change-Id: I656905cf6f0e3647824ff3836fcea93920251264
2015-03-28 11:52:41 +01:00
0b1d8eff97
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: I4293d3e9244bb2ae3c6b8999c0d682e7f23138fb
2015-03-26 15:33:30 +01:00
d772b9bdc4
loplugin:constantfunction: forms
...
Change-Id: Icb1b4bb3fd73b54378b77fbaa6c41c3a0f03706a
2015-03-24 10:31:18 +02:00
3099c70b11
Fix various XServiceInfo implementations
...
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
567f511924
V801: Decreased performance
...
Change-Id: I97c7977fdfea57b5d1c45ce0c5902b74cc719db9
2015-03-06 17:08:55 +00:00
a3646d5572
cppcheck: duplicate inherited member
...
Change-Id: Iee20ca4523739eb082ea1fa8c1145891c0caed29
2015-03-02 10:25:49 +02:00
186dbb6890
callcatcher: update unused code
...
Change-Id: If6e0cbf8544ca7a4668cdc67fcf390d8835b7017
2015-02-19 09:55:18 +00:00
e46549e955
forms: Fix copy'n'paste mistakes.
...
com_sun_star_form_ORadioButtonModel_get_implementation ->
com_sun_star_form_ORadioButtonControl_get_implementation
com_sun_star_form_OGroupBoxModel_get_implementation ->
com_sun_star_form_OGroupBoxControl_get_implementation
and a bit of further cleanup.
Change-Id: I2d03d69ac83c482257baed5a6b84a6bacae68889
2015-02-17 12:05:47 +01:00
5c3d918062
forms: Convert also com.sun.star.form.XForms.
...
Plus some associated cleanup.
Change-Id: I0a923198c23e2e4ecbc91e5b56cfac31b7f71256
2015-02-17 11:34:20 +01:00
5d05f7ed85
forms: use constructor feature for form modules
...
Change-Id: I8f1588cbd338e2f8b5bc6047d84b17c697a7d2d3
2015-02-17 11:34:20 +01:00
73e117d19a
loplugin:deletedspecial
...
Change-Id: Ic3b744fe3eb3a07d7f5a7feeaf43cde2ec2b3241
2015-02-07 12:35:59 +01:00
b44cbb26ef
new loplugin: change virtual methods to non-virtual
...
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
3ad6e328a7
Some more loplugin:cstylecast: forms
...
Change-Id: I39325fccdadcc57df32fe5821eef0d8477018b59
2015-01-20 09:06:47 +01:00
c32a5a3b8e
simplify Date/Time/DateTime conversion code
...
add constructors to Date/DateTime/Time,
that take the css::util counterparts,
to simplify code converting between these type
Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7
Reviewed-on: https://gerrit.libreoffice.org/13855
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Eike Rathke <erack@redhat.com >
2015-01-13 15:24:04 +00:00
9e3ced1956
forms: Use appropriate OUString functions on string constants
...
Change-Id: I1bcd815663c29025da6b3ce50bdf767eef74fe94
2014-12-18 14:12:26 +01:00
afb5143639
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I1d037e87c69b1a7de019f1abf1f729bf7e28d762
Reviewed-on: https://gerrit.libreoffice.org/13494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-17 07:31:17 +00:00
0c1b8516cb
forms: Use appropriate OUString functions on string constants
...
Change-Id: I196e847e2f63d1bac6ed0f520cba67508aec1a5d
2014-12-15 10:12:09 +01:00
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-11-14 09:20:38 +01:00
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
fc0d57b7af
Revert "use the new OUString::fromUtf8 method"
...
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
05050cdb23
use the new OUString::fromUtf8 method
...
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
3b206d4818
forms: std::auto_ptr -> std::unique_ptr
...
Change-Id: Ia8f045715a508de77c8ce86cf224a3038162faac
2014-09-30 12:28:52 +02:00
8270808946
Mark template member fns that are supposed to override as SAL_OVERRIDE
...
Change-Id: If940dcf7f7d2144576b4ae55578b8b7bd113295b
2014-09-15 14:58:57 +02:00
f7a65a1096
Remove useless include tools/debug.hxx from forms and extensions
...
Change-Id: Idc8ecbb65c7c4c63950d8b249e0d0d91788d6d3b
Reviewed-on: https://gerrit.libreoffice.org/11012
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2014-08-21 07:09:21 -05:00
339d967dbf
forms: CSS -> css
...
Change-Id: Ib2fb1f4f4b64a67cebdebb6ebfb36dbe6878bef6
2014-08-21 09:03:25 +02:00
df906cf2ac
use SimpleReferenceObject in forms module
...
to replace hand-rolled version
Change-Id: Ic95f4dfd1ae5ab414c68c52ad58c738f4ac1d9d1
2014-07-10 11:04:11 +02:00
4228f08d60
use assert when followed by deref
...
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-03 12:49:38 +01:00
4a67abb3b2
coverity#706547 Uncaught exception
...
Change-Id: Ib619e1ab3f091c04ec27a249b733e54ce469cf82
2014-06-24 14:28:27 +01:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00