forked from amazingfate/loongoffice
206b5b2661
...warning about (for now only) functions and variables with external linkage
that likely don't need it.
The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }
returns 1, both moving just the struct S2 into an nunnamed namespace,
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
namespace { struct S2: S1 { int f() { return 1; } }; }
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }
as well as moving just the function f overload into an unnamed namespace,
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
namespace { int f(S2 s) { return s.f(); } }
}
int main() { return f(N::S2()); }
would each change the program to return 0 instead.
Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Testing tools == How to check compatibility between compilers == Since the interfaces used in the cpp bridgetest are not changed often one can just build the cppobj.uno.dll and the constructors.uno.dll (testtools/source/bridgetest) in an old environment and then use them in the new environment. That is the files are copied into the testtools/wntmsciXX.pro folder which corresponds to the new environment. On Windows this test will typically fail because the tests use the cppu::getCaughtException function, which only works when all libs are build using the same runtime. This part of the test can switched off. To do this go into the testtools/source/bridgetest folder and call dmake compcheck=1 This will add a new compiler define (-DCOMPCHECK) and will be used in the bridgetest.cxx to switch off the code which uses the getCaughtException function. However, there is still a test which causes the test component to throw and IllegalArgumentException. This still works. == Using source/bridgetest for stress testing == Start a modified bridgetest_server (with the final "--singleaccept" argument removed from the uno executable call) or a modified bridgetest_javaserver (with the final "singleaccept" argument replaced with "multi" in the java executable call), then start a modified bridgetest_client (with a final "stress" argument added to the uno executable call). The client will continuously establish connections to the server which are immediately destroyed again. The test will run forever, unless an error occurs.