forked from amazingfate/loongoffice
Communicate Kashida insertion positions in an explicit way. Rest of LibreOffice communicate adjustments to character widths (e.g. for justification or spacing) using so-called DX array. DX array is an array of absolute character positions (e.g. DX[n] is the position after character n from the start of the lines, and its widths is DX[n] - DX[n-1]). This DX array is modified also when Kashidas are inserted after a given character for Arabic justification, by expanding its width. VCL would use this to know where to insert the Kashidas and how many ones. But because DX array is used for both widths adjustments and kashida insertion, this turns out to be a source of bugs since VCL has tosecond guess the DX array to find which is pure width adjustment and which also involves Kashida insertion, and the heuristics it uses are fragile. This change adds a second array of booleans that records where Kashida is inserted and communicates it all the way from where Kashida insertion is decoded in Writer and down to VCL layout. This change passes the Kashida array only when it seems necessary (e.g. during drawing but not when measuring text since the DX array is enough in this case). Hopefully no places where Kashida insertion needs to be passed down were missed. A couple of glyph and layout flags that were used for old heuristics and no longer needed and are removed. This also fixes: tdf#87731 tdf#106309 tdf#108604 tdf#112849 tdf#114257 tdf#127176 tdf#145647 tdf#146199 Change-Id: I4ed0850ef2fdc3e9143341afac649e7e7d463c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
129 lines
4.6 KiB
C++
129 lines
4.6 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <drawinglayer/drawinglayerdllapi.h>
|
|
|
|
#include <basegfx/range/b2drange.hxx>
|
|
#include <vector>
|
|
#include <basegfx/polygon/b2dpolypolygon.hxx>
|
|
#include <vcl/svapp.hxx>
|
|
|
|
// predefines
|
|
class VirtualDevice;
|
|
class GDIMetaFile;
|
|
enum class DrawTextFlags;
|
|
namespace vcl
|
|
{
|
|
class Font;
|
|
}
|
|
namespace tools
|
|
{
|
|
class Rectangle;
|
|
}
|
|
namespace drawinglayer::attribute
|
|
{
|
|
class FontAttribute;
|
|
}
|
|
namespace com::sun::star::lang
|
|
{
|
|
struct Locale;
|
|
}
|
|
|
|
// access to one global impTimedRefDev incarnation in namespace drawinglayer::primitive
|
|
|
|
namespace drawinglayer::primitive2d
|
|
{
|
|
/** TextLayouterDevice class
|
|
|
|
This helper class exists to isolate all accesses to VCL
|
|
text formatting/handling functionality for primitive implementations.
|
|
When in the future FontHandling may move to an own library independent
|
|
from VCL, primitives will be prepared.
|
|
*/
|
|
class DRAWINGLAYER_DLLPUBLIC TextLayouterDevice
|
|
{
|
|
/// internally used VirtualDevice
|
|
SolarMutexGuard maSolarGuard;
|
|
VirtualDevice& mrDevice;
|
|
|
|
public:
|
|
/// constructor/destructor
|
|
TextLayouterDevice();
|
|
~TextLayouterDevice() COVERITY_NOEXCEPT_FALSE;
|
|
|
|
/// tooling methods
|
|
void setFont(const vcl::Font& rFont);
|
|
void setFontAttribute(const attribute::FontAttribute& rFontAttribute, double fFontScaleX,
|
|
double fFontScaleY, const css::lang::Locale& rLocale);
|
|
|
|
double getTextHeight() const;
|
|
double getOverlineHeight() const;
|
|
double getOverlineOffset() const;
|
|
double getUnderlineHeight() const;
|
|
double getUnderlineOffset() const;
|
|
double getStrikeoutOffset() const;
|
|
|
|
double getTextWidth(const OUString& rText, sal_uInt32 nIndex, sal_uInt32 nLength) const;
|
|
|
|
void getTextOutlines(basegfx::B2DPolyPolygonVector&, const OUString& rText, sal_uInt32 nIndex,
|
|
sal_uInt32 nLength, const ::std::vector<double>& rDXArray,
|
|
const ::std::vector<sal_Bool>& rKashidaArray) const;
|
|
|
|
basegfx::B2DRange getTextBoundRect(const OUString& rText, sal_uInt32 nIndex,
|
|
sal_uInt32 nLength) const;
|
|
|
|
double getFontAscent() const;
|
|
double getFontDescent() const;
|
|
|
|
void addTextRectActions(const tools::Rectangle& rRectangle, const OUString& rText,
|
|
DrawTextFlags nStyle, GDIMetaFile& rGDIMetaFile) const;
|
|
|
|
::std::vector<double> getTextArray(const OUString& rText, sal_uInt32 nIndex,
|
|
sal_uInt32 nLength) const;
|
|
|
|
::std::vector<double> getCaretPositions(const OUString& rText, sal_uInt32 nIndex,
|
|
sal_uInt32 nLength) const;
|
|
};
|
|
|
|
// helper methods for vcl font handling
|
|
|
|
/** Create a VCL-Font based on the definitions in FontAttribute
|
|
and the given FontScaling. The FontScaling defines the FontHeight
|
|
(fFontScaleY) and the FontWidth (fFontScaleX). The combination of
|
|
both defines FontStretching, where no stretching happens at
|
|
fFontScaleY == fFontScaleX
|
|
*/
|
|
vcl::Font DRAWINGLAYER_DLLPUBLIC getVclFontFromFontAttribute(
|
|
const attribute::FontAttribute& rFontAttribute, double fFontScaleX, double fFontScaleY,
|
|
double fFontRotation, const css::lang::Locale& rLocale);
|
|
|
|
/** Generate FontAttribute DataSet derived from the given VCL-Font.
|
|
The FontScaling with fFontScaleY, fFontScaleX relationship (see
|
|
above) will be set in return parameter o_rSize to allow further
|
|
processing
|
|
*/
|
|
attribute::FontAttribute DRAWINGLAYER_DLLPUBLIC getFontAttributeFromVclFont(
|
|
basegfx::B2DVector& o_rSize, const vcl::Font& rFont, bool bRTL, bool bBiDiStrong);
|
|
|
|
} // end of namespace drawinglayer::primitive2d
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|