forked from amazingfate/loongoffice
32c43ee75c
In file included from starmath/inc/mathml/iterator.hxx:12,
from starmath/source/mathml/iterator.cxx:10:
In member function ‘SmMlElement* SmMlElement::getParentElement()’,
inlined from ‘void mathml::SmMlIteratorBottomToTop(SmMlElement*, runType, void*) [with runType = void (*)(SmMlElement*, void*)]’ at starmath/inc/mathml/iterator.hxx:43:39,
inlined from ‘void mathml::SmMlIteratorFree(SmMlElement*)’ at starmath/source/mathml/iterator.cxx:57:28:
starmath/inc/mathml/element.hxx:263:46: error: pointer ‘pCurrent’ used after ‘void operator delete(void*, std::size_t)’ [-Werror=use-after-free]
263 | SmMlElement* getParentElement() { return m_aParentElement; };
| ^~~~~~~~~~~~~~~~
In function ‘void mathml::deleteElement(SmMlElement*, void*)’,
inlined from ‘void mathml::deleteElement(SmMlElement*, void*)’ at starmath/source/mathml/iterator.cxx:19:20,
inlined from ‘void mathml::SmMlIteratorBottomToTop(SmMlElement*, runType, void*) [with runType = void (*)(SmMlElement*, void*)]’ at starmath/inc/mathml/iterator.hxx:65:21,
inlined from ‘void mathml::SmMlIteratorFree(SmMlElement*)’ at starmath/source/mathml/iterator.cxx:57:28:
starmath/source/mathml/iterator.cxx:19:77: note: call to ‘void operator delete(void*, std::size_t)’ here
19 | static inline void deleteElement(SmMlElement* aSmMlElement, void*) { delete aSmMlElement; }
| ^~~~~~~~~~~~
Change-Id: I09acfe3f7e90bd7f919cfba161f72bdd7a8da70a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134742
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
78 lines
2.5 KiB
C++
78 lines
2.5 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <mathml/iterator.hxx>
|
|
|
|
/** The purpose of this iterator is to be able to iterate threw an infinite element tree
|
|
* infinite -> as much as your memory can hold
|
|
* No call-backs that will end up in out of stack
|
|
*/
|
|
|
|
namespace mathml
|
|
{
|
|
static inline void deleteElement(SmMlElement* aSmMlElement, void*) { delete aSmMlElement; }
|
|
|
|
static inline void cloneElement(SmMlElement* aSmMlElement, void* aData)
|
|
{
|
|
// Prepare data
|
|
SmMlElement* aNewSmMlElement = new SmMlElement(*aSmMlElement);
|
|
SmMlElement* aCopyTree = *static_cast<SmMlElement**>(aData);
|
|
|
|
// Append data
|
|
aCopyTree->setSubElement(aCopyTree->getSubElementsCount(), aNewSmMlElement);
|
|
|
|
// Prepare for following
|
|
// If it has sub elements, then it will be the next
|
|
if (aSmMlElement->getSubElementsCount() != 0)
|
|
aCopyTree = aNewSmMlElement;
|
|
else // Otherwise remounts up to where it should be
|
|
{
|
|
while (aSmMlElement->getParentElement() != nullptr)
|
|
{
|
|
// get parent
|
|
SmMlElement* pParent = aSmMlElement->getParentElement();
|
|
aCopyTree = aCopyTree->getParentElement();
|
|
// was this the last branch ?
|
|
if (aSmMlElement->getSubElementId() + 1 != pParent->getSubElementsCount())
|
|
break; // no -> stop going up
|
|
// Prepare for next round
|
|
aSmMlElement = pParent;
|
|
}
|
|
}
|
|
|
|
// Closing extras
|
|
*static_cast<SmMlElement**>(aData) = aCopyTree;
|
|
}
|
|
|
|
void SmMlIteratorFree(SmMlElement* pMlElementTree)
|
|
{
|
|
if (pMlElementTree == nullptr)
|
|
return;
|
|
for (size_t i = 0; i < pMlElementTree->getSubElementsCount(); ++i)
|
|
{
|
|
SmMlIteratorFree(pMlElementTree->getSubElement(i));
|
|
}
|
|
deleteElement(pMlElementTree, nullptr);
|
|
}
|
|
|
|
SmMlElement* SmMlIteratorCopy(SmMlElement* pMlElementTree)
|
|
{
|
|
if (pMlElementTree == nullptr)
|
|
return nullptr;
|
|
SmMlElement* aDummyElement = new SmMlElement();
|
|
SmMlIteratorTopToBottom(pMlElementTree, cloneElement, &aDummyElement);
|
|
SmMlElement* aResultElement = aDummyElement->getSubElement(0);
|
|
delete aDummyElement;
|
|
return aResultElement;
|
|
}
|
|
|
|
} // end namespace mathml
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|