Files
loongoffice/xmloff/source/draw/SignatureLineContext.cxx
Mike Kaganski 8a017d25a6 Avoid COW overhead using css::uno::Sequence
The scenarios are:

1. Calling sequence's begin() and end() in pairs to pass to algorithms
   (both calls use getArray(), which does the COW checks)
2. In addition to #1, calling end() again when checking result of find
   algorithms, and/or begin() to calculate result's distance
3. Using non-const sequences in range-based for loops, which internally
   do #1
4. Assigning sequence to another sequence variable, and then modifying
   one of them

In many cases, the sequences could be made const, or treated as const
for the purposes of the algorithms (using std::as_const, std::cbegin,
and std::cend). Where algorithm modifies the sequence, it was changed
to only call getArray() once. For that, css::uno::toNonConstRange was
introduced, which returns a struct (sublclass of std::pair) with two
iterators [begin, end], that are calculated using one call to begin()
and one call to getLength().

To handle #4, css::uno::Sequence::swap was introduced, that swaps the
internal pointer to uno_Sequence. So when a local Sequence variable
should be assigned to another variable, and the latter will be modified
further, it's now possible to use swap instead, so the two sequences
are kept independent.

The modified places were found by temporarily removing non-const end().

Change-Id: I8fe2787f200eecb70744e8b77fbdf7a49653f628
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123542
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-14 06:00:49 +02:00

137 lines
5.8 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include "SignatureLineContext.hxx"
#include <com/sun/star/beans/XPropertySet.hpp>
#include <com/sun/star/embed/XStorage.hpp>
#include <com/sun/star/frame/XModel.hpp>
#include <com/sun/star/frame/XStorable.hpp>
#include <com/sun/star/graphic/XGraphic.hpp>
#include <com/sun/star/security/DocumentDigitalSignatures.hpp>
#include <com/sun/star/security/XDocumentDigitalSignatures.hpp>
#include <com/sun/star/xml/sax/XAttributeList.hpp>
#include <sal/log.hxx>
#include <comphelper/processfactory.hxx>
#include <comphelper/storagehelper.hxx>
#include <xmloff/xmltoken.hxx>
#include <xmloff/xmlimp.hxx>
#include <xmloff/xmlnamespace.hxx>
using namespace css;
using namespace css::xml::sax;
using namespace css::uno;
using namespace css::drawing;
using namespace css::embed;
using namespace css::frame;
using namespace css::io;
using namespace css::graphic;
using namespace css::security;
using namespace xmloff::token;
SignatureLineContext::SignatureLineContext(SvXMLImport& rImport, sal_Int32 /*nElement*/,
const Reference<XFastAttributeList>& xAttrList,
const Reference<XShape>& rxShape)
: SvXMLImportContext(rImport)
{
Reference<beans::XPropertySet> xPropSet(rxShape, UNO_QUERY_THROW);
xPropSet->setPropertyValue("IsSignatureLine", Any(true));
xPropSet->setPropertyValue("SignatureLineId",
Any(xAttrList->getOptionalValue(XML_ELEMENT(LO_EXT, XML_ID))));
xPropSet->setPropertyValue(
"SignatureLineSuggestedSignerName",
Any(xAttrList->getOptionalValue(XML_ELEMENT(LO_EXT, XML_SUGGESTED_SIGNER_NAME))));
xPropSet->setPropertyValue(
"SignatureLineSuggestedSignerTitle",
Any(xAttrList->getOptionalValue(XML_ELEMENT(LO_EXT, XML_SUGGESTED_SIGNER_TITLE))));
xPropSet->setPropertyValue(
"SignatureLineSuggestedSignerEmail",
Any(xAttrList->getOptionalValue(XML_ELEMENT(LO_EXT, XML_SUGGESTED_SIGNER_EMAIL))));
xPropSet->setPropertyValue(
"SignatureLineSigningInstructions",
Any(xAttrList->getOptionalValue(XML_ELEMENT(LO_EXT, XML_SIGNING_INSTRUCTIONS))));
bool bShowSignDate = xAttrList->getOptionalValue(XML_ELEMENT(LO_EXT, XML_SHOW_SIGN_DATE))
== GetXMLToken(XML_TRUE);
bool bCanAddComment = xAttrList->getOptionalValue(XML_ELEMENT(LO_EXT, XML_CAN_ADD_COMMENT))
== GetXMLToken(XML_TRUE);
xPropSet->setPropertyValue("SignatureLineShowSignDate", Any(bShowSignDate));
xPropSet->setPropertyValue("SignatureLineCanAddComment", Any(bCanAddComment));
// Save unsigned graphic (need it when exporting)
Reference<XGraphic> xUnsignedGraphic;
xPropSet->getPropertyValue("Graphic") >>= xUnsignedGraphic;
if (xUnsignedGraphic.is())
xPropSet->setPropertyValue("SignatureLineUnsignedImage", Any(xUnsignedGraphic));
Reference<XGraphic> xGraphic;
try
{
// Get the document signatures
css::uno::Reference<XStorable> xStorable(GetImport().GetModel(), UNO_QUERY_THROW);
Reference<XStorage> xStorage = comphelper::OStorageHelper::GetStorageOfFormatFromURL(
ZIP_STORAGE_FORMAT_STRING, xStorable->getLocation(), ElementModes::READ);
if (!xStorage.is())
{
SAL_WARN("xmloff", "No xStorage!");
return;
}
OUString const aODFVersion(comphelper::OStorageHelper::GetODFVersionFromStorage(xStorage));
Reference<XDocumentDigitalSignatures> xSignatures(
security::DocumentDigitalSignatures::createWithVersion(
comphelper::getProcessComponentContext(), aODFVersion));
const Sequence<DocumentSignatureInformation> xSignatureInfo
= xSignatures->verifyDocumentContentSignatures(xStorage, Reference<XInputStream>());
// Try to find matching signature line image - if none exists that is fine,
// then the signature line is not digitally signed.
auto pSignatureInfo
= std::find_if(xSignatureInfo.begin(), xSignatureInfo.end(),
[&xAttrList](const DocumentSignatureInformation& rSignatureInfo) {
return rSignatureInfo.SignatureLineId
== xAttrList->getOptionalValue(XML_ELEMENT(LO_EXT, XML_ID));
});
bool bIsSigned(false);
if (pSignatureInfo != xSignatureInfo.end())
{
bIsSigned = true;
if (pSignatureInfo->SignatureIsValid)
{
// Signature is valid, use the 'valid' image
SAL_WARN_IF(!pSignatureInfo->ValidSignatureLineImage.is(), "xmloff",
"No ValidSignatureLineImage!");
xGraphic = pSignatureInfo->ValidSignatureLineImage;
}
else
{
// Signature is invalid, use the 'invalid' image
SAL_WARN_IF(!pSignatureInfo->InvalidSignatureLineImage.is(), "xmloff",
"No InvalidSignatureLineImage!");
xGraphic = pSignatureInfo->InvalidSignatureLineImage;
}
xPropSet->setPropertyValue("Graphic", Any(xGraphic));
}
xPropSet->setPropertyValue("SignatureLineIsSigned", Any(bIsSigned));
}
catch (css::uno::Exception&)
{
// DocumentDigitalSignatures service not available.
// We render the "unsigned" shape instead.
}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */