Files
loongoffice/qadevOOo/tests/java/mod/_sw/SwAccessibleTextGraphicObject.java
Stephan Bergmann 6287a4f0d1 [API CHANGE] Synchronize supported Writer document zoom ranges
On the one hand, SvxZoomSliderItem/SvxZoomSliderControl as used by SwView's
SID_ATTR_ZOOMSLIDER support a range from MINZOOM (20) to MAXZOOM (600) (defined
in sw/inc/view.hxx).  Setting a zoom value outside that range for one causes the
DBG_ASSERT "Looks like the zoom slider item is corrupted" in
SvxZoomSliderControl::StateChanged (svx/source/stbctrls/zoomsliderctrl.cxx) to
fire, and for another (when setting a too small value) tries to assign a
negative value (which wraps around, and gets flagged by Clang's
-fsanitize=implicit-signed-integer-truncation) to sal_uInt16 nCurrentZoom at

  nCurrentZoom = nCurrentZoom - mxImpl->mnMinZoom;

in SvxZoomSliderControl::Zoom2Offset (svx/source/stbctrls/zoomsliderctrl.cxx).

On the other hand, SwXViewSettings' support of css.text.ViewSettings' ZoomValue
property allowed values in the range from 5 to 1000 (cf.
SwXViewSettings::_setSingleValue in sw/source/uibase/uno/unomod.cxx), and some
JunitTests actually set such values (10, 15) below the MINZOOM value of 20.

The incompatible 5--1000 range was there ever since
7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import", but looks rather
random, so change it to match the 20--600 range instead.  (And lets flag this as
an [API CHANGE], to be on the safe side.)

One of the JunitTests files that needed to be adapted,
qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java, oddly mentioned a
zoom value of 130% in a comment while using the value 15 in the actual code.
(And did so ever since the test code's introduction in
26ebdfc472be16f0eb4110aab0335666d2ba5e62 "NEW: initial version".)  Changing the
code to 130 would cause JunitTest_sw_unoapi_1 to fail in strange ways, with
disposed UNO objects, while changing the code (and comment) to 21 appears to
work.  Go figure.

Change-Id: Id944ffdce501448312e008436e7038bf2aec63ac
Reviewed-on: https://gerrit.libreoffice.org/67427
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-07 09:21:50 +01:00

157 lines
5.4 KiB
Java

/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
package mod._sw;
import java.io.PrintWriter;
import lib.TestCase;
import lib.TestEnvironment;
import lib.TestParameters;
import util.AccessibilityTools;
import util.SOfficeFactory;
import util.WriterTools;
import util.utils;
import com.sun.star.accessibility.AccessibleRole;
import com.sun.star.accessibility.XAccessible;
import com.sun.star.awt.XWindow;
import com.sun.star.beans.XPropertySet;
import com.sun.star.frame.XController;
import com.sun.star.frame.XModel;
import com.sun.star.text.XText;
import com.sun.star.text.XTextContent;
import com.sun.star.text.XTextCursor;
import com.sun.star.text.XTextDocument;
import com.sun.star.uno.UnoRuntime;
import com.sun.star.uno.XInterface;
import com.sun.star.view.XViewSettingsSupplier;
/**
* Test of accessible object for the graphic object of a text document.<p>
* Object implements the following interfaces :
* <ul>
* <li> <code>::com::sun::star::accessibility::XAccessible</code></li>
* </ul>
* @see com.sun.star.accessibility.XAccessible
*/
public class SwAccessibleTextGraphicObject extends TestCase {
XTextDocument xTextDoc = null;
/**
* Called to create an instance of <code>TestEnvironment</code>
* with an object to test and related objects.
* Creates a graphic object and inserts it into the document.
* Obtains accessible object for graphic object.
*
* @param Param test parameters
* @param log writer to log information while testing
*
* @see TestEnvironment
* @see #getTestEnvironment
*/
@Override
protected TestEnvironment createTestEnvironment(
TestParameters Param, PrintWriter log) {
XInterface oObj = null;
SOfficeFactory SOF = SOfficeFactory.getFactory(Param.getMSF());
Object oGraphObj = SOF.createInstance(
xTextDoc, "com.sun.star.text.GraphicObject");
XText the_text = xTextDoc.getText();
XTextCursor the_cursor = the_text.createTextCursor();
XTextContent the_content = UnoRuntime.queryInterface(XTextContent.class, oGraphObj);
log.println( "inserting graphic" );
the_text.insertTextContent(the_cursor, the_content, true);
XModel aModel = UnoRuntime.queryInterface(XModel.class, xTextDoc);
XWindow xWindow = AccessibilityTools.getCurrentWindow(aModel);
XAccessible xRoot = AccessibilityTools.getAccessibleObject(xWindow);
oObj = AccessibilityTools.getAccessibleObjectForRole(xRoot, AccessibleRole.GRAPHIC);
log.println("ImplementationName " + utils.getImplName(oObj));
AccessibilityTools.printAccessibleTree(log, xRoot, Param.getBool(util.PropertyName.DEBUG_IS_ACTIVE));
TestEnvironment tEnv = new TestEnvironment(oObj);
XController xController = xTextDoc.getCurrentController();
XViewSettingsSupplier xViewSetSup = UnoRuntime.queryInterface(XViewSettingsSupplier.class,
xController);
final XPropertySet PropSet = xViewSetSup.getViewSettings();
tEnv.addObjRelation("EventProducer",
new ifc.accessibility._XAccessibleEventBroadcaster.EventProducer() {
public void fireEvent() {
try {
//change zoom value to 20%
PropSet.setPropertyValue("ZoomValue", Short.valueOf("20"));
//and back to 100%
PropSet.setPropertyValue("ZoomValue", Short.valueOf("100"));
} catch ( com.sun.star.lang.WrappedTargetException e ) {
} catch ( com.sun.star.lang.IllegalArgumentException e ) {
} catch ( com.sun.star.beans.PropertyVetoException e ) {
} catch ( com.sun.star.beans.UnknownPropertyException e ) {
}
}
});
return tEnv;
}
/**
* Called while disposing a <code>TestEnvironment</code>.
* Disposes text document.
* @param Param test parameters
* @param log writer to log information while testing
*/
@Override
protected void cleanup( TestParameters Param, PrintWriter log) {
log.println("dispose text document");
util.DesktopTools.closeDoc(xTextDoc);
}
/**
* Called while the <code>TestCase</code> initialization.
* Creates a text document.
*
* @param Param test parameters
* @param log writer to log information while testing
*
* @see #initializeTestCase
*/
@Override
protected void initialize(TestParameters Param, PrintWriter log) throws Exception {
log.println( "creating a text document" );
xTextDoc = WriterTools.createTextDoc(Param.getMSF());
}
}