forked from amazingfate/loongoffice
ad9498f8b8
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
157 lines
5.2 KiB
C++
157 lines
5.2 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#include <accelerators/acceleratorconfiguration.hxx>
|
|
#include <accelerators/presethandler.hxx>
|
|
#include <helper/mischelper.hxx>
|
|
|
|
#include <acceleratorconst.h>
|
|
|
|
#include <com/sun/star/util/XChangesNotifier.hpp>
|
|
#include <com/sun/star/lang/XServiceInfo.hpp>
|
|
|
|
#include <cppuhelper/supportsservice.hxx>
|
|
#include <rtl/ref.hxx>
|
|
#include <vcl/svapp.hxx>
|
|
#include <i18nlangtag/languagetag.hxx>
|
|
|
|
using namespace framework;
|
|
|
|
namespace {
|
|
|
|
/**
|
|
implements a read/write access to the global
|
|
accelerator configuration.
|
|
*/
|
|
typedef ::cppu::ImplInheritanceHelper1<
|
|
XCUBasedAcceleratorConfiguration,
|
|
css::lang::XServiceInfo > GlobalAcceleratorConfiguration_BASE;
|
|
class GlobalAcceleratorConfiguration : public GlobalAcceleratorConfiguration_BASE
|
|
{
|
|
public:
|
|
|
|
/** initialize this instance and fill the internal cache.
|
|
|
|
@param xSMGR
|
|
reference to an uno service manager, which is used internally.
|
|
*/
|
|
GlobalAcceleratorConfiguration(const css::uno::Reference< css::uno::XComponentContext >& xContext);
|
|
|
|
/** TODO */
|
|
virtual ~GlobalAcceleratorConfiguration() {}
|
|
|
|
virtual OUString SAL_CALL getImplementationName()
|
|
throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE
|
|
{
|
|
return OUString("com.sun.star.comp.framework.GlobalAcceleratorConfiguration");
|
|
}
|
|
|
|
virtual sal_Bool SAL_CALL supportsService(OUString const & ServiceName)
|
|
throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE
|
|
{
|
|
return cppu::supportsService(this, ServiceName);
|
|
}
|
|
|
|
virtual css::uno::Sequence<OUString> SAL_CALL getSupportedServiceNames()
|
|
throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE
|
|
{
|
|
css::uno::Sequence< OUString > aSeq(1);
|
|
aSeq[0] = OUString("com.sun.star.ui.GlobalAcceleratorConfiguration");
|
|
return aSeq;
|
|
}
|
|
|
|
// XComponent
|
|
virtual void SAL_CALL dispose() throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
|
|
|
|
/// This has to be called after when the instance is acquire()'d.
|
|
void fillCache();
|
|
|
|
private:
|
|
|
|
/** helper to listen for configuration changes without ownership cycle problems */
|
|
css::uno::Reference< css::util::XChangesListener > m_xCfgListener;
|
|
};
|
|
|
|
GlobalAcceleratorConfiguration::GlobalAcceleratorConfiguration(const css::uno::Reference< css::uno::XComponentContext >& xContext)
|
|
: GlobalAcceleratorConfiguration_BASE(xContext)
|
|
{
|
|
}
|
|
|
|
void GlobalAcceleratorConfiguration::fillCache()
|
|
{
|
|
/** read all data into the cache. */
|
|
|
|
#if 0
|
|
// get current office locale ... but dont cache it.
|
|
// Otherwise we must be listener on the configuration layer
|
|
// which seems to superflous for this small implementation .-)
|
|
// XXX: what is this good for? it was a comphelper::Locale but unused
|
|
LanguageTag aLanguageTag(m_sLocale);
|
|
#endif
|
|
|
|
// May be there exists no accelerator config? Handle it gracefully :-)
|
|
try
|
|
{
|
|
m_sGlobalOrModules = CFG_ENTRY_GLOBAL;
|
|
XCUBasedAcceleratorConfiguration::reload();
|
|
|
|
css::uno::Reference< css::util::XChangesNotifier > xBroadcaster(m_xCfg, css::uno::UNO_QUERY_THROW);
|
|
m_xCfgListener = new WeakChangesListener(this);
|
|
xBroadcaster->addChangesListener(m_xCfgListener);
|
|
}
|
|
catch(const css::uno::RuntimeException&)
|
|
{ throw; }
|
|
catch(const css::uno::Exception&)
|
|
{}
|
|
}
|
|
|
|
// XComponent.dispose(), #i120029#, to release the cyclic reference
|
|
|
|
void SAL_CALL GlobalAcceleratorConfiguration::dispose()
|
|
throw(css::uno::RuntimeException, std::exception)
|
|
{
|
|
try
|
|
{
|
|
css::uno::Reference< css::util::XChangesNotifier > xBroadcaster(m_xCfg, css::uno::UNO_QUERY_THROW);
|
|
if ( xBroadcaster.is() )
|
|
xBroadcaster->removeChangesListener(static_cast< css::util::XChangesListener* >(this));
|
|
}
|
|
catch(const css::uno::RuntimeException&)
|
|
{ throw; }
|
|
catch(const css::uno::Exception&)
|
|
{}
|
|
}
|
|
|
|
}
|
|
|
|
extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface * SAL_CALL
|
|
com_sun_star_comp_framework_GlobalAcceleratorConfiguration_get_implementation(
|
|
css::uno::XComponentContext *context,
|
|
css::uno::Sequence<css::uno::Any> const &)
|
|
{
|
|
GlobalAcceleratorConfiguration *inst = new GlobalAcceleratorConfiguration(context);
|
|
css::uno::XInterface *acquired_inst = cppu::acquire(inst);
|
|
|
|
inst->fillCache();
|
|
|
|
return acquired_inst;
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|