forked from amazingfate/loongoffice
c8f83ce1db
The previous fix for this bug only fixed a symptom, this a fix for the real problem; with the real problem fixed the nCellEnds is unnecessary. Given that top-level table properties may be put either before or after the table cells, the only way that works to import tables is to buffer a whole top-level table row, but currently the buffer is replayed already at the end of a nested table row. Fortunately the RTF spec guarantees that \nesttableprops must occur after the nested table cells of the nested row, so it should be sufficient to remember the cell properties for the current nested table row only, in addition to the cell properties for the top-level table row. With this change, skipping a \nesttableprops destination when there is a table style turns out to mangle ooo98040-1.rtf badly, so stop doing that workaround. RTFDocumentImpl::popState() was copying various buffers up the state stack which is a clear indication that these shouldn't be members of RTFParserState in the first place, move them to RTFDocumentImpl. Change-Id: Ic2d8f7b3e00844b224d61605b405ca651239e5f7
You can find different types of Writer tests here, the most interesting ones: - core/filters-test: loads different file types (see SwFiltersTest::testCVEs() for the list of supported filter types), and only makes sure Writer does not crash. To add new tests, you just need to drop in the test files to the relevant directory, no code change is necessary. - core/uwriter: this test has access to private Writer symbols, add new tests here if you need that. - extras: see its own README -- executes import and export filters and asserts the UNO model to verify the resulting document is the expected one.