forked from amazingfate/loongoffice
298c2d5c8a
Load a document, sign it, "green" icon on the status bar. Reload the document, turns into a "yellow" icon saying the CA is not trusted, when it was already trusted before. The trouble is that the document signature status is calculated on load, and the CA to be trusted is only given later, as part of the initialization of the LOK view. Fix the problem by invalidating the signature state when a new CA is trusted. The test document was produced by signing an empty document using the keys from xmlsecurity/qa/xmlsec/data/, which gives us a way to create a signature that is initially not trusted. Change-Id: I1e1dbf616ce54c4823d62104f838342de6870f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174307 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
117 lines
3.9 KiB
C++
117 lines
3.9 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <test/unoapi_test.hxx>
|
|
|
|
#include <com/sun/star/drawing/XDrawView.hpp>
|
|
#include <com/sun/star/beans/XPropertySet.hpp>
|
|
|
|
#include <sfx2/app.hxx>
|
|
#include <sfx2/sfxsids.hrc>
|
|
#include <sfx2/viewfrm.hxx>
|
|
#include <svl/itemset.hxx>
|
|
#include <svl/intitem.hxx>
|
|
#include <sfx2/request.hxx>
|
|
#include <sfx2/bindings.hxx>
|
|
#include <sfx2/lokhelper.hxx>
|
|
#include <sfx2/sfxbasemodel.hxx>
|
|
|
|
using namespace com::sun::star;
|
|
|
|
/// Covers sfx2/source/view/ fixes.
|
|
class Sfx2ViewTest : public UnoApiTest
|
|
{
|
|
public:
|
|
Sfx2ViewTest()
|
|
: UnoApiTest(u"/sfx2/qa/cppunit/data/"_ustr)
|
|
{
|
|
}
|
|
|
|
void setUp() override
|
|
{
|
|
UnoApiTest::setUp();
|
|
MacrosTest::setUpX509(m_directories, "sfx2_view");
|
|
}
|
|
};
|
|
|
|
CPPUNIT_TEST_FIXTURE(Sfx2ViewTest, testReloadPage)
|
|
{
|
|
// Load a document, which has 2 pages.
|
|
loadFromFile(u"reload-page.odg");
|
|
|
|
// Reload, and request to start on page 2.
|
|
SfxViewFrame* pFrame = SfxViewFrame::Current();
|
|
SfxAllItemSet aSet(SfxGetpApp()->GetPool());
|
|
aSet.Put(SfxInt32Item(SID_PAGE_NUMBER, 1));
|
|
SfxRequest aReq(SID_RELOAD, SfxCallMode::SLOT, aSet);
|
|
pFrame->ExecReload_Impl(aReq);
|
|
SfxObjectShell* pDocSh = SfxObjectShell::Current();
|
|
CPPUNIT_ASSERT(pDocSh);
|
|
uno::Reference<frame::XModel> xModel = pDocSh->GetBaseModel();
|
|
mxComponent = xModel;
|
|
|
|
// Check the current page after reload.
|
|
uno::Reference<drawing::XDrawView> xController(xModel->getCurrentController(), uno::UNO_QUERY);
|
|
uno::Reference<beans::XPropertySet> xPage(xController->getCurrentPage(), uno::UNO_QUERY);
|
|
sal_Int32 nPage{};
|
|
xPage->getPropertyValue(u"Number"_ustr) >>= nPage;
|
|
|
|
// Without the accompanying fix in place, this test would have failed with:
|
|
// - Expected: 2
|
|
// - Actual : 1
|
|
// i.e. the document was opened on page 1, not page 2, SID_PAGE_NUMBER was ignored.
|
|
CPPUNIT_ASSERT_EQUAL(static_cast<sal_Int32>(2), nPage);
|
|
}
|
|
|
|
CPPUNIT_TEST_FIXTURE(Sfx2ViewTest, testLokHelperExtractCertificates)
|
|
{
|
|
std::string signatureCa = R"(-----BEGIN CERTIFICATE-----
|
|
foo
|
|
-----END CERTIFICATE-----
|
|
-----BEGIN CERTIFICATE-----
|
|
bar
|
|
-----END CERTIFICATE-----)";
|
|
|
|
std::vector<std::string> aRet = SfxLokHelper::extractCertificates(signatureCa);
|
|
|
|
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(2), aRet.size());
|
|
CPPUNIT_ASSERT_EQUAL(std::string("\nfoo\n"), aRet[0]);
|
|
CPPUNIT_ASSERT_EQUAL(std::string("\nbar\n"), aRet[1]);
|
|
}
|
|
|
|
#ifdef UNX
|
|
CPPUNIT_TEST_FIXTURE(Sfx2ViewTest, testLokHelperAddCertifices)
|
|
{
|
|
// Given a loaded and signed document, CA is not trusted by default:
|
|
loadFromFile(u"signed.odt");
|
|
auto pBaseModel = dynamic_cast<SfxBaseModel*>(mxComponent.get());
|
|
SfxObjectShell* pObjectShell = pBaseModel->GetObjectShell();
|
|
CPPUNIT_ASSERT_EQUAL(SignatureState::NOTVALIDATED, pObjectShell->GetDocumentSignatureState());
|
|
|
|
// When trusting the CA:
|
|
OUString aCaUrl = createFileURL(u"ca.pem");
|
|
SvFileStream aCaStream(aCaUrl, StreamMode::READ);
|
|
std::string aCa;
|
|
aCa = read_uInt8s_ToOString(aCaStream, aCaStream.remainingSize());
|
|
std::vector<std::string> aCerts = SfxLokHelper::extractCertificates(aCa);
|
|
SfxLokHelper::addCertificates(aCerts);
|
|
|
|
// Then make sure the signature state is updated:
|
|
// Without the accompanying fix in place, this test would have failed with:
|
|
// - Expected: 1 (OK)
|
|
// - Actual : 4 (SignatureState::NOTVALIDATED)
|
|
// i.e. the signature status for an opened document was not updated when trusting a CA.
|
|
CPPUNIT_ASSERT_EQUAL(SignatureState::OK, pObjectShell->GetDocumentSignatureState());
|
|
}
|
|
#endif
|
|
|
|
CPPUNIT_PLUGIN_IMPLEMENT();
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|