zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some cleanup for base/logging and base/stream.h

Browse Source 
* Fix race when calling UpdateMinLogSeverity
* Remove unused 'diagnostic mode'
* Remove LogToStream
* Fix ctor of StringStream
* Delete POpenStream
* Delete AsyncWriteStream
* Delete CircularFileStream
* Delete StreamSegment

BUG=
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/57429004

Cr-Commit-Position: refs/heads/master@{#9273}
This commit is contained in:
Tommi
2015-05-25 11:25:59 +02:00
parent 23edcff7a9
commit 00aac5aacf
12 changed files with 18 additions and 700 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
webrtc/base/logging_unittest.cc
View File

@ -25,13 +25,8 @@ class LogSinkImpl
public:
LogSinkImpl() {}
// The non-const reference constructor is required because of StringStream.
// TODO(tommi): Fix StringStream to accept a pointer for non-const.
template<typename P>
explicit LogSinkImpl(P& p) : Base(p) {}
template<typename P>
explicit LogSinkImpl(const P& p) : Base(p) {}
explicit LogSinkImpl(P* p) : Base(p) {}
private:
void OnLogMessage(const std::string& message) override {
@ -46,7 +41,7 @@ TEST(LogTest, SingleStream) {
int sev = LogMessage::GetLogToStream(NULL);
std::string str;
LogSinkImpl<StringStream> stream(str);
LogSinkImpl<StringStream> stream(&str);
LogMessage::AddLogToStream(&stream, LS_INFO);
EXPECT_EQ(LS_INFO, LogMessage::GetLogToStream(&stream));
@ -68,7 +63,7 @@ TEST(LogTest, MultipleStreams) {
int sev = LogMessage::GetLogToStream(NULL);
std::string str1, str2;
LogSinkImpl<StringStream> stream1(str1), stream2(str2);
LogSinkImpl<StringStream> stream1(&str1), stream2(&str2);
LogMessage::AddLogToStream(&stream1, LS_INFO);
LogMessage::AddLogToStream(&stream2, LS_VERBOSE);
EXPECT_EQ(LS_INFO, LogMessage::GetLogToStream(&stream1));