Remove QualityScaler kDefaultLowQpDenominator.

This denominator doesn't make any semantic sense, it's better to use
real thresholds for when things look "good" or "bad" rather than
fractions of a max QP.

BUG=webrtc:5678
R=danilchap@webrtc.org

Review URL: https://codereview.webrtc.org/1855393005 .

Cr-Commit-Position: refs/heads/master@{#12363}
This commit is contained in:
Peter Boström
2016-04-14 17:04:03 +02:00
parent 926dfcdf5e
commit 00b62b0849
4 changed files with 11 additions and 17 deletions

View File

@ -600,11 +600,11 @@ int VP8EncoderImpl::InitEncode(const VideoCodec* inst,
rps_.Init();
// Disable both high-QP limits and framedropping. Both are handled by libvpx
// internally.
const int kLowQpThreshold = 18;
const int kDisabledBadQpThreshold = 64;
// TODO(glaznev/sprang): consider passing codec initial bitrate to quality
// scaler to avoid starting with HD for low initial bitrates.
quality_scaler_.Init(codec_.qpMax / QualityScaler::kDefaultLowQpDenominator,
kDisabledBadQpThreshold, false, 0, 0, 0,
quality_scaler_.Init(kLowQpThreshold, kDisabledBadQpThreshold, false, 0, 0, 0,
codec_.maxFramerate);
// Only apply scaling to improve for single-layer streams. The scaling metrics