zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Unify helpers IsRtpPacket and IsRtcpPacket

Browse Source 
Bug: None
Change-Id: Ibe942de433435d256cd6827440136936d4b274d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225022
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34419}
This commit is contained in:
Danil Chapovalov
2021-07-05 19:06:17 +02:00
committed by WebRTC LUCI CQ
parent 93ce46fc63
commit 00ca0044d4
23 changed files with 208 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
modules/rtp_rtcp/source/rtp_util_unittest.cc Normal file
View File

@ -0,0 +1,59 @@
/*
* Copyright (c) 2021 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "modules/rtp_rtcp/source/rtp_util.h"
#include "test/gmock.h"
namespace webrtc {
namespace {
TEST(RtpUtil, IsRtpPacket) {
constexpr uint8_t kMinimalisticRtpPacket[] = {0x80, 97, 0, 0, //
0, 0, 0, 0, //
0, 0, 0, 0};
EXPECT_TRUE(IsRtpPacket(kMinimalisticRtpPacket));
constexpr uint8_t kWrongRtpVersion[] = {0xc0, 97, 0, 0, //
0, 0, 0, 0, //
0, 0, 0, 0};
EXPECT_FALSE(IsRtpPacket(kWrongRtpVersion));
constexpr uint8_t kPacketWithPayloadForRtcp[] = {0x80, 200, 0, 0, //
0, 0, 0, 0, //
0, 0, 0, 0};
EXPECT_FALSE(IsRtpPacket(kPacketWithPayloadForRtcp));
constexpr uint8_t kTooSmallRtpPacket[] = {0x80, 97, 0, 0, //
0, 0, 0, 0, //
0, 0, 0};
EXPECT_FALSE(IsRtpPacket(kTooSmallRtpPacket));
EXPECT_FALSE(IsRtpPacket({}));
}
TEST(RtpUtil, IsRtcpPacket) {
constexpr uint8_t kMinimalisticRtcpPacket[] = {0x80, 202, 0, 0};
EXPECT_TRUE(IsRtcpPacket(kMinimalisticRtcpPacket));
constexpr uint8_t kWrongRtpVersion[] = {0xc0, 202, 0, 0};
EXPECT_FALSE(IsRtcpPacket(kWrongRtpVersion));
constexpr uint8_t kPacketWithPayloadForRtp[] = {0x80, 225, 0, 0};
EXPECT_FALSE(IsRtcpPacket(kPacketWithPayloadForRtp));
constexpr uint8_t kTooSmallRtcpPacket[] = {0x80, 202, 0};
EXPECT_FALSE(IsRtcpPacket(kTooSmallRtcpPacket));
EXPECT_FALSE(IsRtcpPacket({}));
}
} // namespace
} // namespace webrtc