zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete lsan and valgrind suppressions for deleted xmpp tests

Browse Source 
The xmpp code has been moved to chromium, see
https://codereview.webrtc.org/2617443003.

Also delete valgrind-related presubmit checks; they were
broken when chromium dropped support for valgrind.

Bug: webrtc:3608, webrtc:5539
Tbr: phoglund@webrtc.org
Change-Id: I8c1883cfd3ba29b106b75605851cdfedf7c161bd
Reviewed-on: https://webrtc-review.googlesource.com/90407
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24123}
This commit is contained in:
Niels Möller
2018-07-27 09:09:39 +02:00
committed by Commit Bot
parent 421f868d8a
commit 010955e179
4 changed files with 0 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tools_webrtc/PRESUBMIT.py
View File

@ -6,8 +6,6 @@
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
import os
def _LicenseHeader(input_api):
"""Returns the license header regexp."""
@ -30,34 +28,11 @@ def _LicenseHeader(input_api):
}
return license_header
def _CheckValgrindFiles(input_api, output_api):
"""Check that valgrind-webrtc.gni contains all existing files."""
valgrind_dir = os.path.join('tools_webrtc', 'valgrind')
with open(os.path.join('valgrind', 'valgrind-webrtc.gni')) as f:
valgrind_webrtc = f.read()
results = []
for f in input_api.AffectedFiles():
f = f.LocalPath()
if (f.startswith(valgrind_dir)
and f not in valgrind_webrtc
and not f.endswith('valgrind-webrtc.gni')):
results.append(' * %s\n' % f)
if results:
results = [output_api.PresubmitError(
'The following files are not listed in '
'tools_webrtc/valgrind/valgrind-webrt.gni. Please add them, so they can '
'be isolated and uploaded to swarming:\n' +
''.join(file_path for file_path in results))]
return results
def _CommonChecks(input_api, output_api):
"""Checks common to both upload and commit."""
results = []
results.extend(input_api.canned_checks.CheckLicense(
input_api, output_api, _LicenseHeader(input_api)))
results.extend(_CheckValgrindFiles(input_api, output_api))
return results
def CheckChangeOnUpload(input_api, output_api):