zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable VideoSendStreamTest.MinTransmitBitrateRespectsRemb in Mac.

Browse Source 
Test is flaky there, especially with the task queue pacer enabled.

Bug: webrtc:13294
Change-Id: I1b2fdbbf6b760bd0cbeb8992442549c7d50abb09
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235660
Reviewed-by: Evan Shrubsole <eshr@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35232}
This commit is contained in:
Erik Språng
2021-10-19 11:09:34 +02:00
committed by WebRTC LUCI CQ
parent 3791d332c5
commit 011b5d1545
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
video/video_send_stream_tests.cc
View File

@ -1458,7 +1458,14 @@ TEST_F(VideoSendStreamTest, PaddingIsPrimarilyRetransmissions) {
// //
// Note that the test starts at "high" bitrate and does not ramp up to "higher" // Note that the test starts at "high" bitrate and does not ramp up to "higher"
// bitrate since no receiver block or remb is sent in the initial phase. // bitrate since no receiver block or remb is sent in the initial phase.
TEST_F(VideoSendStreamTest, MinTransmitBitrateRespectsRemb) { // TODO(bugs.webrtc.org/13294): Fix flakiness or replace with scenario test.
#if defined(WEBRTC_MAC)
#define MAYBE_MinTransmitBitrateRespectsRemb \
DISABLED_MinTransmitBitrateRespectsRemb
#else
#define MAYBE_MinTransmitBitrateRespectsRemb MinTransmitBitrateRespectsRemb
#endif
TEST_F(VideoSendStreamTest, MAYBE_MinTransmitBitrateRespectsRemb) {
static const int kMinTransmitBitrateBps = 400000; static const int kMinTransmitBitrateBps = 400000;
static const int kHighBitrateBps = 150000; static const int kHighBitrateBps = 150000;
static const int kRembBitrateBps = 80000; static const int kRembBitrateBps = 80000;