zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Enable and fix chromium clang warnings in rtp_rtcp test targets"

Browse Source 
This reverts commit 9486b117daac09c9f7ac8450ccda835938cf3150.

Reason for revert: Breaks downstream project

Original change's description:
> Enable and fix chromium clang warnings in rtp_rtcp test targets
> 
> Bug: webrtc:163
> Change-Id: I4ed3e63296d8bf06536a83196d597c7a906ba11c
> Reviewed-on: https://webrtc-review.googlesource.com/60802
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22357}

TBR=danilchap@webrtc.org,phoglund@webrtc.org,terelius@webrtc.org

Change-Id: I2c3777ea9f26813bdb395e7fd68f6b49443586ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:163
Reviewed-on: https://webrtc-review.googlesource.com/61060
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22365}
This commit is contained in:
Oleh Prypin
2018-03-09 14:49:01 +00:00
committed by Commit Bot
parent d4bc01b7dd
commit 01aa210fad
32 changed files with 52 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
View File

@ -35,7 +35,7 @@ class RtcpCallback : public RtcpIntraFrameObserver {
}
virtual void OnLipSyncUpdate(const int32_t id,
const int32_t audioVideoOffset) {}
void OnReceivedIntraFrameRequest(uint32_t ssrc) override {}
virtual void OnReceivedIntraFrameRequest(uint32_t ssrc) {}
private:
RtpRtcp* _rtpRtcpModule;
@ -44,7 +44,7 @@ class RtcpCallback : public RtcpIntraFrameObserver {
class TestRtpFeedback : public NullRtpFeedback {
public:
explicit TestRtpFeedback(RtpRtcp* rtp_rtcp) : rtp_rtcp_(rtp_rtcp) {}
~TestRtpFeedback() override = default;
virtual ~TestRtpFeedback() {}
void OnIncomingSSRCChanged(uint32_t ssrc) override {
rtp_rtcp_->SetRemoteSSRC(ssrc);
@ -64,9 +64,9 @@ class RtpRtcpRtcpTest : public ::testing::Test {
test_timestamp = 4567;
test_sequence_number = 2345;
}
~RtpRtcpRtcpTest() override = default;
~RtpRtcpRtcpTest() {}
void SetUp() override {
virtual void SetUp() {
receiver = new TestRtpReceiver();
transport1 = new LoopBackTransport();
transport2 = new LoopBackTransport();
@ -149,7 +149,7 @@ class RtpRtcpRtcpTest : public ::testing::Test {
test, 8, nullptr, nullptr, nullptr));
}
void TearDown() override {
virtual void TearDown() {
delete module1;
delete module2;
delete myRTCPFeedback1;