zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Disable TestVp9ImplProfile2.EncodeDecode on iOS."

Browse Source 
This reverts commit 141953965653262a5cd5761daf238070ae8bd530.

Reason for revert: The issue has been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1539000.

Original change's description:
> Disable TestVp9ImplProfile2.EncodeDecode on iOS.
> 
> The test crashes in libvpx VP9 encoder on iOS simulator.
> 
> Bug: webrtc:10473
> Change-Id: I99ad0ac45e55f445cf1b3964ff0e66020fccb1f6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129441
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27266}

TBR=ilnik@webrtc.org,ssilkin@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:10473
Change-Id: Id602795fcd6fa4c2bb4cb424f8a559ce92d52ba7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129763
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27298}
This commit is contained in:
Mirko Bonadei
2019-03-26 19:05:25 +00:00
committed by Commit Bot
parent e27ccf9a16
commit 01b25587eb
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc
View File

@ -1436,13 +1436,7 @@ class TestVp9ImplProfile2 : public TestVp9Impl {
}
};
#if defined(OS_IOS)
// TODO(webrtc:10473): Libvpx VP9 encoder crashes on iOS simulator.
#define MAYBE_EncodeDecode DISABLED_EncodeDecode
#else
#define MAYBE_EncodeDecode EncodeDecode
#endif
TEST_F(TestVp9ImplProfile2, MAYBE_EncodeDecode) {
TEST_F(TestVp9ImplProfile2, EncodeDecode) {
if (!encoder_)
return;