zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add nogncheck for headers of codecs not used in Chromium.

Browse Source 
iLBC [1] and Red [2] are not used in Chromium, this means that WebRTC
doeesn't add the GN dependency on them but the include checker
complains because when it parses the code it sees iLBC and Red headers
included (the GN checker doesn't run the c preprocessor).

[1] - https://cs.chromium.org/chromium/src/.gn?l=62-65&rcl=3f6c31f0fdba128d810c4e3e391fae3b1aca7e7c
[2] - https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/audio_coding.gni?l=28-30&rcl=eb254b40b33380fcec43028dd89f3f6bab3d08a7

Bug: chromium:824831
Change-Id: I5059c1773fbe35f568c2fe3d8db3807f29973e7e
Reviewed-on: https://webrtc-review.googlesource.com/97620
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24546}
This commit is contained in:
Mirko Bonadei
2018-09-04 10:47:15 +02:00
committed by Commit Bot
parent cb96062e05
commit 01cd853d2e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/audio_coding/acm2/rent_a_codec.cc
View File

@ -18,7 +18,7 @@
#include "rtc_base/logging.h"
#include "modules/audio_coding/codecs/g722/audio_encoder_g722.h"
#ifdef WEBRTC_CODEC_ILBC
#include "modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h"
#include "modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h" // nogncheck
#endif
#ifdef WEBRTC_CODEC_ISACFX
#include "modules/audio_coding/codecs/isac/fix/include/audio_decoder_isacfix.h" // nogncheck
@ -33,7 +33,7 @@
#endif
#include "modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.h"
#ifdef WEBRTC_CODEC_RED
#include "modules/audio_coding/codecs/red/audio_encoder_copy_red.h"
#include "modules/audio_coding/codecs/red/audio_encoder_copy_red.h" // nogncheck
#endif
#include "modules/audio_coding/acm2/acm_codec_database.h"