Revert of Bailing out if pc factory fails to get created. (patchset #1 id:1 of https://codereview.webrtc.org/1339923004/ )
Reason for revert: Breaks goma (??!??!?) Original issue's description: > Bailing out if pc factory fails to get created. > > This prevents us from continuing if we fail initialization. > The failure will happen closer to its source, rather than > when we try to create the first peer connection. > > BUG=None > R=glaznev@webrtc.org > > Committed: https://crrev.com/6eb75d9e67f02c256436eb96f3c77026486561a1 > Cr-Commit-Position: refs/heads/master@{#9948} TBR=glaznev@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.webrtc.org/1344363002 Cr-Commit-Position: refs/heads/master@{#9949}
This commit is contained in:
@ -1103,8 +1103,6 @@ JOW(jlong, PeerConnectionFactory_nativeCreatePeerConnectionFactory)(
|
|||||||
NULL,
|
NULL,
|
||||||
encoder_factory,
|
encoder_factory,
|
||||||
decoder_factory));
|
decoder_factory));
|
||||||
CHECK(factory) << "Failed to create the peer connection factory; "
|
|
||||||
<< "WebRTC/libjingle init likely failed on this device";
|
|
||||||
OwnedFactoryAndThreads* owned_factory = new OwnedFactoryAndThreads(
|
OwnedFactoryAndThreads* owned_factory = new OwnedFactoryAndThreads(
|
||||||
worker_thread, signaling_thread,
|
worker_thread, signaling_thread,
|
||||||
encoder_factory, decoder_factory,
|
encoder_factory, decoder_factory,
|
||||||
|
Reference in New Issue
Block a user