From 022082f1c8bc5c8a7c98534de9cd41c2ae894dd2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Fri, 7 Aug 2020 14:40:09 +0000 Subject: [PATCH] Revert "Makes aborting delayed probes default enabled." MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit b898cee41e6909ce0c359c53a8f1de86549974b8. Reason for revert: Triggers unexpectedly large perf changes. Original change's description: > Makes aborting delayed probes default enabled. > > Bug: webrtc:11780 > Change-Id: Id4bd884e1d75eb1adc4f4f5aa7f0cb7f83eea0f7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180820 > Reviewed-by: Sebastian Jansson > Commit-Queue: Erik Språng > Cr-Commit-Position: refs/heads/master@{#31864} TBR=sprang@webrtc.org,srte@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11780 Change-Id: I9ea728ab48fdb3144d6c25ecb8808d40f57aba9e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181076 Reviewed-by: Erik Språng Commit-Queue: Erik Språng Cr-Commit-Position: refs/heads/master@{#31886} --- modules/pacing/bitrate_prober.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/pacing/bitrate_prober.cc b/modules/pacing/bitrate_prober.cc index d528a3aad4..1949570d86 100644 --- a/modules/pacing/bitrate_prober.cc +++ b/modules/pacing/bitrate_prober.cc @@ -38,7 +38,8 @@ BitrateProberConfig::BitrateProberConfig( min_probe_delta("min_probe_delta", TimeDelta::Millis(1)), min_probe_duration("min_probe_duration", TimeDelta::Millis(15)), max_probe_delay("max_probe_delay", TimeDelta::Millis(3)), - abort_delayed_probes("abort_delayed_probes", true) { + // TODO(bugs.webrtc.org/11780): Change to default true. + abort_delayed_probes("abort_delayed_probes", false) { ParseFieldTrial( {&min_probe_packets_sent, &min_probe_delta, &min_probe_duration, &max_probe_delay, &abort_delayed_probes},