From 022567dc9c184fb44d44473e47e2570d890eaf86 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Tue, 20 Jul 2021 08:33:08 +0000 Subject: [PATCH] Revert "Make webrtc_fuzzer_test use //:common_config." This reverts commit 9e09831767995531ae1c2804e1c15fa2be4053f2. Reason for revert: The "fuzzer_test" GN template expanded by "webrtc_fuzzer_test" still ignores the "configs" and another field needs to be used. Original change's description: > Make webrtc_fuzzer_test use //:common_config. > > Before this CL, the GN template webrtc_fuzzer_test was using a build > config that was different from the one used by other WebRTC's targets. > > We discovered this in [1] where we detected that RTC_DCHECK_IS_ON had > different values across translation units (1 everywhere and 0 in the > one of the .cc file owned by the webrtc_fuzzer_test). > > This was because webrtc_fuzzer_test was not including the default > config //:common_config in its "configs". > > [1] - https://webrtc-review.googlesource.com/c/src/+/226465 > > Bug: None > Change-Id: I5635d90281769c23c5d86ebc8cb494da029c2e85 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226540 > Reviewed-by: Andrey Logvin > Commit-Queue: Mirko Bonadei > Cr-Commit-Position: refs/heads/master@{#34509} TBR=mbonadei@webrtc.org,landrey@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iec13b411e7f027e78e731e3242e0557b6de38a2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226541 Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#34510} --- test/fuzzers/BUILD.gn | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/fuzzers/BUILD.gn b/test/fuzzers/BUILD.gn index 4afab1d8af..9824bebb5f 100644 --- a/test/fuzzers/BUILD.gn +++ b/test/fuzzers/BUILD.gn @@ -42,7 +42,6 @@ rtc_library("fuzz_data_helper") { } set_defaults("webrtc_fuzzer_test") { - configs = rtc_add_configs absl_deps = [] } @@ -53,7 +52,6 @@ template("webrtc_fuzzer_test") { ":fuzz_data_helper", ":webrtc_fuzzer_main", ] - configs += invoker.configs # If absl_deps is [], no action is needed. If not [], then it needs to be # converted to //third_party/abseil-cpp:absl when build_with_chromium=true