zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop using public_deps to depend on libyuv.

Browse Source 
A lot of WebRTC targets were depending on //third_party/libyuv using
public_deps instead of deps. This causes issues because a the
inclusion of libyuv headers is not declared to the build system and
this creates hidden dependencies that put the modularity of the project
at risk.

Bug: webrtc:8603
Change-Id: Ide0ceb84eb5640ae664dc782f3a722b55c3b601a
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/28120
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21039}
This commit is contained in:
Mirko Bonadei
2017-12-01 13:53:04 +01:00
committed by Commit Bot
parent 83d27683a8
commit 0250be51be
10 changed files with 25 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/video_coding/BUILD.gn
View File

@ -232,6 +232,7 @@ rtc_static_library("webrtc_i420") {
deps = [
":video_coding_utility",
"$rtc_libyuv_dir",
"../..:webrtc_common",
"../../api:video_frame_api_i420",
"../../common_video:common_video",
@ -291,6 +292,7 @@ rtc_static_library("webrtc_vp8") {
deps = [
":video_coding_utility",
"$rtc_libyuv_dir",
"..:module_api",
"../..:webrtc_common",
"../../api:optional",