zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop using public_deps to depend on libyuv.

Browse Source 
A lot of WebRTC targets were depending on //third_party/libyuv using
public_deps instead of deps. This causes issues because a the
inclusion of libyuv headers is not declared to the build system and
this creates hidden dependencies that put the modularity of the project
at risk.

Bug: webrtc:8603
Change-Id: Ide0ceb84eb5640ae664dc782f3a722b55c3b601a
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/28120
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21039}
This commit is contained in:
Mirko Bonadei
2017-12-01 13:53:04 +01:00
committed by Commit Bot
parent 83d27683a8
commit 0250be51be
10 changed files with 25 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
rtc_tools/BUILD.gn
View File

@ -63,9 +63,8 @@ rtc_static_library("video_quality_analysis") {
"frame_analyzer/video_quality_analysis.cc",
"frame_analyzer/video_quality_analysis.h",
]
public_deps = [
"../common_video",
deps = [
"$rtc_libyuv_dir",
]
}
@ -77,6 +76,7 @@ rtc_executable("frame_analyzer") {
deps = [
":command_line_parser",
":video_quality_analysis",
"$rtc_libyuv_dir",
"//build/win:default_exe_manifest",
]
}
@ -92,6 +92,7 @@ if (!build_with_chromium) {
deps = [
":command_line_parser",
":video_quality_analysis",
"$rtc_libyuv_dir",
"//build/win:default_exe_manifest",
]
}
@ -104,6 +105,7 @@ if (!build_with_chromium) {
deps = [
":video_quality_analysis",
"$rtc_libyuv_dir",
]
}
@ -128,6 +130,7 @@ if (!build_with_chromium) {
deps = [
":command_line_parser",
"$rtc_libyuv_dir",
"../common_video",
"//build/win:default_exe_manifest",
]
@ -322,6 +325,8 @@ if (rtc_include_tests) {
":frame_editing_lib",
":reference_less_video_analysis_lib",
":video_quality_analysis",
"$rtc_libyuv_dir",
"../common_video:common_video",
"../rtc_base",
"../test:test_main",
"//testing/gtest",