zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary video factory references in PeerConnectionFactory

Browse Source 
The video codec factories should be owned by the video engine instead
of by the PeerConnectionFactory.

Bug: None
Change-Id: If63d47cef565138d51377af3fc9ea973950c9390
Reviewed-on: https://webrtc-review.googlesource.com/1601
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20002}
This commit is contained in:
Magnus Jedvert
2017-09-23 17:21:32 +02:00
committed by Commit Bot
parent 03ec4f8188
commit 02e7a1981a
13 changed files with 128 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/android/src/jni/pc/peerconnectionfactory_jni.cc
View File

@ -197,8 +197,8 @@ JNI_FUNCTION_DECLARATION(
rtc::scoped_refptr<PeerConnectionFactoryInterface> factory(
CreateModularPeerConnectionFactory(
network_thread.get(), worker_thread.get(), signaling_thread.get(),
video_encoder_factory, video_decoder_factory, std::move(media_engine),
std::move(call_factory), std::move(rtc_event_log_factory)));
std::move(media_engine), std::move(call_factory),
std::move(rtc_event_log_factory)));
RTC_CHECK(factory) << "Failed to create the peer connection factory; "
<< "WebRTC/libjingle init likely failed on this device";
// TODO(honghaiz): Maybe put the options as the argument of